SWPROT-9430: Address review comments

Author: Thomasdjb

applications/zpc/components/zpc_stdin/test/zpc_stdin_test.c

@@ -333,8 +333,8 @@ void test_handle_cc_versions_log()
 void test_handle_nls()
 {
   sl_status_t state;
-  uint8_t nls_state = false;
-  uint8_t nls_support = false;
+  uint8_t nls_state = 0;
+  uint8_t nls_support = 0;
 
   state = uic_stdin_handle_command("zwave_enable_nls");
   TEST_ASSERT_EQUAL(SL_STATUS_FAIL, state);

applications/zpc/components/zwave/zwave_transports/s2/src/zwave_s2_network.c

@@ -148,8 +148,7 @@ void zwave_s2_network_init()
     return;
   }
 
-  sl_log_info(LOG_TAG, "NLS support %s for Node ID: %d\n", nls_support == 1 ? "supported" : "not supported", node_id);
-  sl_log_info(LOG_TAG, "NLS state %s for Node ID: %d\n", nls_state == 1 ? "active" : "not active", node_id);
+  sl_log_info(LOG_TAG, "NLS %s, NLS %s for Node ID: %d\n", nls_support == 0 ? "not supported" : "supported", nls_state == 0 ? "not active" : "active", node_id);
 
   S2_load_nls_state(s2_ctx, nls_state);
   status = zwave_store_nls_state(node_id, nls_state, REPORTED_ATTRIBUTE) || zwave_store_nls_support(node_id, nls_support, REPORTED_ATTRIBUTE);

applications/zpc/components/zwave_api/include/zwapi_protocol_controller.h

@@ -1049,6 +1049,8 @@ sl_status_t zwapi_enable_node_nls(const zwave_node_id_t nodeId);
  * @brief Get the NLS State of the node in the controller NVM 
  * 
  * @param nodeId the node ID
+ * @param nls_state NLS state pointer to be filled
+ * @param nls_support NLS support pointer to be filled
  * 
  */
 sl_status_t zwapi_get_node_nls(const zwave_node_id_t nodeId, uint8_t* nls_state, uint8_t* nls_support);

applications/zpc/components/zwave_api/src/zwapi_protocol_controller.c

@@ -829,6 +829,9 @@ sl_status_t zwapi_get_node_nls(
   {
     *nls_support = response_buffer[IDX_DATA];
     *nls_state = response_buffer[IDX_DATA + 1];
+    if (((*nls_support != 0) && (*nls_support != 1)) || ((*nls_state != 0) && (*nls_state != 1))) {
+      return SL_STATUS_FAIL;
+    }
     return SL_STATUS_OK;
   }