Fixed Node ID for generated UUID v1 to check for valid MAC address.

Author: amsga

CHANGELOG.md

@@ -8,6 +8,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [v2.3.1] - 2025-07-01
+[v2.3.1](https://github.com/TensionDev/UUIDUtil/releases/tag/v2.3.1)
+
+### Fixed
+- Fixed Node ID for generated UUID v1 to check for valid MAC address.
+
+
 ## [v2.3.0] - 2025-03-30
 [v2.3.0](https://github.com/TensionDev/UUIDUtil/releases/tag/v2.3.0)
 

UUIDUtil/UUIDUtil.csproj

@@ -10,7 +10,7 @@
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
     <PackageId>TensionDev.UUID</PackageId>
-    <Version>2.3.0</Version>
+    <Version>2.3.1</Version>
     <Authors>TensionDev amsga</Authors>
     <Company>TensionDev</Company>
     <Product>TensionDev.UUID</Product>

UUIDUtil/UUIDv1.cs

@@ -15,6 +15,7 @@
 //   limitations under the License.
 
 using System;
+using System.Linq;
 
 namespace TensionDev.UUID
 {
@@ -127,14 +128,20 @@ public static Byte[] GetNodeID()
         {
             if (System.Net.NetworkInformation.PhysicalAddress.None.Equals(s_physicalAddress))
             {
-                System.Net.NetworkInformation.NetworkInterface[] networkInterfaces = System.Net.NetworkInformation.NetworkInterface.GetAllNetworkInterfaces();
-                if (networkInterfaces.Length > 0)
+                var networkInterfaces = System.Net.NetworkInformation.NetworkInterface.GetAllNetworkInterfaces();
+                foreach (var networkInterface in networkInterfaces)
                 {
-                    s_physicalAddress = networkInterfaces[0].GetPhysicalAddress();
+                    var address = networkInterface.GetPhysicalAddress();
+                    if (!address.Equals(System.Net.NetworkInformation.PhysicalAddress.None))
+                    {
+                        s_physicalAddress = address;
+                        break;
+                    }
                 }
-                else
+                if (s_physicalAddress.Equals(System.Net.NetworkInformation.PhysicalAddress.None))
                 {
-                    using (System.Security.Cryptography.RNGCryptoServiceProvider cryptoServiceProvider = new System.Security.Cryptography.RNGCryptoServiceProvider())
+                    // Fallback to random
+                    using (var cryptoServiceProvider = new System.Security.Cryptography.RNGCryptoServiceProvider())
                     {
                         Byte[] fakeNode = new Byte[6];
                         cryptoServiceProvider.GetBytes(fakeNode);