add more ruff-lint checks

rgonalo · rgonalo · commit dcf96fb01be2 · 2026-02-12T16:02:54.000+01:00
diff --git a/docs/conf.py b/docs/conf.py
@@ -292,7 +292,7 @@
 intersphinx_mapping = {'python': ('https://docs.python.org/3', None)}
 
 
-def remove_module_docstring(app, what, name, obj, options, lines):
+def remove_module_docstring(app, what, name, obj, options, lines):  # noqa: ARG001
     """Remove all module docstrings to exclude license header"""
     if what == 'module':
         del lines[:]
diff --git a/pyproject.toml b/pyproject.toml
@@ -114,15 +114,18 @@ target-version = "py310"
 select = [
     "E",   # pycodestyle errors
     "W",   # pycodestyle warnings
-    "F",   # Pyflakes
+    "F",   # pyflakes
     "I",   # isort
     "UP",  # pyupgrade
     "N",   # pep8-naming
-    "B",   # flake8-bugbear
     "A",   # flake8-builtins
+    "B",   # flake8-bugbear
+    "G",   # flake8-logging-format
+    "ARG", # flake8-unused-arguments
     "COM", # flake8-commas
     "C4",  # flake8-comprehensions
     "PT",  # flake8-pytest-style
+    "T20", # flake8-print
     "RUF", # Ruff-specific rules
 ]
 # Rules to ignore
diff --git a/toolium/behave/env_utils.py b/toolium/behave/env_utils.py
@@ -226,7 +226,7 @@ def __execute_steps_by_action(self, context, action):
             for item in self.actions[action]:
                 try:
                     self.__print_step_by_console(item)
-                    self.logger.debug(f'Executing step defined in {action}: {item!r}')
+                    self.logger.debug('Executing step defined in %s: %r', action, item)
                     context.execute_steps(f"""{GIVEN_PREFIX}{self.__remove_prefix(item)}""")
                 except Exception as exc:
                     if action == ACTIONS_BEFORE_FEATURE:
@@ -299,7 +299,7 @@ def execute_after_feature_steps(self, context):
                 if scenario.should_run(context.config):
                     self.fail_first_step_precondition_exception(scenario, error_message)
                     if len(scenario.background_steps) > 0:
-                        context.logger.warn('Background from scenario status udpated to fail')
+                        context.logger.warning('Background from scenario status udpated to fail')
             raise Exception(f'Before feature steps have failed: {error_message}')
 
     def fail_first_step_precondition_exception(self, scenario, error_message):
diff --git a/toolium/config_driver.py b/toolium/config_driver.py
@@ -399,7 +399,7 @@ def _add_chrome_additional_options(self, options):
                     self.logger.debug('Added Chrome additional option: %s = %s', key, value)
                     options.add_experimental_option(key, value)
             except Exception as exc:
-                self.logger.warning(f'Chrome options "{chrome_options}" can not be added: {exc}')
+                self.logger.warning('Chrome options "%s" can not be added: %s', chrome_options, exc)
 
     def _add_chrome_arguments(self, options):
         """Add Chrome arguments from properties file
diff --git a/toolium/driver_wrapper.py b/toolium/driver_wrapper.py
@@ -120,7 +120,7 @@ def configure_logger(self, tc_config_log_filename=None, tc_output_log_filename=N
             try:
                 logging.config.fileConfig(config_log_filename, {'logfilename': output_log_filename}, False)
             except Exception as exc:
-                print(f"[WARN] Error reading logging config file '{config_log_filename}': {exc}")
+                print(f"[WARN] Error reading logging config file '{config_log_filename}': {exc}")  # noqa: T201
             self.config_log_filename = config_log_filename
             self.output_log_filename = output_log_filename
             self.logger = logging.getLogger(__name__)
diff --git a/toolium/driver_wrappers_pool.py b/toolium/driver_wrappers_pool.py
@@ -172,7 +172,8 @@ def stop_drivers(cls, maintain_default=False):
                 driver_wrapper.stop()
             except Exception as e:
                 driver_wrapper.logger.warning(
-                    f'Capture exceptions to avoid errors in teardown method due to session timeouts: \n {e}',
+                    'Capture exceptions to avoid errors in teardown method due to session timeouts: \n %s',
+                    e,
                 )
 
     @classmethod
@@ -203,7 +204,7 @@ def download_videos(cls, name, test_passed=True, maintain_default=False):
                     )
             except Exception as exc:
                 # Capture exceptions to avoid errors in teardown method due to session timeouts
-                driver_wrapper.logger.warning(f'Error downloading videos: {exc}')
+                driver_wrapper.logger.warning('Error downloading videos: %s', exc)
             driver_index += 1
 
     @classmethod
@@ -254,7 +255,7 @@ def save_all_webdriver_or_ggr_logs(cls, test_name, test_passed, ggr=False):
                         driver_wrapper.utils.save_webdriver_logs(log_file_name)
                 except Exception as exc:
                     # Capture exceptions to avoid errors in teardown method due to session timeouts
-                    driver_wrapper.logger.warning(f'Error downloading webdriver logs: {exc}')
+                    driver_wrapper.logger.warning('Error downloading webdriver logs: %s', exc)
             driver_index += 1
 
     @staticmethod
diff --git a/toolium/selenoid.py b/toolium/selenoid.py
@@ -83,7 +83,7 @@ def __download_file(self, url, path_file, timeout):
         """
         status_code = 0
         init_time = time.time()
-        self.driver_wrapper.logger.info(f'Downloading file from Selenoid node: {url}')
+        self.driver_wrapper.logger.info('Downloading file from Selenoid node: %s', url)
         # retries policy
         while status_code != STATUS_OK and time.time() - init_time < float(timeout):
             body = requests.get(url)
@@ -100,13 +100,15 @@ def __download_file(self, url, path_file, timeout):
                 fp.write(body.content)
                 fp.close()
                 self.driver_wrapper.logger.info(
-                    f'File has been downloaded successfully to "{path_file}" and took {took} seconds',
+                    'File has been downloaded successfully to "%s" and took %f seconds',
+                    path_file,
+                    took,
                 )
                 return True
             except OSError as e:
-                self.driver_wrapper.logger.warning(f'Error writing downloaded file in "{path_file}":\n {e}')
+                self.driver_wrapper.logger.warning('Error writing downloaded file in "%s":\n %s', path_file, e)
         else:
-            self.driver_wrapper.logger.warning(f'File "{url}" does not exist in the server after {timeout} seconds')
+            self.driver_wrapper.logger.warning('File "%s" does not exist in the server after %s seconds', url, timeout)
         return False
 
     def __remove_file(self, url):
@@ -126,7 +128,7 @@ def get_selenoid_info(self):
             selenoid_info = requests.get(host_url).json()
         except Exception:
             return None
-        self.driver_wrapper.logger.info(f'Selenoid host info: {selenoid_info}')
+        self.driver_wrapper.logger.info('Selenoid host info: %s', selenoid_info)
         return selenoid_info
 
     def is_the_session_still_active(self):
@@ -202,7 +204,9 @@ def is_the_session_still_active(self):
             response = requests.get(host_url).json()['browsers'][self.browser]
         except Exception as e:
             self.driver_wrapper.logger.warning(
-                f'the GGR status request has failed: \nResponse:  {response.content} \nError message: {e}\n',
+                'the GGR status request has failed: \nResponse:  %s \nError message: %s\n',
+                response.content,
+                e,
             )
             return None
         for browser in response:
diff --git a/toolium/test/behave/test_environment.py b/toolium/test/behave/test_environment.py
@@ -56,7 +56,7 @@ def test_get_jira_key_from_scenario(tag_list, jira_key):
 
 
 @mock.patch('toolium.behave.environment.create_and_configure_wrapper')
-def test_before_all(create_and_configure_wrapper):
+def test_before_all(create_and_configure_wrapper):  # noqa: ARG001
     # Create context mock
     context = mock.MagicMock()
     context.config.userdata.get.return_value = None
@@ -72,7 +72,7 @@ def test_before_all(create_and_configure_wrapper):
 
 
 @mock.patch('toolium.behave.environment.create_and_configure_wrapper')
-def test_before_all_config_environment(create_and_configure_wrapper):
+def test_before_all_config_environment(create_and_configure_wrapper):  # noqa: ARG001
     # Create context mock
     context = mock.MagicMock()
     context.config.userdata.get.side_effect = lambda x: 'os' if x == 'TOOLIUM_CONFIG_ENVIRONMENT' else None
@@ -136,10 +136,9 @@ def test_before_feature_reuse_driver_no_driver(start_driver):
     assert context.reuse_driver_from_tags is True
 
 
-@mock.patch('toolium.behave.environment.add_assert_screenshot_methods')
 @mock.patch('toolium.behave.environment.DriverWrappersPool')
 @mock.patch('toolium.behave.environment.start_driver')
-def test_before_scenario(start_driver, DriverWrappersPool, add_assert_screenshot_methods):  # noqa: N803
+def test_before_scenario(start_driver, DriverWrappersPool):  # noqa: N803
     # Create context mock
     context = mock.MagicMock()
     context.toolium_config = ExtendedConfigParser()
@@ -153,10 +152,9 @@ def test_before_scenario(start_driver, DriverWrappersPool, add_assert_screenshot
     DriverWrappersPool.stop_drivers.assert_not_called()
 
 
-@mock.patch('toolium.behave.environment.add_assert_screenshot_methods')
 @mock.patch('toolium.behave.environment.DriverWrappersPool')
 @mock.patch('toolium.behave.environment.start_driver')
-def test_before_scenario_reset_driver(start_driver, DriverWrappersPool, add_assert_screenshot_methods):  # noqa: N803
+def test_before_scenario_reset_driver(start_driver, DriverWrappersPool):  # noqa: N803
     # Create context mock
     context = mock.MagicMock()
     context.toolium_config = ExtendedConfigParser()
@@ -170,9 +168,8 @@ def test_before_scenario_reset_driver(start_driver, DriverWrappersPool, add_asse
     DriverWrappersPool.stop_drivers.assert_called_once_with()
 
 
-@mock.patch('toolium.behave.environment.add_assert_screenshot_methods')
 @mock.patch('toolium.behave.environment.start_driver')
-def test_before_scenario_no_driver(start_driver, add_assert_screenshot_methods):
+def test_before_scenario_no_driver(start_driver):
     # Create context mock
     context = mock.MagicMock()
     context.toolium_config = ExtendedConfigParser()
@@ -185,9 +182,8 @@ def test_before_scenario_no_driver(start_driver, add_assert_screenshot_methods):
     start_driver.assert_called_once_with(context, True)
 
 
-@mock.patch('toolium.behave.environment.add_assert_screenshot_methods')
 @mock.patch('toolium.behave.environment.start_driver')
-def test_before_scenario_no_driver_feature(start_driver, add_assert_screenshot_methods):
+def test_before_scenario_no_driver_feature(start_driver):
     # Create context mock
     context = mock.MagicMock()
     context.toolium_config = ExtendedConfigParser()
diff --git a/toolium/test/pageelements/test_derived_page_element.py b/toolium/test/pageelements/test_derived_page_element.py
@@ -154,7 +154,7 @@ def test_set_input_text_shadowroot_quotation_marks(driver_wrapper):
     driver_wrapper.driver.execute_script.assert_called_once_with(expected_script)
 
 
-def test_get_selected_option(driver_wrapper):
+def test_get_selected_option():
     select_page_element.SeleniumSelect = get_mock_select()
 
     option = LoginPageObject().language.option
@@ -179,7 +179,7 @@ def test_click_button(driver_wrapper):
     mock_element.click.assert_called_once_with()
 
 
-def test_group_reset_object(driver_wrapper):
+def test_group_reset_object():
     login_page = LoginPageObject()
 
     # Check that web elements are empty
diff --git a/toolium/test/test_config_driver_appium.py b/toolium/test/test_config_driver_appium.py
@@ -50,7 +50,7 @@ def utils():
 
 @mock.patch('toolium.config_driver.appiumdriver')
 @pytest.mark.parametrize('driver_type', appium_driver_types)
-def test_create_local_driver_appium(appiumdriver_mock, driver_type, config, utils):
+def test_create_local_driver_appium(appiumdriver_mock, driver_type, config, utils):  # noqa: ARG001
     utils.get_driver_name.return_value = driver_type
     config.set('Driver', 'type', driver_type)
     config_driver = ConfigDriver(config, utils)
diff --git a/toolium/test/test_driver_wrappers_pool.py b/toolium/test/test_driver_wrappers_pool.py
@@ -100,7 +100,7 @@ def test_connect_default_driver_wrapper_already_connected(driver_wrapper):
 
 
 @pytest.mark.parametrize('scope', close_drivers_scopes)
-def test_close_drivers_function(scope, driver_wrapper):
+def test_close_drivers_function(scope):
     DriverWrappersPool.save_all_webdriver_logs = mock.MagicMock()
     VisualTest.update_latest_report = mock.MagicMock()
 
diff --git a/toolium/test/test_jira.py b/toolium/test/test_jira.py
@@ -169,7 +169,7 @@ def test_change_jira_status_exception(jira_post, logger):
     logger.warning.assert_called_once_with("Error updating Test Case '%s': %s", 'TOOLIUM-1', jira_post.side_effect)
 
 
-def test_jira_annotation_pass(logger):
+def test_jira_annotation_pass():
     # Configure jira module
     config = DriverWrappersPool.get_default_wrapper().config
     try:
@@ -186,7 +186,7 @@ def test_jira_annotation_pass(logger):
     assert expected_status == jira.jira_tests_status
 
 
-def test_jira_annotation_fail(logger):
+def test_jira_annotation_fail():
     # Configure jira module
     config = DriverWrappersPool.get_default_wrapper().config
     try:
@@ -204,7 +204,7 @@ def test_jira_annotation_fail(logger):
     assert expected_status == jira.jira_tests_status
 
 
-def test_jira_annotation_multiple(logger):
+def test_jira_annotation_multiple():
     # Configure jira module
     config = DriverWrappersPool.get_default_wrapper().config
     try:
@@ -228,7 +228,7 @@ def test_jira_annotation_multiple(logger):
     assert expected_status == jira.jira_tests_status
 
 
-def test_jira_disabled(logger):
+def test_jira_disabled():
     # Configure jira module
     config = DriverWrappersPool.get_default_wrapper().config
     try:
diff --git a/toolium/utils/ai_utils/accuracy.py b/toolium/utils/ai_utils/accuracy.py
@@ -107,7 +107,7 @@ def scenario_run_with_accuracy(context, scenario_run, scenario, *args, **kwargs)
         # transformation, like map_param and replace_param methods
         orig_steps = deepcopy(scenario.steps)
         for execution in range(executions):
-            context.logger.info(f'Running accuracy scenario execution ({execution + 1}/{executions})')
+            context.logger.info('Running accuracy scenario execution (%d/%d)', execution + 1, executions)
             # Store execution data in context
             store_execution_data(context, execution, data_key_suffix)
             # Restore original steps before each execution
@@ -132,8 +132,8 @@ def scenario_run_with_accuracy(context, scenario_run, scenario, *args, **kwargs)
                     'message': get_error_message_from_scenario(scenario),
                 },
             )
-            print(f'ACCURACY SCENARIO {status}: execution {execution + 1}/{executions}')
-            context.logger.info(f'Accuracy scenario execution {status} ({execution + 1}/{executions})')
+            print(f'ACCURACY SCENARIO {status}: execution {execution + 1}/{executions}')  # noqa: T201
+            context.logger.info('Accuracy scenario execution %s (%d/%d)', status, execution + 1, executions)
 
         # Save results to CSV file
         save_accuracy_results_to_csv(context, scenario, results)
@@ -147,7 +147,7 @@ def scenario_run_with_accuracy(context, scenario_run, scenario, *args, **kwargs)
             has_passed = scenario_accuracy >= accuracy
             run_response = not has_passed  # Run method returns true only when failed
             final_status = 'PASSED' if has_passed else 'FAILED'
-            print(
+            print(  # noqa: T201
                 f'\nACCURACY SCENARIO {final_status}: {executions} executions,'
                 f' accuracy {scenario_accuracy} >= {accuracy}',
             )
@@ -214,7 +214,7 @@ def patch_feature_scenarios_with_accuracy(context, feature):
                 patch_scenario_from_tags(context, scenario)
     except Exception as e:
         # Log error but do not fail the execution to avoid errors in before feature method
-        context.logger.error(f'Error applying accuracy policy: {e}')
+        context.logger.error('Error applying accuracy policy: %s', e)
 
 
 def get_accuracy_data(context, data_key_suffix):
@@ -245,7 +245,9 @@ def store_execution_data(context, execution, data_key_suffix):
     context.storage['accuracy_execution_data'] = execution_data
     context.storage['accuracy_execution_index'] = execution
     context.logger.info(
-        f'Stored accuracy data for execution {execution + 1} in accuracy_execution_data: {execution_data}',
+        'Stored accuracy data for execution %d in accuracy_execution_data: %s',
+        execution + 1,
+        execution_data,
     )
 
 
@@ -300,6 +302,6 @@ def save_accuracy_results_to_csv(context, scenario, results):
             csv_writer.writerow(['Execution data', 'Status', 'Message'])
             for result in results:
                 csv_writer.writerow([result['data'], result['status'], result['message']])
-        context.logger.info(f'Accuracy results saved to: {csv_filename}')
+        context.logger.info('Accuracy results saved to: %s', csv_filename)
     except Exception as e:
-        context.logger.error(f'Error saving accuracy results to CSV: {e}')
+        context.logger.error('Error saving accuracy results to CSV: %s', e)
diff --git a/toolium/utils/ai_utils/openai.py b/toolium/utils/ai_utils/openai.py
@@ -45,7 +45,7 @@ def openai_request(system_message, user_message, model_name=None, azure=False, *
         raise ImportError("OpenAI is not installed. Please run 'pip install toolium[ai]' to use OpenAI features")
     config = DriverWrappersPool.get_default_wrapper().config
     model_name = model_name or config.get_optional('AI', 'openai_model', 'gpt-4o-mini')
-    logger.info(f'Calling to OpenAI API with model {model_name}')
+    logger.info('Calling to OpenAI API with model %s', model_name)
     client = AzureOpenAI(**kwargs) if azure else OpenAI(**kwargs)
     msg = []
     if isinstance(system_message, list):
@@ -59,5 +59,5 @@ def openai_request(system_message, user_message, model_name=None, azure=False, *
         messages=msg,
     )
     response = completion.choices[0].message.content
-    logger.debug(f'OpenAI response: {response}')
+    logger.debug('OpenAI response: %s', response)
     return response
diff --git a/toolium/utils/ai_utils/text_analysis.py b/toolium/utils/ai_utils/text_analysis.py
@@ -110,7 +110,9 @@ def assert_text_criteria(text_input, text_criteria, threshold, model_name=None,
         logger.error(error)
         raise AssertionError(error)
     logger.info(
-        f'Text criteria analysis passed: overall match {overall_match} '
-        f'is above threshold {threshold}.'
-        f'Low scored features: {analysis.get("features", [])}',
+        'Text criteria analysis passed: overall match {overall_match} is above threshold {threshold}.'
+        'Low scored features: {features}',
+        overall_match=overall_match,
+        threshold=threshold,
+        features=analysis.get('features', []),
     )
diff --git a/toolium/utils/ai_utils/text_readability.py b/toolium/utils/ai_utils/text_readability.py
@@ -66,7 +66,7 @@ def get_text_readability_with_spacy(text, technical_chars=None, model_name=None,
 
     readability = (total_tokens - non_linguistic_tokens_count) / total_tokens
 
-    logger.info(f'spaCy readability: {readability}')
+    logger.info('spaCy readability: %s', readability)
     return readability
 
 
@@ -99,5 +99,5 @@ def assert_text_readability(text, threshold, technical_chars=None, readability_m
         logger.error(error_message)
         raise AssertionError(error_message)
 
-    logger.info(f'Text readability is above threshold: {readability} >= {threshold}\n{texts_message}')
+    logger.info('Text readability is above threshold: %s >= %s\n%s', readability, threshold, texts_message)
     return
diff --git a/toolium/utils/ai_utils/text_similarity.py b/toolium/utils/ai_utils/text_similarity.py
diff --git a/toolium/utils/dataset.py b/toolium/utils/dataset.py
diff --git a/toolium/utils/download_files.py b/toolium/utils/download_files.py
diff --git a/toolium/utils/driver_utils.py b/toolium/utils/driver_utils.py
diff --git a/toolium/utils/driver_wait_utils.py b/toolium/utils/driver_wait_utils.py
diff --git a/toolium/utils/poeditor.py b/toolium/utils/poeditor.py
diff --git a/toolium/visual_test.py b/toolium/visual_test.py
