Skip to content

Commit 9d02811

Browse files
committed
Add output flag option to docker run script
1 parent 9d43964 commit 9d02811

File tree

2 files changed

+20
-3
lines changed

2 files changed

+20
-3
lines changed

README.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,16 +56,19 @@ It takes in the following parameters:
5656
- `MODULE_PATH` env var (required) - path to your module, e.g. `github.com/teamwork/amazingapp`
5757
- `EXEC_PATH` env var (optional) - path passed to kommentaar - can be relative or absolute, e.g. `./api/v3/...`, or `/go/src/github.com/teamwork/amazingapp/api/v3/...`. Default value is `/go/src/$MODULE_PATH/...`
5858
- `CONFIG_NAME` env var (optional) - name of kommentaar config file in the `/config` volume (see below). Default value is `kommentaar.conf`
59+
- `OUTPUT` env var (optional) - the output format. Default value is `openapi2-yaml`
5960
- `/code` volume (required) - folder containing your go code
6061
- `/config` volume (optional) - folder containing your kommentaar config file, by default the included `config.example` file is copied there as `kommentaar.conf`
61-
- `/output` volume (required) - folder where the generated `swagger.yaml` file will be placed.
62+
- `/output` volume (required) - folder where the generated swagger file will be placed.
6263

6364
Usage examples:
6465
- `docker run --rm -it -e MODULE_PATH="github.com/teamwork/amazingapp" -v .:/code -v .:/config -v .:/output ghcr.io/teamwork/kommentaar`
6566
- This assumes you are running the command in `amazingapp` folder
6667
- This is roughly equivalent to `kommentaar -config ./kommentaar.conf github.com/teamwork/amazingapp... > ./swagger.yaml`
6768
- `docker run --rm -it -e MODULE_PATH="github.com/teamwork/amazingapp" -e EXEC_PATH="./api/v3/controller/..." -e CONFIG_NAME=".kommentaar.v3" -v $HOME/dev/amazingapp:/code -v $HOME/dev/amazingapp/config:/config -v %HOME/dev/amazingapp/api/v3:/output ghcr.io/teamwork/kommentaar`
68-
- This will run the equivalent of `kommentaar -config $HOME/dev/amazingapp/config/.kommentaar.v3 $GOPATH/src/github.com/teamwork/amazingapp/api/v3/controller/... > $HOME/dev/amazingapp/api/v3/swagger.yaml`
69+
- This will run the equivalent of `kommentaar -config $HOME/dev/amazingapp/config/.kommentaar.v3 -output openapi2-yaml $GOPATH/src/github.com/teamwork/amazingapp/api/v3/controller/... > $HOME/dev/amazingapp/api/v3/swagger.yaml`
70+
- `docker run --rm -it -e MODULE_PATH="github.com/teamwork/amazingapp" -e EXEC_PATH="./api/v3/controller/..." -e CONFIG_NAME=".kommentaar.v3" -e OUTPUT="html" -v $HOME/dev/amazingapp:/code -v $HOME/dev/amazingapp/config:/config -v %HOME/dev/amazingapp/api/v3:/output ghcr.io/teamwork/kommentaar`
71+
- This will run the equivalent of `kommentaar -config $HOME/dev/amazingapp/config/.kommentaar.v3 -output html $GOPATH/src/github.com/teamwork/amazingapp/api/v3/controller/... > $HOME/dev/amazingapp/api/v3/swagger.html`
6972

7073

7174
Syntax

run.sh

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,20 @@ if [ -n "$CONFIG_NAME" ]; then
1515
fi
1616
echo "Config will be loaded from $config"
1717

18+
output_ext="yaml"
19+
output="openapi2-yaml"
20+
if [ -n "$OUTPUT" ]; then
21+
if [ "$OUTPUT" = "openapi2-json" ] || [ "$OUTPUT" = "openapi2-jsonindent" ]; then
22+
output_ext="json"
23+
output="$OUTPUT"
24+
fi
25+
26+
if [ "$OUTPUT" = "html" ]; then
27+
output_ext="html"
28+
output="$OUTPUT"
29+
fi
30+
fi
31+
1832
exec_path=/go/src/$MODULE_PATH/...
1933
if [ -n "$EXEC_PATH" ]; then
2034
exec_path=$EXEC_PATH
@@ -26,4 +40,4 @@ export GO111MODULE=off
2640
go install /go/src/github.com/teamwork/kommentaar
2741

2842
cd /go/src/$MODULE_PATH
29-
/go/bin/kommentaar -config $config $exec_path > /output/swagger.yaml
43+
/go/bin/kommentaar -config $config -output $output $exec_path > /output/swagger.$output_ext

0 commit comments

Comments
 (0)