Tomcat 11 / Jakarta EE 11 Support

[dm-ion]

Has anyone had any success running Stripes on Tomcat 11 yet?

It seems for our use cases it doesn't work out of the box. We are running into problems with responses being truncated, especially when layouts are being used.

It appears as though many responses are truncated out of the box. I attempted to flush more often, changing buffer configurations, etc. but it appears that only moves that problem rather then fixing them.

Figured I would ask the community before we spend more time here.

[rgrashel]

@dm-ion If you are using the Stripes 1.6 Jakarta release, you might be running into the problem called out in this post:

#107 (reply in thread)

I don't know if you are using layout templates or not. Unfortunately, I can't release a patch for this quickly. It isn't fantastic, but what you can do is create a copy of net.sourceforge.stripes.controller.StripesConstants in your source code. Change those two constants: REQ_ATTR_INCLUDE_PATH and REQ_ATTR_INCLUDE_PATH_INFO to use jakarta instead of javax. Do the same for the reference in DefaultMultipartWrapperFactory.

See if that works. Thanks.

-- Rick

[dm-ion]

Wow thanks for the quick response!

Unfortunately this is not it, we did make those changes a little over a year ago and we've been running that build in production (successfully) with Tomcat 10.1.x / Jakarta EE 10 with no issues.

The only change here was upgrading to Tomcat 11. When this didn't work we tried a few other shots in the dark, as well as turning up the logging and trying to see what was going on over the course of a day or so to see if we could get it working. eg: Removing / updating EL code in Stripes that has been removed from the latest EL versions and changing some flushing behaviour / tomcat configurations but didn't really get anywhere.

Happy to spend some more time to investigate, but wasn't sure where to start or if others had run into similar issues already.

[bengunter]

This probably goes back to streaming layouts. They were always problematic. They worked in many containers (e.g., Tomcat) but not in others (e.g. JBoss IIRC). At some point I added the old buffered layouts back into the project. They should be 100% compatible. All you have to do is change the URL in the import or whatever. (Forgive me, it has been years since I've worked on web stuff.) The difference is your page will be built on the heap before it is sent to the client. That may or may not matter, depending on how large the page is.

[dm-ion]

That sounds interesting I'll give the buffered layouts a try, looks like a simple test. You indeed added them back in 2012 with a separate tld / uri but noted some potential incompatibilities.

fd28025

[dm-ion]

First we tried the buffered layouts, and confirmed everything coming out of stripes looked good. Then we looked at some filters downstream of stripes, and also saw they were getting all of the contents. So it seemed like Tomcat was doing the truncating.

Tried to mess around with various tomcat settings and didn't get anywhere so implemented a valve to try and debug and it ended up fixing the issue. Tried with streaming layouts and this valve, and it also worked. Not clear to me why this would be the case.

Tomcat11StripesValve.java This file has one dependency which is org.apache.tomcat:tomcat-catalina

[bengunter]

This is a nice illustration of how tricky it got and why I just ended up putting the original buffered implementation back into the project as a fallback option.