chore(deps): Update dependency com.puppycrawl.tools:checkstyle to v10.23.0 (#569)

* chore(deps): Update dependency com.puppycrawl.tools:checkstyle to v10.23.0

* resolve new violations

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: zml <[email protected]>

Author: renovate[bot]

.checkstyle/checkstyle.xml

@@ -85,7 +85,7 @@
 
     <module name="TreeWalker">
         <module name="JavadocVariable">
-            <property name="scope" value="public"/>
+            <property name="accessModifiers" value="public"/>
         </module>
         <module name="MissingJavadocType">
             <property name="scope" value="public"/>

core/src/main/java/org/spongepowered/configurate/objectmapping/ObjectMapperFactoryImpl.java

@@ -222,7 +222,7 @@ private <I, O> void makeData(final List<FieldData<I, O>> fields, final String na
 
     // TypeSerializer //
 
-    public static final String CLASS_KEY = "__class__";
+    static final String CLASS_KEY = "__class__";
 
     @Override
     public Object deserialize(final Type type, final ConfigurationNode node) throws SerializationException {

core/src/main/java/org/spongepowered/configurate/util/MapFactories.java

@@ -77,18 +77,34 @@ public static MapFactory insertionOrdered() {
     }
 
     private enum DefaultFactory implements MapFactory {
+        /**
+         * A factory creating maps with no order contract.
+         *
+         * @since 4.0.0
+         */
         UNORDERED {
             @Override
             public <K, V> ConcurrentMap<K, V> create() {
                 return new ConcurrentHashMap<>();
             }
         },
+        /**
+         * A factory creating maps which sort comparable elements by
+         * natural order.
+         *
+         * @since 4.0.0
+         */
         SORTED_NATURAL {
             @Override
             public <K, V> ConcurrentMap<K, V> create() {
                 return new ConcurrentSkipListMap<>();
             }
         },
+        /**
+         * A factory creating maps that preserve insertion order.
+         *
+         * @since 4.0.0
+         */
         INSERTION_ORDERED {
             @Override
             public <K, V> Map<K, V> create() {

examples/src/main/java/org/spongepowered/configurate/examples/Tutorial.java

@@ -85,6 +85,7 @@ public static void main(final String[] args) throws SerializationException {
     /**
      * A mood that a message may have.
      */
+    @SuppressWarnings("checkstyle:JavadocVariable")
     enum Mood {
 
         HAPPY, SAD, CONFUSED, NEUTRAL;

format/xml/src/main/java/org/spongepowered/configurate/xml/XmlConfigurationLoader.java

@@ -476,6 +476,7 @@ protected void loadInternal(final AttributedConfigurationNode node, final Buffer
         throw new UnsupportedOperationException("XMLConfigurationLoader provides custom loading logic to handle headers");
     }
 
+    @SuppressWarnings("checkstyle:JavadocVariable") // false positive, private enum
     private enum NodeType {
         MAP, LIST
     }

gradle/libs.versions.toml

@@ -2,7 +2,7 @@
 assertj="3.27.3"
 autoValue="1.11.0"
 checkerQual="3.49.2"
-checkstyle="10.21.4"
+checkstyle="10.23.0"
 geantyref = "1.3.16"
 errorprone="2.38.0"
 indra = "3.1.3"