Skip to content

Commit 24307b4

Browse files
Fix: trace details bugfixes (#9116)
* fix: make the trace details sidebar scrollable * fix: fix the long value overflowing trace details attributes * fix: fix the layout issues in trace details v2 * Revert "fix: make the trace details sidebar scrollable" This reverts commit 469022e. * fix: make the trace details sidebar scrollable * fix: make the attribute value take 100% width --------- Co-authored-by: Nityananda Gohain <[email protected]>
1 parent 0626a89 commit 24307b4

File tree

4 files changed

+18
-8
lines changed

4 files changed

+18
-8
lines changed

frontend/src/container/SpanDetailsDrawer/Attributes/Attributes.styles.scss

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,12 +58,16 @@
5858
padding: 2px 8px;
5959
align-items: center;
6060
width: fit-content;
61-
max-width: calc(100% - 120px); /* Reserve space for action buttons */
61+
max-width: 100%;
6262
gap: 8px;
6363
border-radius: 50px;
6464
border: 1px solid var(--bg-slate-400);
6565
background: var(--bg-slate-500);
6666

67+
.copy-wrapper {
68+
overflow: hidden;
69+
}
70+
6771
.item-value {
6872
color: var(--bg-vanilla-400);
6973
font-family: Inter;

frontend/src/container/SpanDetailsDrawer/Attributes/Attributes.tsx

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -97,11 +97,13 @@ function Attributes(props: IAttributesProps): JSX.Element {
9797
</div>
9898
<div className="value-wrapper">
9999
<Tooltip title={item.value}>
100-
<CopyClipboardHOC entityKey={item.value} textToCopy={item.value}>
101-
<Typography.Text className="item-value" ellipsis>
102-
{item.value}
103-
</Typography.Text>{' '}
104-
</CopyClipboardHOC>
100+
<div className="copy-wrapper">
101+
<CopyClipboardHOC entityKey={item.value} textToCopy={item.value}>
102+
<Typography.Text className="item-value" ellipsis>
103+
{item.value}
104+
</Typography.Text>
105+
</CopyClipboardHOC>
106+
</div>
105107
</Tooltip>
106108
<AttributeActions
107109
record={item}

frontend/src/container/SpanDetailsDrawer/SpanDetailsDrawer.styles.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
flex-direction: column;
44
height: calc(100vh - 44px); //44px -> trace details top bar
55
border-left: 1px solid var(--bg-slate-400);
6-
overflow-y: auto;
6+
overflow-y: auto !important;
77
&:not(&-docked) {
88
min-width: 450px;
99
}

frontend/src/pages/TraceDetailV2/TraceDetailV2.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,11 @@ function TraceDetailsV2(): JSX.Element {
127127
];
128128

129129
return (
130-
<ResizablePanelGroup direction="horizontal" autoSaveId="trace-drawer">
130+
<ResizablePanelGroup
131+
direction="horizontal"
132+
autoSaveId="trace-drawer"
133+
className="trace-layout"
134+
>
131135
<ResizablePanel minSize={20} maxSize={80} className="trace-left-content">
132136
<TraceMetadata
133137
traceID={traceId}

0 commit comments

Comments
 (0)