Skip to content
This repository was archived by the owner on Dec 9, 2024. It is now read-only.
This repository was archived by the owner on Dec 9, 2024. It is now read-only.

SDL_INF value could be updated #329

@ariostas

Description

@ariostas

Currently SDL_INF is used to deal with cases where there are infinities. It is defined as follows.

TrackLooper/SDL/Constants.h

Lines 152 to 153 in f1b2031

// Since C++ can't represent infinity, SDL_INF = 123456789 was used to represent infinity in the data table
ALPAKA_STATIC_ACC_MEM_GLOBAL const float SDL_INF = 123456789;

I think it would be a little more elegant to define it like this

#include <limits>
ALPAKA_STATIC_ACC_MEM_GLOBAL const float SDL_INF = std::numeric_limits<float>::infinity();

But the tricky part is that data files have the other value hardcoded, and those files were probably generated by some other code with the same value hardcoded, so it's probably not worth it fixing it here. If someone knows if that's the case they should label this issue as wontfix.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions