test: fix initializations for several tests

Author: AayushSabharwal

test/Blocks/continuous.jl

@@ -162,6 +162,7 @@ end
         t,
         systems = [pi_controller, plant, ref, fb])
     sys = mtkcompile(model)
+    initial_conditions(sys)[sys.pi_controller.gainPI.k] = 1.0
     prob = ODEProblem(sys, Pair[], (0.0, 100.0))
     sol = solve(prob, Rodas4())
     @test sol.retcode == Success
@@ -238,7 +239,7 @@ end
         u_max = 1.5,
         u_min = -1.5,
         Ta = 0.1)
-    @named pi_controller = PI(gainPI.k = 3, T = 0.5)
+    @named pi_controller = PI(T = 0.5)
     @named sat = Limiter(y_max = 1.5, y_min = -1.5)
     @named plant = Plant()
     @named fb = Feedback()
@@ -256,6 +257,7 @@ end
             t,
             systems = [pi_controller, plant, ref, fb, sat])
         sys = mtkcompile(model)
+        initial_conditions(sys)[sys.pi_controller.gainPI.k] = 1.0
         prob = ODEProblem(sys, Pair[], (0.0, 20.0))
         sol = solve(prob, Rodas4())
     end

test/Blocks/utils.jl

@@ -23,7 +23,7 @@ end
         (RealOutput(; nout = 3, name = :a), zeros(3))
     ]
         guesses = ModelingToolkit.guesses(block)
-        @test Symbolics.value(guesses[@nonamespace block.u[1]]) == guess[1]
+        @test Symbolics.value(guesses[@nonamespace block.u][1]) == guess[1]
     end
 end
 
@@ -36,7 +36,7 @@ end
 
     initsys = ModelingToolkit.generate_initializesystem(sys)
     initsys = mtkcompile(initsys)
-    initprob = NonlinearProblem(initsys, [t => 0])
+    initprob = NonlinearProblem(initsys, merge(initial_conditions(sys), Dict([t => 0])))
     initsol = solve(initprob)
 
     @test initsol[sys.so.xd] == 1.0

test/Electrical/analog.jl

@@ -740,7 +740,7 @@ end
 
     @mtkcompile sys = SimpleNPNCircuit(V_cc = 3.0, V_b = 0.70)
 
-    prob = ODEProblem(sys, Pair[], (0.0, 10.0); guesses = [sys.Q1.I_sub => 1.0, sys.Vcc_sine.output.u => 1.0])
+    prob = ODEProblem(sys, Pair[], (0.0, 10.0); guesses = [sys.Q1.I_sub => 1.0])
     sol = solve(prob)
 
     # make sure KCL is true
@@ -780,7 +780,7 @@ end
 
     @mtkcompile sys = SimpleNPNCircuitSubstrate(V_b = 0.70)
 
-    prob = ODEProblem(sys, [sys.Q1.c.i => 0.0], (0.0, 10.0))
+    prob = ODEProblem(sys, [sys.Q1.c.i => 0.0], (0.0, 10.0); guesses = [sys.Q1.I_sub => 1.0, sys.Vcc_sine.output.u => 1.0])
     sol = solve(prob)
 
     @test isapprox(

test/Hydraulic/isothermal_compressible.jl

@@ -299,7 +299,7 @@ end
     defs[sys.input.buffer] = Parameter(0.5 * x, dt)
 
     # NOTE: bypassing initialization system: https://github.com/SciML/ModelingToolkit.jl/issues/3312
-    prob = ODEProblem(sys, initsol[1], (0, 0.1); build_initializeprob = false)
+    prob = ODEProblem(sys, [unknowns(initsys)[1] => initsol[1]], (0, 0.1); build_initializeprob = false)
 
     #TODO: Implement proper initialization system after issue is resolved
     #TODO: How to bring the body back and not have an overdetermined system?

test/Thermal/demo.jl

@@ -21,7 +21,7 @@ using OrdinaryDiffEq: ReturnCode.Success
     @named model = System(connections, t,
         systems = [mass1, mass2, conduction, Tsensor1, Tsensor2])
     sys = mtkcompile(model)
-    prob = ODEProblem(sys, [], (0, 3.0))
+    prob = ODEProblem(sys, [conduction.Q_flow => nothing, conduction.dT => nothing], (0, 3.0))
     sol = solve(prob, Tsit5())
     @test SciMLBase.successful_retcode(sol)
 end

test/Thermal/piston.jl

@@ -34,7 +34,7 @@ using ModelingToolkitStandardLibrary.Blocks
 
     @mtkcompile piston = Piston()
 
-    prob = ODEProblem(piston, [], (0, 3.0))
+    prob = ODEProblem(piston, [piston.gas.dT => nothing, piston.coolant.dT => nothing, piston.wall.Q_flow => nothing, piston.wall.dT => nothing, piston.gas.Q_flow => nothing, piston.coolant.Q_flow => nothing], (0, 3.0))
     sol = solve(prob)
 
     # Heat-flow-rate is equal in magnitude

test/Thermal/thermal.jl

@@ -42,9 +42,7 @@ using OrdinaryDiffEq: ReturnCode.Success
         systems = [mass1, mass2, T_sensor1, T_sensor2, th_conductor])
     sys = mtkcompile(h2)
 
-    u0 = [mass1.T => 1.0
-          mass2.T => 10.0]
-    prob = ODEProblem(sys, u0, (0, 3.0))
+    prob = ODEProblem(sys, [], (0, 3.0))
     sol = solve(prob, Tsit5())
 
     @test SciMLBase.successful_retcode(sol)
@@ -76,7 +74,7 @@ end
             th_resistor, flow_src, th_ground, th_conductor])
     sys = mtkcompile(h2)
 
-    u0 = [mass1.T => 10.0]
+    u0 = [mass1.T => 10.0, th_conductor.dT => nothing, th_conductor.Q_flow => nothing, th_resistor.Q_flow => nothing, th_resistor.dT => nothing]
     prob = ODEProblem(sys, u0, (0, 3.0))
     sol = solve(prob, Tsit5())
 
@@ -144,7 +142,7 @@ end
             collector, th_resistor, mass])
     sys = mtkcompile(coll)
 
-    prob = ODEProblem(sys, [], (0, 3.0))
+    prob = ODEProblem(sys, [mass.T => nothing, th_resistor.Q_flow => nothing, th_resistor.dT => nothing], (0, 3.0))
     sol = solve(prob, Rodas4())
 
     @test SciMLBase.successful_retcode(sol)
@@ -169,8 +167,8 @@ end
     end
 
     @info "Building a FixedHeatFlow with alpha=0.0"
-    @mtkcompile test_model = TestModel()
-    prob = ODEProblem(test_model, Pair[], (0, 10.0))
+    @mtkcompile test_model = TestModel() allow_parameter = false
+    prob = ODEProblem(test_model, [test_model.wall.Q_flow => nothing, test_model.wall.dT => nothing], (0, 10.0); guesses = [test_model.heatflow.port.T => 1.0])
     sol = solve(prob)
 
     heat_flow = sol[test_model.heatflow.port.Q_flow]