incomplete type 'EVP_CIPHER_CTX' with OpenSSL 1.1.0

[rjdgtn]

Looks like master is not compatible with ssl 1.1.0

LikeNet/Source/src/crypto/cryptomanager.cpp:177:35: error: variable has incomplete type 'EVP_CIPHER_CTX' (aka 'evp_cipher_ctx_st')
EVP_CIPHER_CTX CCryptoManager::m_decryptionContext;

[StidOfficial]

Fix it by :

diff --git a/Source/include/slikenet/crypto/cryptomanager.h b/Source/include/slikenet/crypto/cryptomanager.h
index f9b8dd3a..6966f1e3 100644
--- a/Source/include/slikenet/crypto/cryptomanager.h
+++ b/Source/include/slikenet/crypto/cryptomanager.h
@@ -20,8 +20,8 @@ namespace SLNet
                                // class members
                                // note: using distinct contexts for encryption/decryption to prevent potential for race conditions
                                // #med - consider moving to SessionEncrypter class
-                               static EVP_CIPHER_CTX m_decryptionContext;
-                               static EVP_CIPHER_CTX m_encryptionContext;
+                               static EVP_CIPHER_CTX *m_decryptionContext;
+                               static EVP_CIPHER_CTX *m_encryptionContext;
                                static unsigned char m_initializationVector[EVP_MAX_IV_LENGTH];
                                static unsigned char m_sessionKey[EVP_MAX_KEY_LENGTH];
                                static bool m_Initialized;
@@ -45,4 +45,4 @@ namespace SLNet
                        };
                }
        }
-}
\ No newline at end of file
+}
diff --git a/Source/src/crypto/cryptomanager.cpp b/Source/src/crypto/cryptomanager.cpp
index 2864f745..d06a316c 100644
--- a/Source/src/crypto/cryptomanager.cpp
+++ b/Source/src/crypto/cryptomanager.cpp
@@ -69,18 +69,18 @@ namespace SLNet
 
                                // #high - review usage of the CBC mode here --- not the best nowadays
                                // #med - add engine support to use HW-acceleration
-                               if (EVP_EncryptInit_ex(&m_encryptionContext, EVP_aes_256_cbc(), nullptr, m_sessionKey, m_initializationVector) == 0) {
+                               if (EVP_EncryptInit_ex(m_encryptionContext, EVP_aes_256_cbc(), nullptr, m_sessionKey, m_initializationVector) == 0) {
                                        return false; // failed to initialize the encryption context
                                }
 
                                int bytesWritten1;
                                // note: static_cast<> safe here, since GetRequiredEncrpytionBufferSize()-check ensured dataLength is <= int::max()
-                               if (EVP_EncryptUpdate(&m_encryptionContext, outBuffer, &bytesWritten1, plaintext, static_cast<int>(dataLength)) == 0) {
+                               if (EVP_EncryptUpdate(m_encryptionContext, outBuffer, &bytesWritten1, plaintext, static_cast<int>(dataLength)) == 0) {
                                        return false; // encryption failed
                                }
                                RakAssert(static_cast<size_t>(bytesWritten1) <= inOutBufferSize);
                                int bytesWritten2;
-                               if (EVP_EncryptFinal_ex(&m_encryptionContext, outBuffer + bytesWritten1, &bytesWritten2) == 0) {
+                               if (EVP_EncryptFinal_ex(m_encryptionContext, outBuffer + bytesWritten1, &bytesWritten2) == 0) {
                                        return false; // failed final encryption step
                                }
                                RakAssert(static_cast<size_t>(bytesWritten1) + static_cast<size_t>(bytesWritten2) <= inOutBufferSize);
@@ -112,18 +112,18 @@ namespace SLNet
 
                                // #high - review usage of the CBC mode here --- not the best nowadays
                                // #med - add engine support to use HW-acceleration
-                               if (EVP_DecryptInit_ex(&m_decryptionContext, EVP_aes_256_cbc(), nullptr, m_sessionKey, m_initializationVector) == 0) {
+                               if (EVP_DecryptInit_ex(m_decryptionContext, EVP_aes_256_cbc(), nullptr, m_sessionKey, m_initializationVector) == 0) {
                                        return false; // failed to initialize the decryption context
                                }
 
                                int bytesWritten1;
                                // static cast safe due to size-check above
-                               if (EVP_DecryptUpdate(&m_decryptionContext, outBuffer, &bytesWritten1, encryptedtext, static_cast<int>(dataLength)) == 0) {
+                               if (EVP_DecryptUpdate(m_decryptionContext, outBuffer, &bytesWritten1, encryptedtext, static_cast<int>(dataLength)) == 0) {
                                        return false; // decryption failed
                                }
                                RakAssert(static_cast<size_t>(bytesWritten1) <= inOutBufferSize);
                                int bytesWritten2;
-                               if (EVP_DecryptFinal_ex(&m_decryptionContext, outBuffer + bytesWritten1, &bytesWritten2) == 0) {
+                               if (EVP_DecryptFinal_ex(m_decryptionContext, outBuffer + bytesWritten1, &bytesWritten2) == 0) {
                                        return false; // failed final decryption step
                                }
                                RakAssert(static_cast<size_t>(bytesWritten1) + static_cast<size_t>(bytesWritten2) <= inOutBufferSize);
@@ -174,11 +174,11 @@ namespace SLNet
                        }
 
                        // initialization list
-                       EVP_CIPHER_CTX CCryptoManager::m_decryptionContext;
-                       EVP_CIPHER_CTX CCryptoManager::m_encryptionContext;
+                       EVP_CIPHER_CTX *CCryptoManager::m_decryptionContext;
+                       EVP_CIPHER_CTX *CCryptoManager::m_encryptionContext;
                        unsigned char CCryptoManager::m_sessionKey[EVP_MAX_KEY_LENGTH];
                        unsigned char CCryptoManager::m_initializationVector[EVP_MAX_IV_LENGTH];
                        bool CCryptoManager::m_Initialized = false;
                }
        }
-}
\ No newline at end of file
+}
diff --git a/Source/src/crypto/fileencrypter.cpp b/Source/src/crypto/fileencrypter.cpp
index 10217791..ad70d603 100644
--- a/Source/src/crypto/fileencrypter.cpp
+++ b/Source/src/crypto/fileencrypter.cpp
@@ -107,7 +107,7 @@ namespace SLNet
 
                                // #med - review the return value here - it's not documented in the manual
                                // note: cleanup() must be called so to not leak resources generated during the EVP_SignalFinal()-call
-                               (void)EVP_MD_CTX_cleanup(rsaSigningContext);
+                               (void)EVP_MD_CTX_free(rsaSigningContext);
                                EVP_MD_CTX_destroy(rsaSigningContext);
 
                                return success ? m_sigBuffer : nullptr;
@@ -158,7 +158,7 @@ namespace SLNet
                                const int authenticStatus = EVP_DigestVerifyFinal(rsaVerifyContext, const_cast<unsigned char*>(signature), signatureLength);
                                // #med - review the return value here - it's not documented in the manual
                                // note: cleanup() must be called so to not leak resources generated during the EVP_SignalFinal()-call
-                               (void)EVP_MD_CTX_cleanup(rsaVerifyContext);
+                               (void)EVP_MD_CTX_free(rsaVerifyContext);
                                EVP_MD_CTX_destroy(rsaVerifyContext);
 
                                if (authenticStatus == 1) {
@@ -309,4 +309,4 @@ namespace SLNet
                        }
                }
        }
-}
\ No newline at end of file
+}

Caused with OpenSSL version >= 1.1.
I don't known if it's planned to support latest OpenSSL version ?

[Reveares]

It would be good to support newer OpenSSL versions. Because when SLikeNet is used with vcpkg a much newer version of OpenSSL gets used. They fixed it by simple removing all files in the crypto folder.

[Luke1410]

We are currently working on adding support for OpenSSL >= 1.1.0. While the 0.x/1.x branch will be locked with the bundled 1.0.2x build in 0.2.0+, the 2.x branch will be ship with a later version (at least >= 1.1.1x). Regardless, support for building SLikenet 0.x/1.x with OpenSSL >= 1.x.y will also be added as part of the wok.

[Luke1410]

This was fixed on trunk in SVN the other day. The GitHub repository will be updated soon.
The fix will introduce a new CCryptoManager::Terminate() method which can/should be used upon program termination to properly clean up OpenSSL related resources.

[CBtiger]

Just tried to compile the master on Linux and ran into the same issue.
I am confused because openssl in DependentExtensions is still 1.0.0t. The Changelog says its Version 0.2.0 and updated to OpenSSL 1.0.2i. The readme file says its Version 0.1.3.
However, when compiling Cmake finds the installed OpenSSL which is a 1.1.x type, so I guess the DependetExtensions version is meant for Windows only. Does that mean compilation on Linux does not work until openSSL support is 1.1.x?

It would be helpful to know if there is at least a switch to disable the relevant sections to get it compiled. For testing its fine to not use the OpenSSL related stuff. Any tips what to disable (i.e. in the NativeFeatuerIncludes.h file)