🔧 Add celebration style to confirmation messages and backups

## Changes
- Add star sign and celebration style to birthday confirmation blocks
- Centralise CELEBRATION_STYLE_EMOJIS constant for consistent emoji usage
- Pass user_id through backup chain for accurate preferences lookup
- Update DM and slash command confirmation messages with enhanced details

## Files Modified
- handlers/modal_handlers.py, services/dispatcher.py, storage/birthdays.py

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: RizhongLin

handlers/modal_handlers.py

@@ -135,8 +135,8 @@ def handle_birthday_modal_submission(ack, body, client, view):
             # Save birthday with preferences using existing function
             updated = save_birthday(date_ddmm, user_id, birth_year, username, preferences)
 
-            # Send external backup
-            trigger_external_backup(updated, username, app)
+            # Send external backup with user_id for preferences lookup
+            trigger_external_backup(updated, username, app, user_id=user_id)
 
             # Check if birthday is today
             if check_if_birthday_today(date_ddmm):
@@ -175,7 +175,11 @@ def handle_open_modal_button(ack, body, client):
 
 def _send_modal_confirmation(client, user_id, date_ddmm, birth_year, updated):
     """Send confirmation after modal submission."""
-    from storage.birthdays import CELEBRATION_STYLES, get_user_preferences
+    from storage.birthdays import (
+        CELEBRATION_STYLE_EMOJIS,
+        CELEBRATION_STYLES,
+        get_user_preferences,
+    )
     from utils.date import calculate_age, date_to_words, get_star_sign
 
     date_words = date_to_words(date_ddmm, birth_year)
@@ -186,9 +190,7 @@ def _send_modal_confirmation(client, user_id, date_ddmm, birth_year, updated):
     prefs = get_user_preferences(user_id) or {}
     celebration_style = prefs.get("celebration_style", "standard")
     style_description = CELEBRATION_STYLES.get(celebration_style, "Standard celebration")
-
-    # Style emoji mapping
-    style_emoji = {"quiet": "🤫", "standard": "🎊", "epic": "🚀"}.get(celebration_style, "🎊")
+    style_emoji = CELEBRATION_STYLE_EMOJIS.get(celebration_style, "🎊")
 
     action = "updated" if updated else "saved"
 

services/dispatcher.py

@@ -29,6 +29,9 @@
     is_admin,
 )
 from storage.birthdays import (
+    CELEBRATION_STYLE_EMOJIS,
+    CELEBRATION_STYLES,
+    get_user_preferences,
     remove_birthday,
     save_birthday,
 )
@@ -38,6 +41,7 @@
     check_if_birthday_today,
     date_to_words,
     extract_date,
+    get_star_sign,
 )
 
 # Confirmation timeout from centralized config
@@ -332,19 +336,28 @@ def handle_dm_date(say, user, result, app):
         try:
             from slack.blocks import build_confirmation_blocks
 
+            # Get star sign and celebration style for confirmation
+            star_sign = get_star_sign(date)
+            prefs = get_user_preferences(user) or {}
+            celebration_style = prefs.get("celebration_style", "standard")
+            style_emoji = CELEBRATION_STYLE_EMOJIS.get(celebration_style, "🎊")
+            style_desc = CELEBRATION_STYLES.get(celebration_style, "Standard celebration")
+
+            # Build details dict
+            details = {
+                "📅 Birthday": date_words,
+                "⭐ Star Sign": star_sign,
+            }
+            if age_text:
+                details["🎈 Age"] = age_text.replace(" (Age: ", "").replace(")", "")
+            details[f"{style_emoji} Style"] = f"{celebration_style.title()} - {style_desc}"
+
             if updated:
                 blocks, fallback = build_confirmation_blocks(
                     title="Birthday Updated!",
                     message="Your birthday has been updated successfully.\n\nIf this is incorrect, please send the correct date.",
                     action_type="success",
-                    details={
-                        "Birthday": date_words,
-                        "Age": (
-                            age_text.replace(" (Age: ", "").replace(")", "")
-                            if age_text
-                            else "Not specified"
-                        ),
-                    },
+                    details=details,
                 )
                 say(blocks=blocks, text=fallback)
                 logger.info(
@@ -355,14 +368,7 @@ def handle_dm_date(say, user, result, app):
                     title="Birthday Saved!",
                     message="Your birthday has been saved successfully!\n\nIf this is incorrect, please send the correct date.",
                     action_type="success",
-                    details={
-                        "Birthday": date_words,
-                        "Age": (
-                            age_text.replace(" (Age: ", "").replace(")", "")
-                            if age_text
-                            else "Not specified"
-                        ),
-                    },
+                    details=details,
                 )
                 say(blocks=blocks, text=fallback)
                 logger.info(
@@ -391,10 +397,10 @@ def handle_dm_date(say, user, result, app):
                 )
 
     # Send external backup after user confirmation to avoid API conflicts
-    _send_external_backup_if_enabled(updated, username, app)
+    _send_external_backup_if_enabled(updated, username, app, user_id=user)
 
 
-def _send_external_backup_if_enabled(updated, username, app, change_type=None):
+def _send_external_backup_if_enabled(updated, username, app, change_type=None, user_id=None):
     """
     Send external backup after birthday changes if enabled.
 
@@ -403,10 +409,11 @@ def _send_external_backup_if_enabled(updated, username, app, change_type=None):
         username: Username of the person whose birthday changed
         app: Slack app instance for sending backup
         change_type: Optional override for change type ("add", "update", "remove")
+        user_id: User ID of the person whose birthday changed (for preferences lookup)
     """
     from storage.birthdays import trigger_external_backup
 
-    trigger_external_backup(updated, username, app, change_type)
+    trigger_external_backup(updated, username, app, change_type, user_id)
 
 
 def handle_command(text, user_id, say, app):
@@ -564,19 +571,28 @@ def _handle_add_command(parts, user_id, username, say, app):
         try:
             from slack.blocks import build_confirmation_blocks
 
+            # Get star sign and celebration style for confirmation
+            star_sign = get_star_sign(date)
+            prefs = get_user_preferences(user_id) or {}
+            celebration_style = prefs.get("celebration_style", "standard")
+            style_emoji = CELEBRATION_STYLE_EMOJIS.get(celebration_style, "🎊")
+            style_desc = CELEBRATION_STYLES.get(celebration_style, "Standard celebration")
+
+            # Build details dict
+            details = {
+                "📅 Birthday": date_words,
+                "⭐ Star Sign": star_sign,
+            }
+            if age_text:
+                details["🎈 Age"] = age_text.replace(" (Age: ", "").replace(")", "")
+            details[f"{style_emoji} Style"] = f"{celebration_style.title()} - {style_desc}"
+
             if updated:
                 blocks, fallback = build_confirmation_blocks(
                     title="Birthday Updated!",
                     message="Your birthday has been updated successfully.",
                     action_type="success",
-                    details={
-                        "Birthday": date_words,
-                        "Age": (
-                            age_text.replace(" (Age: ", "").replace(")", "")
-                            if age_text
-                            else "Not specified"
-                        ),
-                    },
+                    details=details,
                 )
                 say(blocks=blocks, text=fallback)
                 logger.info(
@@ -587,14 +603,7 @@ def _handle_add_command(parts, user_id, username, say, app):
                     title="Birthday Saved!",
                     message="Your birthday has been saved successfully!",
                     action_type="success",
-                    details={
-                        "Birthday": date_words,
-                        "Age": (
-                            age_text.replace(" (Age: ", "").replace(")", "")
-                            if age_text
-                            else "Not specified"
-                        ),
-                    },
+                    details=details,
                 )
                 say(blocks=blocks, text=fallback)
                 logger.info(
@@ -619,7 +628,7 @@ def _handle_add_command(parts, user_id, username, say, app):
                 )
 
     # Send external backup after user confirmation
-    _send_external_backup_if_enabled(updated, username, app)
+    _send_external_backup_if_enabled(updated, username, app, user_id=user_id)
 
 
 def _handle_remove_command(user_id, username, say, app):

storage/birthdays.py

@@ -71,6 +71,13 @@
     "epic": "Over-the-top message, AI image, and celebratory reactions",
 }
 
+# Celebration style emojis for display
+CELEBRATION_STYLE_EMOJIS = {
+    "quiet": "🤫",
+    "standard": "🎊",
+    "epic": "🚀",
+}
+
 
 def create_backup():
     """
@@ -123,7 +130,9 @@ def rotate_backups():
         logger.error(f"BACKUP_ERROR: Failed to rotate backups: {e}")
 
 
-def send_external_backup(backup_file_path, change_type="update", username=None, app=None):
+def send_external_backup(
+    backup_file_path, change_type="update", username=None, app=None, user_id=None
+):
     """
     Send backup file to admin users via DM and optionally to backup channel.
 
@@ -132,6 +141,7 @@ def send_external_backup(backup_file_path, change_type="update", username=None,
         change_type: Type of change that triggered backup ("add", "update", "remove", "manual")
         username: Username of person whose birthday changed (for context)
         app: Slack app instance (required for sending messages)
+        user_id: User ID of person whose birthday changed (for preferences lookup)
     """
     logger.info(f"BACKUP: send_external_backup called - type: {change_type}, user: {username}")
 
@@ -158,9 +168,20 @@ def send_external_backup(backup_file_path, change_type="update", username=None,
             "manual": "Manual backup created",
         }.get(change_type, "Data changed")
 
+        # Get user's preferences for context if available
+        prefs_text = ""
+        if user_id and change_type in ("add", "update"):
+            user_data = birthdays.get(user_id, {})
+            prefs = user_data.get("preferences", {})
+            style = prefs.get("celebration_style", "standard")
+            if style != "standard":
+                style_emoji = CELEBRATION_STYLE_EMOJIS.get(style, "🎊")
+                style_desc = CELEBRATION_STYLES.get(style, "")
+                prefs_text = f"\n{style_emoji} *Style:* {style.title()} - {style_desc}"
+
         message = f"""🗂️ *Birthday Data Backup* - {timestamp}
 
-📊 *Changes:* {change_text}
+📊 *Changes:* {change_text}{prefs_text}
 📁 *File:* {os.path.basename(backup_file_path)} ({file_size_kb} KB)
 👥 *Total Birthdays:* {total_birthdays} people
 🔄 *Auto-backup after data changes*
@@ -206,7 +227,7 @@ def send_external_backup(backup_file_path, change_type="update", username=None,
         logger.error(f"BACKUP: Failed to send external backup: {e}")
 
 
-def trigger_external_backup(updated, username, app, change_type=None):
+def trigger_external_backup(updated, username, app, change_type=None, user_id=None):
     """
     Trigger external backup after birthday changes if enabled.
 
@@ -217,6 +238,7 @@ def trigger_external_backup(updated, username, app, change_type=None):
         username: Username of the person whose birthday changed
         app: Slack app instance for sending backup
         change_type: Optional override for change type ("add", "update", "remove")
+        user_id: User ID of the person whose birthday changed (for preferences lookup)
     """
     from config import BACKUP_ON_EVERY_CHANGE
 
@@ -233,7 +255,7 @@ def trigger_external_backup(updated, username, app, change_type=None):
             latest_backup = max(backup_files, key=lambda x: os.path.getmtime(x))
             if change_type is None:
                 change_type = "update" if updated else "add"
-            send_external_backup(latest_backup, change_type, username, app)
+            send_external_backup(latest_backup, change_type, username, app, user_id)
     except Exception as e:
         logger.error(f"BACKUP: Failed to trigger external backup: {e}")