Skip to content

Commit 921e00b

Browse files
Merge pull request #3256 from rachel-fenichel/cp_3202
Cherry-pick #3202 and bump patch version
2 parents 15a6fa7 + 09687cb commit 921e00b

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

blockly_compressed.js

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

core/dropdowndiv.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ Blockly.DropDownDiv.showPositionedByBlock = function(field, block,
263263
*/
264264
Blockly.DropDownDiv.showPositionedByField = function(field,
265265
opt_onHide, opt_secondaryYOffset) {
266-
var position = field.fieldGroup_.getBoundingClientRect();
266+
var position = field.getSvgRoot().getBoundingClientRect();
267267
// If we can fit it, render below the block.
268268
var primaryX = position.left + position.width / 2;
269269
var primaryY = position.bottom;
@@ -574,11 +574,11 @@ Blockly.DropDownDiv.hide = function() {
574574
Blockly.DropDownDiv.animateOutTimer_ =
575575
setTimeout(function() {
576576
Blockly.DropDownDiv.hideWithoutAnimation();
577-
if (Blockly.DropDownDiv.onHide_) {
578-
Blockly.DropDownDiv.onHide_();
579-
Blockly.DropDownDiv.onHide_ = null;
580-
}
581577
}, Blockly.DropDownDiv.ANIMATION_TIME * 1000);
578+
if (Blockly.DropDownDiv.onHide_) {
579+
Blockly.DropDownDiv.onHide_();
580+
Blockly.DropDownDiv.onHide_ = null;
581+
}
582582
};
583583

584584
/**

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "blockly",
3-
"version": "3.20191014.0",
3+
"version": "3.20191014.1",
44
"description": "Blockly is a library for building visual programming editors.",
55
"keywords": [
66
"blockly"

0 commit comments

Comments
 (0)