-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Labels
driverdriver relateddriver relatedrefactorrefactoring code, same functionality, but better coderefactoring code, same functionality, but better code
Description
-
MIDDriver is using midi::devices namespace
-
ADLDriver is using a bare OPL device, must be converted to use midi::devices
-
midi::devices requires an OP2Bank, it might not be available. so it must be optional. or create a parallel adl::devices ...
also must check if those shared_ptr are not nullptrs .... -
ADLDriver is also taking in an ADLFile, while all the other are taking in a MIDI parsed file., but it can be ok in this case. ADL file and driver are very specific and not intended to be a standard like MIDI.
midi:devices move to devices that embedd the MIDDriver and ADLDriver for now and have a overloadede play method to play from the device, simpler to use.
Metadata
Metadata
Assignees
Labels
driverdriver relateddriver relatedrefactorrefactoring code, same functionality, but better coderefactoring code, same functionality, but better code
Projects
Status
To do
Status
To do
Status
To do