Make StatSheet responsible for deciding its own IDs

THere were several places where `StatSheetManager` instances had to be conjured out of nowhere just to append the
namespace and name into an ID. This is no longer necessary as `StatSheet#id()` will do the same without involving a
`StatSheetManager`.

Author: kwvanderlinde

src/main/java/net/rptools/maptool/client/ui/campaignproperties/TokenPropertiesManagementPanel.java

@@ -479,9 +479,8 @@ private void populateStatSheetComboBoxes(String propertyType) {
     var statSheetProperty = tokenTypeStatSheetMap.get(propertyType);
     String id;
     if (statSheetProperty == null) {
-      id = ssManager.getDefaultStatSheetId();
-      tokenTypeStatSheetMap.put(
-          propertyType, new StatSheetProperties(ssManager.getDefaultStatSheetId(), null));
+      id = StatSheetManager.LEGACY_STATSHEET.id();
+      tokenTypeStatSheetMap.put(propertyType, new StatSheetProperties(id, null));
     } else {
       id = statSheetProperty.id();
     }
@@ -514,7 +513,7 @@ public void initStatSheetDetails() {
           if (getStatSheetComboBox().hasFocus()) { // Only if user has made change
             var tokenType = (String) getTokenTypeList().getSelectedValue();
             if (ss != null && tokenType != null) {
-              var id = new StatSheetManager().getId(ss);
+              var id = ss.id();
               var location = tokenTypeStatSheetMap.get(tokenType).location();
               tokenTypeStatSheetMap.put(tokenType, new StatSheetProperties(id, location));
               getStatSheetLocationComboBox().setSelectedItem(location);

src/main/java/net/rptools/maptool/client/ui/token/dialog/create/NewTokenDialog.java

@@ -166,11 +166,10 @@ public boolean commit() {
 
     var statSheet = (StatSheet) getStatSheetComboBox().getSelectedItem();
     var location = (StatSheetLocation) getStatSheetLocationComboBox().getSelectedItem();
-    var ssManager = new StatSheetManager();
     if (statSheet == null || (statSheet.name() == null && statSheet.namespace() == null)) {
       token.useDefaultStatSheet();
     } else {
-      token.setStatSheet(new StatSheetProperties(ssManager.getId(statSheet), location));
+      token.setStatSheet(new StatSheetProperties(statSheet.id(), location));
     }
 
     return true;

src/main/java/net/rptools/maptool/client/ui/token/dialog/edit/EditTokenDialog.java

@@ -908,9 +908,8 @@ public boolean commit() {
     if (ss == null || (ss.name() == null && ss.namespace() == null)) {
       token.useDefaultStatSheet();
     } else {
-      var ssManager = new StatSheetManager();
       var location = (StatSheetLocation) getStatSheetLocationCombo().getSelectedItem();
-      token.setStatSheet(new StatSheetProperties(ssManager.getId(ss), location));
+      token.setStatSheet(new StatSheetProperties(ss.id(), location));
     }
 
     /* Macros */

src/main/java/net/rptools/maptool/model/sheet/stats/StatSheet.java

@@ -30,6 +30,10 @@
  */
 public record StatSheet(
     String name, String description, URL entry, Set<String> propertyTypes, String namespace) {
+  public String id() {
+    return namespace + "." + name;
+  }
+
   @Override
   public boolean equals(Object obj) {
     if (!(obj instanceof StatSheet other)) {

src/main/java/net/rptools/maptool/model/sheet/stats/StatSheetManager.java

@@ -76,42 +76,6 @@ public class StatSheetManager {
     statSheets.put(NO_STATSHEET, "");
   }
 
-  /**
-   * Returns the default stat sheet.
-   *
-   * @return the default stat sheet.
-   */
-  public StatSheet getDefaultStatSheet() {
-    return LEGACY_STATSHEET;
-  }
-
-  /**
-   * Returns the id of the default stat sheet.
-   *
-   * @return the id of the default stat sheet.
-   */
-  public String getDefaultStatSheetId() {
-    return getId(LEGACY_STATSHEET);
-  }
-
-  /**
-   * Returns the "no" stat sheet.
-   *
-   * @return the "no" stat sheet.
-   */
-  public StatSheet getNoStatSheet() {
-    return NO_STATSHEET;
-  }
-
-  /**
-   * Returns the id of the "no" stat sheet.
-   *
-   * @return the id of the "no" stat sheet.
-   */
-  public String getNoStatSheetId() {
-    return getId(NO_STATSHEET);
-  }
-
   /**
    * Returns the name and namespace of the stat sheet with the given id.
    *
@@ -201,17 +165,6 @@ public StatSheet getStatSheet(String id) {
     return getStatSheet(name[0], name[1]);
   }
 
-  /**
-   * Returns the id of the stat sheet with the given namespace and name.
-   *
-   * @param namespace the namespace of the stat sheet.
-   * @param name the name of the stat sheet.
-   * @return the id of the stat sheet with the given namespace and name.
-   */
-  public String getId(String namespace, String name) {
-    return namespace + "." + name;
-  }
-
   /**
    * Returns the id of the stat sheet.
    *
@@ -302,16 +255,6 @@ public String getStatSheetContent(String id) {
     return getStatSheetContent(name[0], name[1]);
   }
 
-  /**
-   * Returns the id of the stat sheet.
-   *
-   * @param ss the stat sheet.
-   * @return the id of the stat sheet.
-   */
-  public String getId(StatSheet ss) {
-    return getId(ss.namespace(), ss.name());
-  }
-
   /**
    * Compares two stat sheets. Internal stat sheets (null, legacy, and no stat sheet) come before
    * non-internal stat sheets. Among internal stat sheets, null (default) comes first, then legacy,