New version not compiling on ubuntu:latest ?

[snow884]

Hi,

I tried compiling the latest RGB lightning version on ubuntu:24.04 and I am getting this error

when running cd rgb-lightning-node && git pull && git checkout master && cargo install --locked --debug --path .

436.1    Compiling lightning v0.0.125 (/rgb-lightning-node/rust-lightning/lightning)
460.7 error: this function depends on never type fallback being `()`
460.7     --> rust-lightning/lightning/src/ln/chan_utils.rs:1413:2
460.7      |
460.7 1413 |     fn read<R: io::Read>(reader: &mut R) -> Result<Self, DecodeError> {
460.7      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
460.7      |
460.7      = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in Rust 2024 and in a future release in all editions!
460.7      = note: for more information, see <https://doc.rust-lang.org/edition-guide/rust-2024/never-type-fallback.html>
460.7      = help: specify the types explicitly
460.7 note: in edition 2024, the requirement `!: Readable` will fail
460.7     --> rust-lightning/lightning/src/util/ser_macros.rs:373:17
460.7      |
460.7  373 |           $field = Some($crate::util::ser::Readable::read(&mut $reader)?);
460.7      |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
460.7      |
460.7     ::: rust-lightning/lightning/src/ln/chan_utils.rs:1414:3
460.7      |
460.7 1414 | /         _init_and_read_len_prefixed_tlv_fields!(reader, {
460.7 1415 | |             (0, commitment_number, required),
460.7 1416 | |             (1, to_broadcaster_delay, option),
460.7 1417 | |             (2, to_broadcaster_value_sat, required),
460.7 ...    |
460.7 1424 | |             (15, channel_type_features, option),
460.7 1425 | |         });
460.7      | |__________- in this macro invocation
460.7      = note: `#[deny(dependency_on_unit_never_type_fallback)]` (part of `#[deny(rust_2024_compatibility)]`) on by default
460.7      = note: this error originates in the macro `$crate::_decode_tlv` which comes from the expansion of the macro `_init_and_read_len_prefixed_tlv_fields` (in Nightly builds, run with -Z macro-backtrace for more info)
460.7
478.4 error: could not compile `lightning` (lib) due to 2 previous errors
478.5 error: failed to compile `rgb-lightning-node v0.1.0 (/rgb-lightning-node)`, intermediate artifacts can be found at `/rgb-lightning-node/target`.
478.5 To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.
------

 1 warning found (use docker --debug to expand):
 - JSONArgsRecommended: JSON arguments recommended for CMD to prevent unintended behavior related to OS signals (line 43)
Dockerfile:37
--------------------
  35 |
  36 |     RUN git clone https://github.com/RGB-Tools/rgb-lightning-node --recurse-submodules --shallow-submodules
  37 | >>> RUN cd rgb-lightning-node && git pull && git checkout master && cargo install --locked --debug --path .
  38 |
  39 |     ADD ./node/rgb_node/entrypoint.sh /entrypoint.sh
--------------------
ERROR: failed to build: failed to solve: process "/bin/sh -c cd rgb-lightning-node && git pull && git checkout master && cargo install --locked --debug --path ." did not complete successfully: exit code: 101

[zoedberg]

After checking out a branch you need to update the submodule with git submodule update --init

[snow884]

let me try....

[zoedberg]

Build was failing due to the recent Rust 1.92. Just pushed an update, it should build now. Closing this