Webshark crashes with big pcap files because of integer overflow #51
Description
Trying to upload bigger pcap files in webshark like a 4.3GB pcap file makes the application crash because of 32bit integer overflow.
Steps to re-produce:
- Download example pcap file from here:
https://mcfp.weebly.com/the-ctu-13-dataset-a-labeled-dataset-with-botnet-normal-and-background-traffic.html - Direct link: https://mcfp.felk.cvut.cz/publicDatasets/CTU-13-Dataset/CTU-13-Dataset.tar.bz2
- Extract and upload the pcap file called "botnet-capture-20110818-bot-2.pcap" (4.3GB)
Webshark then crashes with this error:
webshark | {"level":50,"time":1745413016639,"pid":34,"hostname":"6fc59162ab98","err":{"type":"RangeError","message":"The value of \"length\" is out of range. It must be >= 0 && <= 2147483647. Received 4263638204","stack":"RangeError [ERR_OUT_OF_RANGE]: The value of \"length\" is out of range. It must be >= 0 && <= 2147483647. Received 4263638204\n at Object.write (node:fs:852:5)\n at writeAll (node:fs:2241:6)\n at node:fs:2331:7\n at FSReqCallback.oncomplete (node:fs:188:23)","code":"ERR_OUT_OF_RANGE"},"msg":"The value of \"length\" is out of range. It must be >= 0 && <= 2147483647. Received 4263638204"}