Skip to content

Default value for cutoff/radius in open or semi-open BC #5602

@ye-luo

Description

@ye-luo

Describe the bug
It was spotted that a few features set cutoff/radius to magic numbers when user input doesn't exist.
In the case periodic boundary condition (ppp), wigner seitz radius is a safe default.
However, with a open or semi-open boundary condition, the current magic number 10 is generally considered harmful. I feel it better to stop the code and demand user input.

It seems distance based jastrow factors and gofr estimator all carry a similar issue.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions