Skip to content

Commit b8d3ba6

Browse files
authored
Merge pull request #217 from PyEllips/update-readme
Fix install instructions and git clone with submodule
2 parents d37e33d + c9d40b8 commit b8d3ba6

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,12 +70,12 @@ or **Miniconda**
7070
page. This creates a copy of the code under your account on github.
7171
3. Clone this copy to your local disk
7272

73-
git clone https://github.com:YourLogin/pyElli.git
73+
git clone --recurse-submodules https://github.com/PyEllips/pyElli
7474
cd pyElli
7575

7676
4. You should run
7777

78-
pip install -U pip setuptools -e .[fitting,dev]
78+
pip install -e ".[fitting,dev]"
7979

8080
which installs the package in development mode and all extra requirements in your current virtualenv.
8181

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ The installers for all releases are available at the [Python Package Index (PyPI
3434
To install run:
3535

3636
```sh
37-
pip install pyElli[fitting]
37+
pip install "pyElli[fitting]"
3838
```
3939

4040
This installs pyElli with the additional fitting capabilities and interactive widgets.
@@ -66,7 +66,7 @@ The source code is hosted on [GitHub](https://github.com/PyEllips/pyElli), to ma
6666
the folder to install it in development mode:
6767

6868
```sh
69-
git clone https://github.com/PyEllips/pyElli
69+
git clone --recurse-submodules https://github.com/PyEllips/pyElli
7070
cd pyElli
7171
pip install -e ".[fitting]"
7272
```

docs/installation.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ To install the package in your current virtual environment execute
1010

1111
.. code-block:: shell
1212
13-
pip install pyElli[fitting]
13+
pip install "pyElli[fitting]"
1414
1515
This installs pyElli with the additional fitting capabilities and interactive widgets.
1616
If you don't want to have this functionality just drop the `[fitting]` in the end.
@@ -44,6 +44,6 @@ the folder to install it in development mode:
4444

4545
.. code-block:: shell
4646
47-
git clone https://github.com/PyEllips/pyElli
47+
git clone --recurse-submodules https://github.com/PyEllips/pyElli
4848
cd pyElli
4949
pip install -e .

0 commit comments

Comments
 (0)