Skip to content

Commit 50197bd

Browse files
committed
deps: upgrade pdf.js to 4.0.379
1 parent fb5aed2 commit 50197bd

File tree

12 files changed

+397
-359
lines changed

12 files changed

+397
-359
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ to build based on submodule `pdf.js` in `packages/document-viewer/pdf.js`. The s
1515
1. Update the pdf.js submodule to a specific release version.
1616
- Run `git submodule update --remote` to update PDF.js
1717
- Checkout to the release version want to sync
18+
- Make sure to run `npm ci` to update the dependencies
1819
2. Run `pnpm syncWithUpstream`
1920
3. Review auto-generated files
2021
- `@document-kits/viewer/src/app_helper.js`

demos/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"preview": "vite preview"
99
},
1010
"dependencies": {
11-
"@document-kits/viewer": "0.10.0-beta.0",
11+
"@document-kits/viewer": "workspace:*",
1212
"vue": "^3.3.4",
1313
"vue-router": "^4.2.4"
1414
},

demos/src/examples/multiple-files.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ const options1 = {
99
resourcePath: "document-viewer",
1010
disableCORSCheck: true,
1111
disableAutoSetTitle: true,
12+
appOptions: {},
1213
};
1314

1415
const options2 = {

demos/vite.config.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ export default defineConfig(({ command, mode, ssrBuild }) => {
2020
}),
2121
],
2222
// Used in dev mode
23-
// optimizeDeps: {
24-
// include: ["@document-kits/viewer"],
25-
// },
23+
optimizeDeps: {
24+
include: ["@document-kits/viewer"],
25+
},
2626
resolve: {
2727
alias: [
2828
{

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"docs:extract": "pnpm --filter @document-kits/viewer run api",
1212
"docs:build": "pnpm --filter viewer-docs run build",
1313
"docs:preview": "pnpm --filter viewer-docs run preview",
14-
"syncWithUpstream": "pnpm --filter @document-kits/viewer run syncWithUpstream",
14+
"syncWithUpstream": "pnpm --filter @document-kits/viewer run syncWithUpstream && cargo run -p upstream",
1515
"fmt": "npx prettier --write --ignore-unknown ."
1616
},
1717
"lint-staged": {

packages/document-viewer/bin/gulpfile.template.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ gulp.task(
7070
function createGeneric() {
7171
console.log();
7272
console.log("### Creating generic document viewer");
73-
const defines = builder.merge(DEFINES, { GENERIC: true });
73+
const defines = { ...DEFINES, GENERIC: true };
7474

7575
return buildGenericApp(defines);
7676
},

packages/document-viewer/pdf.js

Submodule pdf.js updated 446 files

packages/document-viewer/src/app.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,11 @@ class PDFViewerApplication extends ViewerApplication {
2121
return super.run(config, validateFileURL);
2222
}
2323

24+
_parseHashParams() {
25+
const { loadFakeWorker } = this.helper;
26+
return super._parseHashParams(loadFakeWorker);
27+
}
28+
2429
bindEvents() {
2530
const AppOptions = this.appOptions;
2631
const { eventBus, _boundEvents } = this;

packages/document-viewer/src/app_helper.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import {
2+
CursorTool,
23
getActiveOrFocusedElement,
34
normalizeWheelEventDirection,
45
parseQueryString,
@@ -7,10 +8,9 @@ import {
78
} from "../pdf.js/web/ui_utils";
89
import {
910
GlobalWorkerOptions,
10-
loadScript,
11+
// loadScript,
1112
PDFWorker,
1213
} from "pdfjs-lib";
13-
import {CursorTool} from "../pdf.js/web/pdf_cursor_tools";
1414

1515
const WHEEL_ZOOM_DISABLED_TIMEOUT = 1000; // ms
1616

@@ -46,7 +46,8 @@ function createHelper(PDFViewerApplication) {
4646
window.pdfjsWorker = await import("pdfjs/pdf.worker.js");
4747
return;
4848
}
49-
await loadScript(PDFWorker.workerSrc);
49+
// await loadScript(PDFWorker.workerSrc);
50+
await __non_webpack_import__(PDFWorker.workerSrc);
5051
}
5152

5253
async function loadPDFBug(self) {

0 commit comments

Comments
 (0)