Skip to content

Commit ed61825

Browse files
committed
some more arg fixing
1 parent c89102c commit ed61825

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

src/mrcal_wrapper.cpp

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ static std::unique_ptr<mrcal_result> mrcal_calibrate(
9191

9292
// Pool is the raw observation backing array
9393
mrcal_point3_t *c_observations_board_pool = (observations_board.data());
94-
// mrcal_point3_t *c_observations_point_pool = observations_point;
94+
mrcal_point3_t *c_observations_point_pool = observations_point;
9595

9696
// Copy from board/point pool above, using some code borrowed from
9797
// mrcal-pywrap
@@ -135,19 +135,18 @@ static std::unique_ptr<mrcal_result> mrcal_calibrate(
135135
int Ncameras_extrinsics = 0; // Seems to always be zero for single camera
136136
int Nframes =
137137
frames_rt_toref.size(); // Number of pictures of the object we've got
138-
mrcal_observation_point_triangulated_t *observations_point_triangulated =
139-
NULL;
140138

141139
if (!lensmodel_one_validate_args(&mrcal_lensmodel, intrinsics, false)) {
142140
auto ret = std::make_unique<mrcal_result>();
143141
ret->success = false;
144142
return ret;
145143
}
146144

145+
146+
147147
int Nmeasurements = mrcal_num_measurements(
148148
Nobservations_board, Nobservations_point,
149-
observations_point_triangulated,
150-
0, // hard-coded to 0
149+
NULL, 0, // We don't use these, so pass nulls
151150
calibration_object_width_n, calibration_object_height_n,
152151
Ncameras_intrinsics, Ncameras_extrinsics, Nframes, Npoints, Npoints_fixed,
153152
problem_selections, &mrcal_lensmodel);
@@ -179,8 +178,8 @@ static std::unique_ptr<mrcal_result> mrcal_calibrate(
179178
Ncameras_extrinsics, Nframes, Npoints, Npoints_fixed,
180179
c_observations_board, c_observations_point, Nobservations_board,
181180
Nobservations_point,
182-
// observations_point_triangulated, -1,
183-
c_observations_board_pool, &mrcal_lensmodel, c_imagersizes,
181+
NULL, -1, // We don't use these, so pass nulls
182+
c_observations_board_pool, c_observations_point_pool, &mrcal_lensmodel, c_imagersizes,
184183
problem_selections, &problem_constants, calibration_object_spacing,
185184
calibration_object_width_n, calibration_object_height_n, verbose, false);
186185

0 commit comments

Comments
 (0)