refactor(chart): Unitize note position x unit

Author: MisaLiu

src/chart/converter/official/index.ts

@@ -182,7 +182,7 @@ export const ConvertFromOfficial = (_chartRaw: IChartOfficial) => {
       oldNote.isAbove,
       oldNote.time,
       oldNote.speed,
-      parseDoublePrecist(oldNote.posX, 6),
+      parseDoublePrecist(oldNote.posX * (9 / 80), 4),
       oldNote.isSameTime,
       oldNote.floorPosition,
       oldNote.holdTime,

src/chart/converter/phiedit/index.ts

@@ -258,7 +258,7 @@ export const ConvertFromPhiEdit = (_chartRaw: string) => {
           ),
           lineID: parseNumber(commandArr[1], -1),
           startBeat: parseNumber(commandArr[2], 0),
-          positionX: parseNumber(parseFloat(commandArr[3]) * 9 / 1024, 0),
+          positionX: parseNumber(parseFloat(commandArr[3]) / 1024, 0, 4),
           speed: 1,
           scaleX: 1,
           isAbove: commandArr[4] == '1',
@@ -272,7 +272,7 @@ export const ConvertFromPhiEdit = (_chartRaw: string) => {
           lineID: parseNumber(commandArr[1], -1),
           startBeat: parseNumber(commandArr[2], 0),
           endBeat: parseNumber(commandArr[3], 0),
-          positionX: parseNumber(parseFloat(commandArr[4]) * 9 / 1024, 0),
+          positionX: parseNumber(parseFloat(commandArr[4]) / 1024, 0, 4),
           speed: 1,
           scaleX: 1,
           isAbove: commandArr[5] == '1',

src/chart/converter/rephiedit/index.ts

@@ -309,7 +309,7 @@ export const ConvertFromRePhiEdit = (_chartRaw: TRPEChart) => {
         time: realTime,
         holdTime: holdTime,
         speed: oldNote.speed,
-        posX: parseDoublePrecist(oldNote.positionX / (675 * (9 / 80)), 6),
+        posX: parseDoublePrecist(oldNote.positionX / 675, 4),
         isAbove: oldNote.above === 1,
         isFake: oldNote.isFake === 1,
         isSameTime: false,

src/chart/tick.ts

@@ -155,7 +155,7 @@ export function onChartTick(this: GameChart, currentTime: number, container: Con
       continue;
     }
 
-    const posX = size.widthPercent * notePosX;
+    const posX = widthHalf * notePosX;
     const posY = floorPositionDiff * size.noteSpeed * (isAbove ? -1 : 1);
     const realXSin = posY * judgeline.sinr * -1;
     const realYCos = posY * judgeline.cosr;

src/renderer/index.ts

@@ -32,7 +32,6 @@ export interface IGameRendererSize {
   widthRealHalf: number,
   /** `widthRealHalf - widthHalf` */
   widthOffset: number,
-  widthPercent: number,
   /** Used for culling notes */
   widthHalfBorder: number,
   /** Used for culling notes */
@@ -66,7 +65,6 @@ export class GameRenderer {
     widthReal: 0,
     widthRealHalf: 0,
     widthOffset: 0,
-    widthPercent: 0,
     widthHalfBorder: 0,
     heightHalfBorder: 0,
 
@@ -159,8 +157,6 @@ export class GameRenderer {
     size.widthHalfBorder = size.widthHalf * 1.2;
     size.heightHalfBorder = size.heightHalf * 1.2;
 
-    size.widthPercent = size.width * (9 / 160);
-
     size.noteScale = size.width / 8080; // TODO: Settings
     size.noteWidth = size.width * 0.117775;
     size.noteSpeed = size.height * 0.6;