Minor refactor

Author: floriankraemer

src/Business/Cognitive/CognitiveMetricsCollector.php

@@ -8,6 +8,7 @@
 use Phauthentic\CognitiveCodeAnalysis\Business\Cognitive\Events\ParserFailed;
 use Phauthentic\CognitiveCodeAnalysis\Business\Cognitive\Events\SourceFilesFound;
 use Phauthentic\CognitiveCodeAnalysis\Business\Utility\DirectoryScanner;
+use Phauthentic\CognitiveCodeAnalysis\Business\Utility\FilenameNormalizer;
 use Phauthentic\CognitiveCodeAnalysis\CognitiveAnalysisException;
 use Phauthentic\CognitiveCodeAnalysis\Config\CognitiveConfig;
 use Phauthentic\CognitiveCodeAnalysis\Config\ConfigService;
@@ -118,7 +119,7 @@ private function findMetrics(iterable $files): CognitiveMetricsCollection
             $metricsCollection = $this->processMethodMetrics(
                 $metrics,
                 $metricsCollection,
-                $this->normalizeFilename($file)
+                FilenameNormalizer::normalize($file)
             );
         }
 
@@ -141,10 +142,8 @@ private function processMethodMetrics(
                 continue;
             }
 
-
             [$class, $method] = explode('::', $classAndMethod);
 
-
             $metricsArray = array_merge($metrics, [
                 'class' => $class,
                 'method' => $method,
@@ -192,26 +191,6 @@ private function findSourceFiles(string $path, array $exclude = []): iterable
         );
     }
 
-    /**
-     * Get the project root directory path.
-     *
-     * Start from the current file's directory and traverse up to find composer.json
-     *
-     * @return string|null The project root path or null if not found
-     */
-    private function getProjectRoot(): ?string
-    {
-        $currentDir = __DIR__;
-
-        while ($currentDir !== dirname($currentDir)) {
-            if (file_exists($currentDir . DIRECTORY_SEPARATOR . 'composer.json')) {
-                return $currentDir;
-            }
-            $currentDir = dirname($currentDir);
-        }
-
-        return null;
-    }
 
     /**
      * Generate a cache key for a file based on path, modification time, and config hash
@@ -260,27 +239,6 @@ public function clearCache(): void
         $this->cachePool->clear();
     }
 
-    /**
-     * Normalize filename for the test environment
-     *
-     * This is to ensure consistent file paths in test outputs
-     */
-    private function normalizeFilename(SplFileInfo $file): string
-    {
-        $filename = $file->getRealPath();
-
-        if (getenv('APP_ENV') !== 'test') {
-            return $filename;
-        }
-
-        $projectRoot = $this->getProjectRoot();
-        if ($projectRoot && str_starts_with($filename, $projectRoot)) {
-            $filename = substr($filename, strlen($projectRoot) + 1);
-        }
-
-        return $filename;
-    }
-
     /**
      * Try to get cached metrics for a file
      *

src/Business/Utility/FilenameNormalizer.php

@@ -0,0 +1,59 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Phauthentic\CognitiveCodeAnalysis\Business\Utility;
+
+use SplFileInfo;
+
+/**
+ * Utility class for normalizing filenames, especially for test environments.
+ */
+class FilenameNormalizer
+{
+    /**
+     * Normalize filename for the test environment
+     *
+     * This is to ensure consistent file paths in test outputs
+     *
+     * @param SplFileInfo $file The file to normalize
+     * @return string The normalized filename
+     */
+    public static function normalize(SplFileInfo $file): string
+    {
+        $filename = $file->getRealPath();
+
+        if (getenv('APP_ENV') !== 'test') {
+            return $filename;
+        }
+
+        $projectRoot = self::getProjectRoot();
+        if ($projectRoot && str_starts_with($filename, $projectRoot)) {
+            $filename = substr($filename, strlen($projectRoot) + 1);
+        }
+
+        return $filename;
+    }
+
+    /**
+     * Get the project root directory by traversing up from the current directory
+     * until composer.json is found.
+     *
+     * Start from the current file's directory and traverse up to find composer.json
+     *
+     * @return string|null The project root path or null if not found
+     */
+    private static function getProjectRoot(): ?string
+    {
+        $currentDir = __DIR__;
+
+        while ($currentDir !== dirname($currentDir)) {
+            if (file_exists($currentDir . DIRECTORY_SEPARATOR . 'composer.json')) {
+                return $currentDir;
+            }
+            $currentDir = dirname($currentDir);
+        }
+
+        return null;
+    }
+}