From aa3ab74834ba7bff35a7bccc34cea192c312d0d7 Mon Sep 17 00:00:00 2001 From: Tarik <50704992+TarikBeentjes61@users.noreply.github.com> Date: Mon, 26 Jan 2026 14:30:43 +0100 Subject: [PATCH 1/2] Fixed rage regeneration not applying the more damage granted from rage Eternal Rage(Gem) Death Articulated (Unique gloves) --- src/Data/ModCache.lua | 2 +- src/Data/Skills/act_str.lua | 7 +++++++ src/Export/Skills/act_str.txt | 7 +++++++ src/Modules/ModParser.lua | 4 ++++ 4 files changed, 19 insertions(+), 1 deletion(-) diff --git a/src/Data/ModCache.lua b/src/Data/ModCache.lua index c91694c01..ed8cf59ad 100644 --- a/src/Data/ModCache.lua +++ b/src/Data/ModCache.lua @@ -5886,7 +5886,7 @@ c["Regenerate 3% of maximum Life over 1 second when Stunned"]={nil,"Regenerate 3 c["Regenerate 3% of maximum Life over 1 second when Stunned +1 to Stun Threshold per Dexterity"]={nil,"Regenerate 3% of maximum Life over 1 second when Stunned +1 to Stun Threshold per Dexterity "} c["Regenerate 3% of maximum Life per second"]={{[1]={flags=0,keywordFlags=0,name="LifeRegenPercent",type="BASE",value=3}},nil} c["Regenerate 3% of maximum Life per second while on Low Life"]={{[1]={[1]={type="Condition",var="LowLife"},flags=0,keywordFlags=0,name="LifeRegenPercent",type="BASE",value=3}},nil} -c["Regenerate 5 Rage per second"]={{[1]={flags=0,keywordFlags=0,name="RageRegen",type="BASE",value=5}},nil} +c["Regenerate 5 Rage per second"]={{[1]={flags=0,keywordFlags=0,name="RageRegen",type="BASE",value=5},[2]={flags=0,keywordFlags=0,name="Condition:CanGainRage",type="FLAG",value=true}},nil} c["Regenerate 5% of maximum Life over 1 second when Stunned"]={nil,"Regenerate 5% of maximum Life over 1 second when Stunned "} c["Regenerate 5% of maximum Life per second while Surrounded"]={{[1]={[1]={type="Condition",var="Surrounded"},flags=0,keywordFlags=0,name="LifeRegenPercent",type="BASE",value=5}},nil} c["Regenerate 6% of your maximum Rage per second"]={{[1]={flags=0,keywordFlags=0,name="RageRegenPercent",type="BASE",value=6}},nil} diff --git a/src/Data/Skills/act_str.lua b/src/Data/Skills/act_str.lua index 17e9f06d3..7e566deb6 100644 --- a/src/Data/Skills/act_str.lua +++ b/src/Data/Skills/act_str.lua @@ -4732,6 +4732,13 @@ skills["EternalRagePlayer"] = { label = "Eternal Rage", incrementalEffectiveness = 0.054999999701977, statDescriptionScope = "eternal_rage", + statMap = { + ["ceaseless_rage_base_rage_regeneration_per_minute"] = { + mod("RageRegen", "BASE", nil, 0, 0, {type = "GlobalEffect", effectType = "Buff", effectName = "EternalRage"}), + flag("Condition:CanGainRage", { type = "GlobalEffect", effectType = "Buff", effectName = "Rage" }), + div = 60, + }, + }, baseFlags = { }, stats = { diff --git a/src/Export/Skills/act_str.txt b/src/Export/Skills/act_str.txt index 6137bfb21..19a16de49 100644 --- a/src/Export/Skills/act_str.txt +++ b/src/Export/Skills/act_str.txt @@ -332,6 +332,13 @@ statMap = { #skill EternalRagePlayer #set EternalRagePlayer #flags +statMap = { + ["ceaseless_rage_base_rage_regeneration_per_minute"] = { + mod("RageRegen", "BASE", nil, 0, 0, {type = "GlobalEffect", effectType = "Buff", effectName = "EternalRage"}), + flag("Condition:CanGainRage", { type = "GlobalEffect", effectType = "Buff", effectName = "Rage" }), + div = 60, + }, +}, #mods #skillEnd diff --git a/src/Modules/ModParser.lua b/src/Modules/ModParser.lua index 8c6d5b291..9f18a9d30 100644 --- a/src/Modules/ModParser.lua +++ b/src/Modules/ModParser.lua @@ -5624,6 +5624,10 @@ local specialModList = { mod("RageRegen", "BASE", num, {type = "PercentStat", stat = "LifeRegen", percent = tonumber(num/div*100) }), flag("Condition:CanGainRage"), } end, + ["regenerate (%d+) rage per second"] = function(num) return { + mod("RageRegen", "BASE", num), + flag("Condition:CanGainRage"), + } end, ["when you lose temporal chains you gain maximum rage"] = { flag("Condition:CanGainRage") }, ["with a murderous eye jewel socketed, melee attacks grant (%d+) rage on hit, no more than once every second"] = { flag("Condition:CanGainRage", { type = "Condition", var = "HaveMurderousEyeJewelIn{SlotName}" }) }, ["gain %d+ rage after spending a total of %d+ mana"] = { flag("Condition:CanGainRage") }, From 48ba411eb76aacd5e1a061965b5798c5eb8a8430 Mon Sep 17 00:00:00 2001 From: Tarik <50704992+TarikBeentjes61@users.noreply.github.com> Date: Tue, 27 Jan 2026 10:54:02 +0100 Subject: [PATCH 2/2] Better formatting --- src/Data/Skills/act_str.lua | 2 +- src/Export/Skills/act_str.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Data/Skills/act_str.lua b/src/Data/Skills/act_str.lua index 7e566deb6..cb5dfb397 100644 --- a/src/Data/Skills/act_str.lua +++ b/src/Data/Skills/act_str.lua @@ -4734,7 +4734,7 @@ skills["EternalRagePlayer"] = { statDescriptionScope = "eternal_rage", statMap = { ["ceaseless_rage_base_rage_regeneration_per_minute"] = { - mod("RageRegen", "BASE", nil, 0, 0, {type = "GlobalEffect", effectType = "Buff", effectName = "EternalRage"}), + mod("RageRegen", "BASE", nil, 0, 0, { type = "GlobalEffect", effectType = "Buff", effectName = "EternalRage" }), flag("Condition:CanGainRage", { type = "GlobalEffect", effectType = "Buff", effectName = "Rage" }), div = 60, }, diff --git a/src/Export/Skills/act_str.txt b/src/Export/Skills/act_str.txt index 19a16de49..3d78cc76f 100644 --- a/src/Export/Skills/act_str.txt +++ b/src/Export/Skills/act_str.txt @@ -334,7 +334,7 @@ statMap = { #flags statMap = { ["ceaseless_rage_base_rage_regeneration_per_minute"] = { - mod("RageRegen", "BASE", nil, 0, 0, {type = "GlobalEffect", effectType = "Buff", effectName = "EternalRage"}), + mod("RageRegen", "BASE", nil, 0, 0, { type = "GlobalEffect", effectType = "Buff", effectName = "EternalRage" }), flag("Condition:CanGainRage", { type = "GlobalEffect", effectType = "Buff", effectName = "Rage" }), div = 60, },