Add support for bleed and poison chance on critical hit calculation (#1058)

* Add support for crit-dependent bleed and poison chance calculation

* Use copyTable for temporary critCfg to avoid unitended changes to the original

---------

Co-authored-by: majochem <[email protected]>

Author: majochem

src/Modules/CalcOffence.lua

@@ -4603,12 +4603,15 @@ function calcs.offence(env, actor, activeSkill)
 				output[flatAilment.."ChanceOnCrit"] = 0
 				skillFlags["inflict"..flatAilment] = false
 			else
-				local base = skillModList:Sum("BASE", cfg, flatAilment.."Chance", "AilmentChance") + enemyDB:Sum("BASE", nil, "Self"..flatAilment.."Chance")
-				local inc = skillModList:Sum("INC", cfg, flatAilment.."Chance", "AilmentChance")
-				local more = skillModList:More(cfg, flatAilment.."Chance", "AilmentChance")
-				local chance = m_min(100, base * (1 + inc / 100) * more)
-				output[flatAilment.."ChanceOnHit"] = chance
-				output[flatAilment.."ChanceOnCrit"] = chance
+				for _, val in pairs({"OnHit", "OnCrit"}) do
+					local critCfg = copyTable(cfg,true)
+					critCfg.skillCond.CriticalStrike = val == "OnCrit" -- force crit config to be true for "OnCrit" chance calculation
+					local base = skillModList:Sum("BASE", critCfg, flatAilment.."Chance", "AilmentChance") + enemyDB:Sum("BASE", nil, "Self"..flatAilment.."Chance")
+					local inc = skillModList:Sum("INC", critCfg, flatAilment.."Chance", "AilmentChance")
+					local more = skillModList:More(critCfg, flatAilment.."Chance", "AilmentChance")
+					local chance = m_min(100, skillModList:Override(critCfg, flatAilment .. "Chance") or (base * (1 + inc / 100) * more))
+					output[flatAilment.."Chance" .. val] = chance
+				end
 				skillFlags["inflict"..flatAilment] = true
 			end
 		end