Catch unhandled exceptions from other threads (#2771)

Co-authored-by: codefactor-io <[email protected]>

Author: IhateTrains

ImperatorToCK3/Program.cs

@@ -1,18 +1,18 @@
-using commonItems;
+using commonItems;
 using ImperatorToCK3.Exceptions;
 using log4net.Core;
 using System;
 using System.Globalization;
 using System.Linq;
+using System.Threading.Tasks;
 
 namespace ImperatorToCK3;
 public static class Program {
 	public static int Main(string[] args) {
+		RegisterGlobalExceptionHandlers();
+		
 		try {
-			CultureInfo.CurrentCulture = CultureInfo.InvariantCulture;
-			CultureInfo.CurrentUICulture = CultureInfo.InvariantCulture;
-			CultureInfo.DefaultThreadCurrentCulture = CultureInfo.InvariantCulture;
-			CultureInfo.DefaultThreadCurrentUICulture = CultureInfo.InvariantCulture;
+			SetInvariantCulture();
 
 			var converterVersion = new ConverterVersion();
 			converterVersion.LoadVersion("configurables/version.txt");
@@ -28,7 +28,7 @@ public static int Main(string[] args) {
 			if (ex is AggregateException aggregateEx) {
 				ex = aggregateEx.Flatten().InnerExceptions.FirstOrDefault() ?? ex;
 			}
-			
+
 			Logger.Log(Level.Fatal, ex is UserErrorException ? ex.Message : $"{ex.GetType()}: {ex.Message}");
 			if (ex.StackTrace is not null) {
 				Logger.Debug(ex.StackTrace);
@@ -41,4 +41,44 @@ public static int Main(string[] args) {
 			return -1;
 		}
 	}
+
+	private static void RegisterGlobalExceptionHandlers() {
+		// Catch any unhandled exceptions from other threads.
+		AppDomain.CurrentDomain.UnhandledException += (sender, eventArgs) => {
+			if (eventArgs.ExceptionObject is Exception ex) {
+				// If the exception is an AggregateException, we want the original inner exception's stack trace.
+				if (ex is AggregateException aggregateEx) {
+					ex = aggregateEx.Flatten().InnerExceptions.FirstOrDefault() ?? ex;
+				}
+
+				Logger.Log(Level.Fatal, ex is UserErrorException ? ex.Message : $"{ex.GetType()}: {ex.Message}");
+				if (ex.StackTrace is not null) {
+					Logger.Debug(ex.StackTrace);
+				}
+			} else {
+				Logger.Log(Level.Fatal, "An unhandled exception occurred, but it could not be identified.");
+			}
+			Environment.Exit(-1); // Ensure the process exits with a non-zero code.
+		};
+		TaskScheduler.UnobservedTaskException += (sender, eventArgs) => {
+			Exception ex = eventArgs.Exception;
+			// If the exception is an AggregateException, we want the original inner exception's stack trace.
+			if (ex is AggregateException aggregateEx) {
+				ex = aggregateEx.Flatten().InnerExceptions.FirstOrDefault() ?? ex;
+			}
+
+			Logger.Log(Level.Fatal, ex is UserErrorException ? ex.Message : $"{ex.GetType()}: {ex.Message}");
+			if (ex.StackTrace is not null) {
+				Logger.Debug(ex.StackTrace);
+			}
+			Environment.Exit(-1); // Ensure the process exits with a non-zero code.
+		};
+	}
+
+	private static void SetInvariantCulture() {
+		CultureInfo.CurrentCulture = CultureInfo.InvariantCulture;
+		CultureInfo.CurrentUICulture = CultureInfo.InvariantCulture;
+		CultureInfo.DefaultThreadCurrentCulture = CultureInfo.InvariantCulture;
+		CultureInfo.DefaultThreadCurrentUICulture = CultureInfo.InvariantCulture;
+	}
 }