Bump PGCG.commonItems from 15.3.0 to 16.0.0 (#2774)

Updated
[PGCG.commonItems](https://github.com/ParadoxGameConverters/commonItems.NET)
from 15.3.0 to 16.0.0.

<details>
<summary>Release notes</summary>

_Sourced from [PGCG.commonItems's
releases](https://github.com/ParadoxGameConverters/commonItems.NET/releases)._

No release notes found for this version range.

Commits viewable in [compare
view](https://github.com/ParadoxGameConverters/commonItems.NET/commits).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=PGCG.commonItems&package-manager=nuget&previous-version=15.3.0&new-version=16.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: iht <[email protected]>

Author: dependabot[bot]

ImperatorToCK3/CK3/Characters/Character.cs

@@ -85,7 +85,7 @@ public uint GetAge(Date date) {
 		if (deathDate is null) {
 			return (uint)date.DiffInYears(birthDate);
 		}
-		return (uint)deathDate.DiffInYears(birthDate);
+		return (uint)deathDate.Value.DiffInYears(birthDate);
 	}
 	public string GetAgeSex(Date date) {
 		if (GetAge(date) >= 16) {
@@ -106,7 +106,10 @@ public Date BirthDate {
 	public Date? DeathDate {
 		get {
 			var entriesDict = History.Fields["death"].DateToEntriesDict;
-			return entriesDict.Count == 0 ? null : entriesDict.AsValueEnumerable().First().Key;
+			if (entriesDict.Count == 0) {
+				return null;
+			}
+			return entriesDict.AsValueEnumerable().First().Key;
 		}
 		set {
 			var historyField = History.Fields["death"];
@@ -317,7 +320,7 @@ Configuration config
 			}
 		}
 
-		BirthDate = preImperatorRuler.BirthDate!;
+		BirthDate = preImperatorRuler.BirthDate!.Value;
 		DeathDate = preImperatorRuler.DeathDate!;
 
 		// determine culture and religion

ImperatorToCK3/CK3/Characters/CharacterCollection.cs

@@ -266,15 +266,15 @@ Date GetEstimatedMarriageDate(Imperator.Characters.Character imperatorCharacter,
 			var birthDateOfCommonChild = GetBirthDateOfFirstCommonChild(imperatorCharacter, imperatorSpouse);
 			if (birthDateOfCommonChild is not null) {
 				// We assume the child was conceived after marriage.
-				var estimatedConceptionDate = birthDateOfCommonChild.ChangeByDays(-280);
+				var estimatedConceptionDate = birthDateOfCommonChild.Value.ChangeByDays(-280);
 				if (marriageDeathDate is not null && marriageDeathDate < estimatedConceptionDate) {
-					estimatedConceptionDate = marriageDeathDate.ChangeByDays(-1);
+					estimatedConceptionDate = marriageDeathDate.Value.ChangeByDays(-1);
 				}
 				return estimatedConceptionDate;
 			}
 
 			if (marriageDeathDate is not null) {
-				return marriageDeathDate.ChangeByDays(-1); // Death is not a good moment to marry.
+				return marriageDeathDate.Value.ChangeByDays(-1); // Death is not a good moment to marry.
 			}
 
 			return conversionDate;

ImperatorToCK3/CK3/Titles/Title.cs

@@ -787,8 +787,8 @@ public void LoadTitles(BufferedReader reader, ColorFactory colorFactory) {
 	public Date GetDateOfLastHolderChange() {
 		var field = History.Fields["holder"];
 		var dates = new SortedSet<Date>(field.DateToEntriesDict.Keys);
-		var lastDate = dates.Max;
-		return lastDate ?? new Date(1, 1, 1);
+
+		return dates.Count > 0 ? dates.Max : new Date(1, 1, 1);
 	}
 
 	public HashSet<string> GetAllHolderIds() {

ImperatorToCK3/CommonUtils/DiffHistoryField.cs

@@ -67,12 +67,10 @@ public void AddEntryToHistory(Date? date, string keyword, object value) {
 			if (date is null) {
 				InitialEntries.Add(newEntry);
 			} else {
-				if (DateToEntriesDict.TryGetValue(date, out var entriesList)) {
+				if (DateToEntriesDict.TryGetValue(date.Value, out var entriesList)) {
 					entriesList.Add(newEntry);
 				} else {
-					DateToEntriesDict.Add(date, new List<KeyValuePair<string, object>> {
-						newEntry
-					});
+					DateToEntriesDict.Add(date.Value, [newEntry]);
 				}
 			}
 		} else {

ImperatorToCK3/CommonUtils/LiteralHistoryField.cs

@@ -56,13 +56,11 @@ public void AddEntryToHistory(Date? date, string setter, object value) {
 		if (date is null) {
 			InitialEntries.Add(new KeyValuePair<string, object>(setter, value));
 		} else {
-			if (DateToEntriesDict.TryGetValue(date, out var entriesList)) {
+			if (DateToEntriesDict.TryGetValue(date.Value, out var entriesList)) {
 				entriesList.Add(new KeyValuePair<string, object>(setter, value));
 			}
 			else {
-				DateToEntriesDict[date] = new List<KeyValuePair<string, object>> {
-					new(setter, value)
-				};
+				DateToEntriesDict[date.Value] = [new(setter, value)];
 			}
 		}
 	}

ImperatorToCK3/CommonUtils/SimpleHistoryField.cs

@@ -55,7 +55,7 @@ public void AddEntryToHistory(Date? date, string setter, object value) {
 		if (date is null) {
 			InitialEntries.Add(new KeyValuePair<string, object>(setter, value));
 		} else {
-			DateToEntriesDict[date] = [
+			DateToEntriesDict[date.Value] = [
 				new(setter, value),
 			];
 		}

ImperatorToCK3/Imperator/Characters/Unborn.cs

@@ -34,6 +34,6 @@ public Unborn(ulong motherId, ulong fatherId, Date birthDate, bool isBastard) {
 			return null;
 		}
 
-		return new Unborn((ulong)motherId, (ulong)fatherId, birthDate, isBastard);
+		return new Unborn((ulong)motherId, (ulong)fatherId, birthDate.Value, isBastard);
 	}
 }

ImperatorToCK3/ImperatorToCK3.csproj

@@ -44,7 +44,7 @@
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>
         <PackageReference Include="MurmurHash.NETStandard" Version="1.0.0" />
-        <PackageReference Include="PGCG.commonItems" Version="15.3.0" />
+        <PackageReference Include="PGCG.commonItems" Version="16.0.0" />
         <PackageReference Include="PGCG.commonItems.SourceGenerators" Version="1.0.9" />
         <PackageReference Include="Polly" Version="8.6.4" />
         <PackageReference Include="Roslynator.Analyzers" Version="4.14.1">

ImperatorToCK3/Outputter/CharacterOutputter.cs

@@ -32,7 +32,7 @@ public static void WriteCharacter(StringBuilder sb, Character character, Date co
 			Date goldDate = ck3BookmarkDate;
 			var deathDate = character.DeathDate;
 			if (deathDate is not null && deathDate < ck3BookmarkDate) {
-				goldDate = deathDate;
+				goldDate = deathDate.Value;
 			}
 			character.History.AddFieldValue(goldDate, "effects", "effect", effectStr);
 		}