fixed SAM and Whitestar errors

Author: mkalkbrenner

src/dmd_interface_sam.pio

@@ -8,14 +8,16 @@
 
 .program dmd_reader_sam
 
-; Send using an external clock on the SPI interface
-; - IN pin 0 is the DATA pin
 
-    ; initialize y with 16348 = number of pixels (128x32x4)
-    set x, 1
-    in x, 1
-    in null, 15
-    mov y, isr
+    ; initialize y with 16383, number of pixels (128x32x4) - 1 because counting starts at 0.
+    set x, 31          ; x = 31 (max 5-bit value)
+    in x, 5            ; shift in 5 bits, isr = 31
+    set x, 31          ; x = 31
+    in x, 5            ; shift in 5 bits, isr = 1023
+    set x, 15          ; x = 15
+    in x, 4            ; shift in 4 bits, isr = 16383
+    in null, 2         ; pad with 2 zeros
+    mov y, isr         ; y = 16383
 
 .wrap_target
 
@@ -25,13 +27,13 @@
     irq clear 4
     wait irq 4
 
+    wait 1 gpio RDATA   ; raising edge indicates a new frame
+
 dotloop:
     wait 0 gpio DOTCLK  ; falling edge
-    in null, 3          ; pad with 3 zeros
+    in null, 3          ; left padding with 3 zeros
     wait 1 gpio DOTCLK  ; raising edge
     in pins 1           ; read pin data
-
-
     jmp x-- dotloop
 
 .wrap
@@ -40,7 +42,7 @@ dotloop:
 
 .wrap_target
 
-; synchronize on the least significant plane
+; synchronize on a new frame
     wait 0 gpio RDATA
     wait 1 gpio RDATA
     irq 4
@@ -55,13 +57,15 @@ static inline void dmd_reader_sam_program_init(PIO pio, uint sm, uint offset) {
     // Set the IN pin, we don't use any other
     sm_config_set_in_pins(&c, 2); // SDATA
 
+    // Set the pin direction at the PIO
+    pio_sm_set_consecutive_pindirs(pio, sm, 6, 1, false); // RDATA
+    pio_sm_set_consecutive_pindirs(pio, sm, 2, 2, false); // SDATA, DOTCLK
+
     // Connect these GPIOs to this PIO block
+    pio_gpio_init(pio, 6); // RDATA
     pio_gpio_init(pio, 3); // DOTCLK
     pio_gpio_init(pio, 2); // SDATA
 
-    // Set the pin direction at the PIO
-    pio_sm_set_consecutive_pindirs(pio, sm, 2, 2, false); // SDATA, DOTCLK
-
     // Shifting to left matches the customary MSB-first ordering of SPI.
     sm_config_set_in_shift(
         &c,

src/dmd_interface_whitestar.pio

@@ -9,11 +9,15 @@
 .program dmd_reader_whitestar
 
 
-    ; initialize y with 8192 = number of pixels ((128 x LSB + 128 x MSB) x 32)
-    set x, 1
-    in x, 1
-    in null, 13
-    mov y, isr
+    ; initialize y with 8191, number of pixels ((128 x LSB + 128 x MSB) x 32) - 1  because counting starts at 0.
+    set x, 31          ; x = 31 (max 5-bit value)
+    in x, 5            ; shift in 5 bits, isr = 31
+    set x, 31          ; x = 31
+    in x, 5            ; shift in 5 bits, isr = 1023
+    set x, 15          ; x = 15
+    in x, 3            ; shift in 3 bits, isr = 8191
+    in null, 3         ; pad with 3 zeros
+    mov y, isr         ; y = 8191
 
 .wrap_target
 
@@ -93,4 +97,4 @@ static inline void dmd_framedetect_whitestar_program_init(PIO pio, uint sm, uint
     // Load our configuration, do not yet start the program
     pio_sm_init(pio, sm, offset, &c);
 }
-%}
+%}

src/dmd_interface_wpc.pio

@@ -26,7 +26,7 @@
 
 plane_loop:
     wait 0 gpio DOTCLK ; no DOTCLK period or faling edge of the previous
-    in null 1          ; add a 0 to the output as WPC is 2bit/px
+    in null 1          ; left padding a 0 to the output as WPC is 2bit/px
     wait 1 gpio DOTCLK ; raising edge
     in pins 1          ; read 1 bit pin data
     jmp x-- plane_loop