Skip to content

Commit 9c8b5c0

Browse files
committed
Fix workflow trigger for Python package version check
`pull_request_target` runs against the base and doesn't work with paths, so it's wrong. It is more targeted toward protecting workflows from rogue PRs from forks. This isn't an issue for this workflow because it doesn't use any secrets, apart from ephemeral ones generated through OIDC flows, and in any event it's protected from fork runs by the `if` check in `check-python-package-versions.yaml` on line 11.
1 parent 904750d commit 9c8b5c0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/check-python-package-versions.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: Check Python package version numbers
22

33
on:
4-
pull_request_target:
4+
pull_request:
55
paths:
66
- '**/pyproject.toml'
77
- 'packages/**/__about__.py'

0 commit comments

Comments
 (0)