Skip to content

Improve CSV parsing in load_ocp_keyword_from_csv method #367

@coderabbitai

Description

@coderabbitai

Description

The current implementation of load_ocp_keyword_from_csv method in ovos_workshop/skills/common_play.py uses manual CSV parsing which has several limitations:

  • Cannot handle quoted fields or commas within values
  • No error handling for malformed lines
  • Uses ambiguous variable name

Suggested Improvement

Replace the manual CSV parsing with Python's built-in csv module for robust CSV handling with proper error handling and support for quoted fields.

Context

This issue was identified during code review of PR #365.

Related Links:

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions