MissingSamlUserInfoError thrown when remote/x509 header is present

[honza801]

Description
Fix logic that raised MissingSamlUserInfoError during remote/x509 authentication even when the remote header existed. Now the code only throws MissingSamlUserInfoError if neither SAML nor remote/x509 auth info is available; MissingHeaderError remains for the case where remote auth is configured but the header is missing.

To Reproduce

• configure auth: remote
• dont use SAML at all
• apache configuration:

AuthType <any>
Require valid-user
RewriteRule .* - [E=X_REMOTE_USER:%{REMOTE_USER}]
RequestHeader set x_auth_username %{X_REMOTE_USER}e
ProxyPass / http://127.0.0.1:2616/

Login fails with MissingSamlUserInfoError exception.

fireedge.log:

[error] MissingSamlUserInfoError: Missing user Saml information:

Expected behavior
No SAML informations are checked, user is logged in normally.

Details

• Affected Component: fireedge
• Version: 7.0.1

Additional context
This was working correctly on 7.0.0. Was broken by c22c843

Pull request #7328

Progress Status

• Code committed
• Testing - QA
• Documentation (Release notes - resolved issues, compatibility, known issues)