Skip to content

Commit d64a0b4

Browse files
liamhughesOctobob
authored andcommitted
Added support for using GitHub Connections as a Git authentication method in steps and step templates.
+semver: minor GitOrigin-RevId: 209757f7a01895306d8c61a23f03d06b5bf7e60a
1 parent c249fdb commit d64a0b4

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

readme.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,14 @@ Please see the [Octopus.Client](https://octopus.com/docs/api-and-integration/oct
1111

1212
If you believe you have found a problem, or have a suggested enhancement, please raise it with the Octopus [Support Team](https://octopus.com/support)
1313

14-
While this library is licensed under the Apache 2.0 license and you are welcome to fork the it, this repository does not accept GitHub issues or Pull Requests. For more information please see the Octopus Deploy Blog: [Changes to the Octopus C# client library open source repository](https://octopus.com/blog/changes-to-octopus-csharp-client-repository)
14+
While this library is licensed under the Apache 2.0 license, and you are welcome to fork it, this repository does not accept GitHub issues or Pull Requests. For more information please see the Octopus Deploy Blog: [Changes to the Octopus C# client library open source repository](https://octopus.com/blog/changes-to-octopus-csharp-client-repository)
1515

1616
## Versioning
1717
We use [Semantic Versioning](http://semver.org/) for our open source libraries and tools. This breaks with our older practice of keeping version numbers in sync with Octopus Server.
1818

19-
Within a major version of `Octopus.Client` we will maintain backwards compatibility to a set version of Octopus Server, allowing worry free minor and patch upgrades.
19+
Within a major version of `Octopus.Client` we will maintain backwards compatibility to a set version of Octopus Server, allowing worry-free minor and patch upgrades.
2020

21-
Conversely we also maintain backwards compatibility in our Server API as much as possible while still being able to add new features. This means that an older version of `Octopus.Client` will work with newer versions of Octopus Server.
21+
Conversely, we also maintain backwards compatibility in our Server API as much as possible while still being able to add new features. This means that an older version of `Octopus.Client` will work with newer versions of Octopus Server.
2222

2323
## Compatibility
2424

source/Octopus.Client.Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETCore.approved.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3331,7 +3331,7 @@ Octopus.Client.Model
33313331
}
33323332
class GitDependencyResource
33333333
{
3334-
.ctor(String, String, String, String, String[], String, String)
3334+
.ctor(String, String, String, String, String[], String, String, String)
33353335
String DefaultBranch { get; }
33363336
String[] FilePathFilters { get; }
33373337
String GitCredentialId { get; }

source/Octopus.Server.Client/Model/GitDependencyResource.cs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,15 @@ public GitDependencyResource(
1515
string? gitCredentialId = null,
1616
string[]? filePathFilters = null,
1717
string? name = null,
18-
string? stepPackageInputsReferenceId = null)
18+
string? stepPackageInputsReferenceId = null,
19+
string? gitHubConnectionId = null
20+
)
1921
{
2022
RepositoryUri = repositoryUri;
2123
DefaultBranch = defaultBranch;
2224
GitCredentialType = gitCredentialType;
2325
GitCredentialId = gitCredentialId;
26+
GitHubConnectionId = gitHubConnectionId;
2427
FilePathFilters = filePathFilters ?? Array.Empty<string>();
2528
Name = name ?? string.Empty;
2629
StepPackageInputsReferenceId = stepPackageInputsReferenceId;
@@ -34,4 +37,4 @@ public GitDependencyResource(
3437
public string? GitCredentialId { get; }
3538
public string? GitHubConnectionId { get; }
3639
public string? StepPackageInputsReferenceId { get; set; }
37-
}
40+
}

0 commit comments

Comments
 (0)