Skip to content

Commit 3fffcb9

Browse files
committed
Preserve supplied oracle temp schema in SqlRenderService
1 parent b22d7bf commit 3fffcb9

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

src/main/java/org/ohdsi/webapi/service/SqlRenderService.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,9 @@ public TranslatedStatement translateSQLFromSourceStatement(SourceStatement sourc
3636
if (sourceStatement == null) {
3737
return new TranslatedStatement();
3838
}
39-
sourceStatement.setOracleTempSchema(TEMP_DATABASE_SCHEMA_PLACEHOLDER);
39+
if (StringUtils.isBlank(sourceStatement.getOracleTempSchema())) {
40+
sourceStatement.setOracleTempSchema(TEMP_DATABASE_SCHEMA_PLACEHOLDER);
41+
}
4042
return translatedStatement(sourceStatement);
4143
}
4244

src/test/java/org/ohdsi/webapi/service/SqlRenderServiceTest.java

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,17 @@ public void translateSQLFromSourceStatement() {
3939
assertEquals(TEMP_DATABASE_SCHEMA_PLACEHOLDER, sourceStatementCaptor.getValue().getOracleTempSchema());
4040
}
4141

42+
@Test
43+
public void translateSQLFromSourceStatement_keepsProvidedOracleTempSchema() {
44+
45+
SourceStatement statement = createSourceStatement(TEST_SQL, "oracle");
46+
statement.setOracleTempSchema("custom_schema");
47+
sqlRenderService.translateSQLFromSourceStatement(statement);
48+
49+
verify(sqlRenderService).translatedStatement(sourceStatementCaptor.capture());
50+
assertEquals("custom_schema", sourceStatementCaptor.getValue().getOracleTempSchema());
51+
}
52+
4253
@Test
4354
public void translateSQL_sourceStatementIsNull() {
4455
assertEquals(new TranslatedStatement(), SqlRenderService.translateSQL(null));
@@ -71,4 +82,4 @@ private SourceStatement createSourceStatement(String testExpression, String dial
7182
statement.getParameters().putAll(Collections.emptyMap());
7283
return statement;
7384
}
74-
}
85+
}

0 commit comments

Comments
 (0)