base_tier_validation: tier definition 'sequence' is used as a priority

[gurneyalex]

When using base_tier_definition, there is a field called "sequence" which can be used to request validations in a specific order.

When I see such a field, I expect the records to be processed by increasing sequence (so sequence = 10 is before sequence = 20). However the sorting in the code is done by decreasing sequence, which is super confusing for end users. Changing the sorting would likely break all instances using the feature; so not a great move. We should at least get a clear explanation in the UI.

[LoisRForgeFlow]

Hi @gurneyalex

Yep, it is an issue that has been generated at the very beggining and never fixed. There has been other attemps to fix this, see for instance #1034

I actually think that we should use "sequence asc" as it is expected, the problem is that we need to do it at some point, add migrations scripts and propoerly warn of the change, so likely something to do only in v18. I do not see a non-painful way of fixing this...

Thoughts?

[gurneyalex]

@LoisRForgeFlow a path for this could be to:

• rename the current sequence field to something like importance (which conveys the "higher is better"), have a migration script for this
• re-add a sequence field and make it computed, stored, with a formula such as rec.sequence = 1000 - rec.importance

[maisim]

@gurneyalex @LoisRForgeFlow
Yes, this is a problem for understanding. When we create the validations steps, we need to define sequences in descending order, and at "execution," the sequences are displayed in ascending order. It's a bit confusing.
Since I'm still on 16 for a while, I'm in favor of fixing this with a script that corrects it when the module is installed.
Perhaps by temporarily adding a sequence_order_fix_applied field somewhere?

If we agree on how to proceed, I can take care of it.