[FIX] server_environment_ir_config_parameter: Don't save values in DB

Author: rven

server_environment_ir_config_parameter/models/ir_config_parameter.py

@@ -34,42 +34,7 @@ def get_param(self, key, default=False):
                     _("Key %s is empty in " "server_environment_file") % (key,)
                 )
             if cvalue != value:
-                # we write in db on first access;
-                # should we have preloaded values in database at,
-                # server startup, modules loading their parameters
-                # from data files would break on unique key error.
-                if not self.env.context.get("_from_get_param", 0):
-                    # the check is to avoid recursion, for instance the mail
-                    # addon has an override in ir.config_parameter::write which
-                    # calls get_param if we are setting mail.catchall.alias and
-                    # this will cause an infinite recursion. We cut that
-                    # recursion by using the context check.
-                    #
-                    # The mail addon call to get_param expects to get the value
-                    # *before* the change, so we have to return the database
-                    # value in that case
-                    self.sudo().with_context(_from_get_param=1).set_param(key, cvalue)
-                    value = cvalue
+                value = cvalue
         if value is None:
             return default
         return value
-
-    @api.model_create_multi
-    def create(self, vals_list):
-        for vals in vals_list:
-            key = vals.get("key")
-            if key and serv_config.has_option(SECTION, key):
-                # enforce value from config file
-                vals.update(value=serv_config.get(SECTION, key))
-        return super().create(vals_list)
-
-    def write(self, vals):
-        for rec in self:
-            key = vals.get("key", rec.key)
-            if serv_config.has_option(SECTION, key):
-                # enforce value from config file
-                newvals = dict(vals, value=serv_config.get(SECTION, key))
-            else:
-                newvals = vals
-            super(IrConfigParameter, rec).write(newvals)
-        return True