From cb1bc423f0a31fb19610b3045344ebf4bc8ae3b8 Mon Sep 17 00:00:00 2001 From: georgiedekker Date: Mon, 11 Aug 2025 10:00:22 +0200 Subject: [PATCH 1/6] [MIG] stock_production_lot_warranty: Migration to 18.0 --- stock_production_lot_warranty/README.rst | 126 +++++ stock_production_lot_warranty/__init__.py | 3 + stock_production_lot_warranty/__manifest__.py | 18 + stock_production_lot_warranty/i18n/pt.po | 27 + stock_production_lot_warranty/i18n/pt_BR.po | 27 + .../i18n/stock_production_lot_warranty.pot | 24 + .../models/__init__.py | 2 + .../models/stock_production_lot.py | 31 ++ stock_production_lot_warranty/pyproject.toml | 3 + .../readme/CONFIGURE.md | 8 + .../readme/CONTRIBUTORS.md | 3 + .../readme/CREDITS.md | 4 + .../readme/DESCRIPTION.md | 5 + stock_production_lot_warranty/readme/USAGE.md | 7 + .../static/description/icon.png | Bin 0 -> 9455 bytes .../static/description/index.html | 466 ++++++++++++++++++ .../tests/__init__.py | 4 + .../tests/test_product_lot_warranty.py | 82 +++ .../views/stock_production_lot.xml | 14 + 19 files changed, 854 insertions(+) create mode 100644 stock_production_lot_warranty/README.rst create mode 100644 stock_production_lot_warranty/__init__.py create mode 100644 stock_production_lot_warranty/__manifest__.py create mode 100644 stock_production_lot_warranty/i18n/pt.po create mode 100644 stock_production_lot_warranty/i18n/pt_BR.po create mode 100644 stock_production_lot_warranty/i18n/stock_production_lot_warranty.pot create mode 100644 stock_production_lot_warranty/models/__init__.py create mode 100644 stock_production_lot_warranty/models/stock_production_lot.py create mode 100644 stock_production_lot_warranty/pyproject.toml create mode 100644 stock_production_lot_warranty/readme/CONFIGURE.md create mode 100644 stock_production_lot_warranty/readme/CONTRIBUTORS.md create mode 100644 stock_production_lot_warranty/readme/CREDITS.md create mode 100644 stock_production_lot_warranty/readme/DESCRIPTION.md create mode 100644 stock_production_lot_warranty/readme/USAGE.md create mode 100644 stock_production_lot_warranty/static/description/icon.png create mode 100644 stock_production_lot_warranty/static/description/index.html create mode 100644 stock_production_lot_warranty/tests/__init__.py create mode 100644 stock_production_lot_warranty/tests/test_product_lot_warranty.py create mode 100644 stock_production_lot_warranty/views/stock_production_lot.xml diff --git a/stock_production_lot_warranty/README.rst b/stock_production_lot_warranty/README.rst new file mode 100644 index 000000000..7e831f20a --- /dev/null +++ b/stock_production_lot_warranty/README.rst @@ -0,0 +1,126 @@ +=================================== +Warranty Date on Lot/Serial Numbers +=================================== + +.. + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! This file is generated by oca-gen-addon-readme !! + !! changes will be overwritten. !! + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! source digest: sha256:d6965242ba21cd047683380ad7586c6f7e079d0d79f794726198d318c6a5fe08 + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + +.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png + :target: https://odoo-community.org/page/development-status + :alt: Beta +.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png + :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html + :alt: License: AGPL-3 +.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Frma-lightgray.png?logo=github + :target: https://github.com/OCA/rma/tree/18.0/stock_production_lot_warranty + :alt: OCA/rma +.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png + :target: https://translation.odoo-community.org/projects/rma-18-0/rma-18-0-stock_production_lot_warranty + :alt: Translate me on Weblate +.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png + :target: https://runboat.odoo-community.org/builds?repo=OCA/rma&target_branch=18.0 + :alt: Try me on Runboat + +|badge1| |badge2| |badge3| |badge4| |badge5| + +Odoo does not provide the warranty information on the serial number of a +product. + +This module allows you to compute the warranty expiration date of a +serialized product based on the warranty duration. + +**Table of contents** + +.. contents:: + :local: + +Configuration +============= + +To configure this module: + +- Go to Inventory > Configuration > Settings +- Activate the traceability +- Go to Inventory > Products > Products +- Create or select a product and set the warranty +- Go to the Inventory tab in the Logistics section +- Set the warranty duration + +Usage +===== + +To use this module, + +- Go to Inventory > Products > Lot/Serial Numbers +- Create a new serial number and select a product +- The Warranty Expiration Date is automatically computed based on today + + the warranty duration from the select product +- You can overwrite the computed date with your own value. + +Bug Tracker +=========== + +Bugs are tracked on `GitHub Issues `_. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us to smash it by providing a detailed and welcomed +`feedback `_. + +Do not contact contributors directly about support or help with technical issues. + +Credits +======= + +Authors +------- + +* Open Source Integrators + +Contributors +------------ + +- Steve Campbell +- Maxime Chambreuil +- Serpent Consulting Services Pvt. Ltd. + +Other credits +------------- + +This module has been financially supported by: + +- Pavlov Media + <`https://www.pavlovmedia.com\\> >`__ +- Open Source Integrators + <`https://www.opensourceintegrators.com\\> >`__ + +Maintainers +----------- + +This module is maintained by the OCA. + +.. image:: https://odoo-community.org/logo.png + :alt: Odoo Community Association + :target: https://odoo-community.org + +OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use. + +.. |maintainer-osi-scampbell| image:: https://github.com/osi-scampbell.png?size=40px + :target: https://github.com/osi-scampbell + :alt: osi-scampbell +.. |maintainer-max3903| image:: https://github.com/max3903.png?size=40px + :target: https://github.com/max3903 + :alt: max3903 + +Current `maintainers `__: + +|maintainer-osi-scampbell| |maintainer-max3903| + +This module is part of the `OCA/rma `_ project on GitHub. + +You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. diff --git a/stock_production_lot_warranty/__init__.py b/stock_production_lot_warranty/__init__.py new file mode 100644 index 000000000..69f7babdf --- /dev/null +++ b/stock_production_lot_warranty/__init__.py @@ -0,0 +1,3 @@ +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). + +from . import models diff --git a/stock_production_lot_warranty/__manifest__.py b/stock_production_lot_warranty/__manifest__.py new file mode 100644 index 000000000..ada04ddd4 --- /dev/null +++ b/stock_production_lot_warranty/__manifest__.py @@ -0,0 +1,18 @@ +# Copyright (C) 2018 - TODAY, Open Source Integrators +# Copyright (C) 2021 Serpent Consulting Services +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). + +{ + "name": "Warranty Date on Lot/Serial Numbers", + "summary": "Add warranty date to stock production lot", + "version": "18.0.1.0.0", + "license": "AGPL-3", + "author": "Open Source Integrators, Odoo Community Association (OCA)", + "category": "Stock", + "website": "https://github.com/OCA/rma", + "depends": ["product_warranty", "stock"], + "data": ["views/stock_production_lot.xml"], + "installable": True, + "development_status": "Beta", + "maintainers": ["osi-scampbell", "max3903"], +} diff --git a/stock_production_lot_warranty/i18n/pt.po b/stock_production_lot_warranty/i18n/pt.po new file mode 100644 index 000000000..995298183 --- /dev/null +++ b/stock_production_lot_warranty/i18n/pt.po @@ -0,0 +1,27 @@ +# Translation of Odoo Server. +# This file contains the translation of the following modules: +# * stock_production_lot_warranty +# +msgid "" +msgstr "" +"Project-Id-Version: Odoo Server 14.0\n" +"Report-Msgid-Bugs-To: \n" +"PO-Revision-Date: 2021-03-11 20:45+0000\n" +"Last-Translator: Pedro Castro Silva \n" +"Language-Team: none\n" +"Language: pt\n" +"MIME-Version: 1.0\n" +"Content-Type: text/plain; charset=UTF-8\n" +"Content-Transfer-Encoding: \n" +"Plural-Forms: nplurals=2; plural=n > 1;\n" +"X-Generator: Weblate 4.3.2\n" + +#. module: stock_production_lot_warranty +#: model:ir.model,name:stock_production_lot_warranty.model_stock_production_lot +msgid "Lot/Serial" +msgstr "Lote/Série" + +#. module: stock_production_lot_warranty +#: model:ir.model.fields,field_description:stock_production_lot_warranty.field_stock_production_lot__warranty_exp_date +msgid "Warranty Expiration Date" +msgstr "Data de Expiração da Garantia" diff --git a/stock_production_lot_warranty/i18n/pt_BR.po b/stock_production_lot_warranty/i18n/pt_BR.po new file mode 100644 index 000000000..e10cadd7f --- /dev/null +++ b/stock_production_lot_warranty/i18n/pt_BR.po @@ -0,0 +1,27 @@ +# Translation of Odoo Server. +# This file contains the translation of the following modules: +# * stock_production_lot_warranty +# +msgid "" +msgstr "" +"Project-Id-Version: Odoo Server 14.0\n" +"Report-Msgid-Bugs-To: \n" +"PO-Revision-Date: 2020-07-22 18:19+0000\n" +"Last-Translator: Fernando Colus \n" +"Language-Team: none\n" +"Language: pt_BR\n" +"MIME-Version: 1.0\n" +"Content-Type: text/plain; charset=UTF-8\n" +"Content-Transfer-Encoding: \n" +"Plural-Forms: nplurals=2; plural=n > 1;\n" +"X-Generator: Weblate 3.10\n" + +#. module: stock_production_lot_warranty +#: model:ir.model,name:stock_production_lot_warranty.model_stock_production_lot +msgid "Lot/Serial" +msgstr "Lote/Serial" + +#. module: stock_production_lot_warranty +#: model:ir.model.fields,field_description:stock_production_lot_warranty.field_stock_production_lot__warranty_exp_date +msgid "Warranty Expiration Date" +msgstr "Data de Término da Garantia" diff --git a/stock_production_lot_warranty/i18n/stock_production_lot_warranty.pot b/stock_production_lot_warranty/i18n/stock_production_lot_warranty.pot new file mode 100644 index 000000000..83f1fa456 --- /dev/null +++ b/stock_production_lot_warranty/i18n/stock_production_lot_warranty.pot @@ -0,0 +1,24 @@ +# Translation of Odoo Server. +# This file contains the translation of the following modules: +# * stock_production_lot_warranty +# +msgid "" +msgstr "" +"Project-Id-Version: Odoo Server 15.0\n" +"Report-Msgid-Bugs-To: \n" +"Last-Translator: \n" +"Language-Team: \n" +"MIME-Version: 1.0\n" +"Content-Type: text/plain; charset=UTF-8\n" +"Content-Transfer-Encoding: \n" +"Plural-Forms: \n" + +#. module: stock_production_lot_warranty +#: model:ir.model,name:stock_production_lot_warranty.model_stock_production_lot +msgid "Lot/Serial" +msgstr "" + +#. module: stock_production_lot_warranty +#: model:ir.model.fields,field_description:stock_production_lot_warranty.field_stock_production_lot__warranty_exp_date +msgid "Warranty Expiration Date" +msgstr "" diff --git a/stock_production_lot_warranty/models/__init__.py b/stock_production_lot_warranty/models/__init__.py new file mode 100644 index 000000000..d45f1fe83 --- /dev/null +++ b/stock_production_lot_warranty/models/__init__.py @@ -0,0 +1,2 @@ +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). +from . import stock_production_lot diff --git a/stock_production_lot_warranty/models/stock_production_lot.py b/stock_production_lot_warranty/models/stock_production_lot.py new file mode 100644 index 000000000..1e1262dfe --- /dev/null +++ b/stock_production_lot_warranty/models/stock_production_lot.py @@ -0,0 +1,31 @@ +# Copyright (C) 2018 - TODAY, Open Source Integrators +# Copyright (C) 2021 Serpent Consulting Services +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). + +from dateutil.relativedelta import relativedelta + +from odoo import api, fields, models + +DELTA_TYPES = ("day", "week", "month", "year") + + +class StockProductionLot(models.Model): + _inherit = "stock.production.lot" + + warranty_exp_date = fields.Date(string="Warranty Expiration Date") + + def _get_warranty_exp_date(self, start_date=None): + if not start_date: + start_date = fields.Date.context_today(self) + elif hasattr(start_date, "astimezone"): + # Datetime object, convert to date + start_date = fields.Date.context_today(self, timestamp=start_date) + delta_type = self.product_id.product_tmpl_id.warranty_type + duration = self.product_id.product_tmpl_id.warranty + if not duration or delta_type not in DELTA_TYPES: + return False + return start_date + relativedelta(**{f"{delta_type}s": duration}) + + @api.onchange("product_id") + def _onchange_product_id(self): + self.warranty_exp_date = self._get_warranty_exp_date() diff --git a/stock_production_lot_warranty/pyproject.toml b/stock_production_lot_warranty/pyproject.toml new file mode 100644 index 000000000..4231d0ccc --- /dev/null +++ b/stock_production_lot_warranty/pyproject.toml @@ -0,0 +1,3 @@ +[build-system] +requires = ["whool"] +build-backend = "whool.buildapi" diff --git a/stock_production_lot_warranty/readme/CONFIGURE.md b/stock_production_lot_warranty/readme/CONFIGURE.md new file mode 100644 index 000000000..1c67d3ca7 --- /dev/null +++ b/stock_production_lot_warranty/readme/CONFIGURE.md @@ -0,0 +1,8 @@ +To configure this module: + +- Go to Inventory \> Configuration \> Settings +- Activate the traceability +- Go to Inventory \> Products \> Products +- Create or select a product and set the warranty +- Go to the Inventory tab in the Logistics section +- Set the warranty duration diff --git a/stock_production_lot_warranty/readme/CONTRIBUTORS.md b/stock_production_lot_warranty/readme/CONTRIBUTORS.md new file mode 100644 index 000000000..2270e472a --- /dev/null +++ b/stock_production_lot_warranty/readme/CONTRIBUTORS.md @@ -0,0 +1,3 @@ +- Steve Campbell \ +- Maxime Chambreuil \ +- Serpent Consulting Services Pvt. Ltd. \ diff --git a/stock_production_lot_warranty/readme/CREDITS.md b/stock_production_lot_warranty/readme/CREDITS.md new file mode 100644 index 000000000..066e5e64f --- /dev/null +++ b/stock_production_lot_warranty/readme/CREDITS.md @@ -0,0 +1,4 @@ +This module has been financially supported by: + +- Pavlov Media \ +- Open Source Integrators \ diff --git a/stock_production_lot_warranty/readme/DESCRIPTION.md b/stock_production_lot_warranty/readme/DESCRIPTION.md new file mode 100644 index 000000000..5c5785656 --- /dev/null +++ b/stock_production_lot_warranty/readme/DESCRIPTION.md @@ -0,0 +1,5 @@ +Odoo does not provide the warranty information on the serial number of a +product. + +This module allows you to compute the warranty expiration date of a +serialized product based on the warranty duration. diff --git a/stock_production_lot_warranty/readme/USAGE.md b/stock_production_lot_warranty/readme/USAGE.md new file mode 100644 index 000000000..b9c4f1dc2 --- /dev/null +++ b/stock_production_lot_warranty/readme/USAGE.md @@ -0,0 +1,7 @@ +To use this module, + +- Go to Inventory \> Products \> Lot/Serial Numbers +- Create a new serial number and select a product +- The Warranty Expiration Date is automatically computed based on + today + the warranty duration from the select product +- You can overwrite the computed date with your own value. diff --git a/stock_production_lot_warranty/static/description/icon.png b/stock_production_lot_warranty/static/description/icon.png new file mode 100644 index 0000000000000000000000000000000000000000..3a0328b516c4980e8e44cdb63fd945757ddd132d GIT binary patch literal 9455 zcmW++2RxMjAAjx~&dlBk9S+%}OXg)AGE&Cb*&}d0jUxM@u(PQx^-s)697TX`ehR4?GS^qbkof1cslKgkU)h65qZ9Oc=ml_0temigYLJfnz{IDzUf>bGs4N!v3=Z3jMq&A#7%rM5eQ#dc?k~! zVpnB`o+K7|Al`Q_U;eD$B zfJtP*jH`siUq~{KE)`jP2|#TUEFGRryE2`i0**z#*^6~AI|YzIWy$Cu#CSLW3q=GA z6`?GZymC;dCPk~rBS%eCb`5OLr;RUZ;D`}um=H)BfVIq%7VhiMr)_#G0N#zrNH|__ zc+blN2UAB0=617@>_u;MPHN;P;N#YoE=)R#i$k_`UAA>WWCcEVMh~L_ zj--gtp&|K1#58Yz*AHCTMziU1Jzt_jG0I@qAOHsk$2}yTmVkBp_eHuY$A9)>P6o~I z%aQ?!(GqeQ-Y+b0I(m9pwgi(IIZZzsbMv+9w{PFtd_<_(LA~0H(xz{=FhLB@(1&qHA5EJw1>>=%q2f&^X>IQ{!GJ4e9U z&KlB)z(84HmNgm2hg2C0>WM{E(DdPr+EeU_N@57;PC2&DmGFW_9kP&%?X4}+xWi)( z;)z%wI5>D4a*5XwD)P--sPkoY(a~WBw;E~AW`Yue4kFa^LM3X`8x|}ZUeMnqr}>kH zG%WWW>3ml$Yez?i%)2pbKPI7?5o?hydokgQyZsNEr{a|mLdt;X2TX(#B1j35xPnPW z*bMSSOauW>o;*=kO8ojw91VX!qoOQb)zHJ!odWB}d+*K?#sY_jqPdg{Sm2HdYzdEx zOGVPhVRTGPtv0o}RfVP;Nd(|CB)I;*t&QO8h zFfekr30S!-LHmV_Su-W+rEwYXJ^;6&3|L$mMC8*bQptyOo9;>Qb9Q9`ySe3%V$A*9 zeKEe+b0{#KWGp$F+tga)0RtI)nhMa-K@JS}2krK~n8vJ=Ngm?R!9G<~RyuU0d?nz# z-5EK$o(!F?hmX*2Yt6+coY`6jGbb7tF#6nHA zuKk=GGJ;ZwON1iAfG$E#Y7MnZVmrY|j0eVI(DN_MNFJmyZ|;w4tf@=CCDZ#5N_0K= z$;R~bbk?}TpfDjfB&aiQ$VA}s?P}xPERJG{kxk5~R`iRS(SK5d+Xs9swCozZISbnS zk!)I0>t=A<-^z(cmSFz3=jZ23u13X><0b)P)^1T_))Kr`e!-pb#q&J*Q`p+B6la%C zuVl&0duN<;uOsB3%T9Fp8t{ED108<+W(nOZd?gDnfNBC3>M8WE61$So|P zVvqH0SNtDTcsUdzaMDpT=Ty0pDHHNL@Z0w$Y`XO z2M-_r1S+GaH%pz#Uy0*w$Vdl=X=rQXEzO}d6J^R6zjM1u&c9vYLvLp?W7w(?np9x1 zE_0JSAJCPB%i7p*Wvg)pn5T`8k3-uR?*NT|J`eS#_#54p>!p(mLDvmc-3o0mX*mp_ zN*AeS<>#^-{S%W<*mz^!X$w_2dHWpcJ6^j64qFBft-o}o_Vx80o0>}Du;>kLts;$8 zC`7q$QI(dKYG`Wa8#wl@V4jVWBRGQ@1dr-hstpQL)Tl+aqVpGpbSfN>5i&QMXfiZ> zaA?T1VGe?rpQ@;+pkrVdd{klI&jVS@I5_iz!=UMpTsa~mBga?1r}aRBm1WS;TT*s0f0lY=JBl66Upy)-k4J}lh=P^8(SXk~0xW=T9v*B|gzIhN z>qsO7dFd~mgxAy4V?&)=5ieYq?zi?ZEoj)&2o)RLy=@hbCRcfT5jigwtQGE{L*8<@Yd{zg;CsL5mvzfDY}P-wos_6PfprFVaeqNE%h zKZhLtcQld;ZD+>=nqN~>GvROfueSzJD&BE*}XfU|H&(FssBqY=hPCt`d zH?@s2>I(|;fcW&YM6#V#!kUIP8$Nkdh0A(bEVj``-AAyYgwY~jB zT|I7Bf@%;7aL7Wf4dZ%VqF$eiaC38OV6oy3Z#TER2G+fOCd9Iaoy6aLYbPTN{XRPz z;U!V|vBf%H!}52L2gH_+j;`bTcQRXB+y9onc^wLm5wi3-Be}U>k_u>2Eg$=k!(l@I zcCg+flakT2Nej3i0yn+g+}%NYb?ta;R?(g5SnwsQ49U8Wng8d|{B+lyRcEDvR3+`O{zfmrmvFrL6acVP%yG98X zo&+VBg@px@i)%o?dG(`T;n*$S5*rnyiR#=wW}}GsAcfyQpE|>a{=$Hjg=-*_K;UtD z#z-)AXwSRY?OPefw^iI+ z)AXz#PfEjlwTes|_{sB?4(O@fg0AJ^g8gP}ex9Ucf*@_^J(s_5jJV}c)s$`Myn|Kd z$6>}#q^n{4vN@+Os$m7KV+`}c%4)4pv@06af4-x5#wj!KKb%caK{A&Y#Rfs z-po?Dcb1({W=6FKIUirH&(yg=*6aLCekcKwyfK^JN5{wcA3nhO(o}SK#!CINhI`-I z1)6&n7O&ZmyFMuNwvEic#IiOAwNkR=u5it{B9n2sAJV5pNhar=j5`*N!Na;c7g!l$ z3aYBqUkqqTJ=Re-;)s!EOeij=7SQZ3Hq}ZRds%IM*PtM$wV z@;rlc*NRK7i3y5BETSKuumEN`Xu_8GP1Ri=OKQ$@I^ko8>H6)4rjiG5{VBM>B|%`&&s^)jS|-_95&yc=GqjNo{zFkw%%HHhS~e=s zD#sfS+-?*t|J!+ozP6KvtOl!R)@@-z24}`9{QaVLD^9VCSR2b`b!KC#o;Ki<+wXB6 zx3&O0LOWcg4&rv4QG0)4yb}7BFSEg~=IR5#ZRj8kg}dS7_V&^%#Do==#`u zpy6{ox?jWuR(;pg+f@mT>#HGWHAJRRDDDv~@(IDw&R>9643kK#HN`!1vBJHnC+RM&yIh8{gG2q zA%e*U3|N0XSRa~oX-3EAneep)@{h2vvd3Xvy$7og(sayr@95+e6~Xvi1tUqnIxoIH zVWo*OwYElb#uyW{Imam6f2rGbjR!Y3`#gPqkv57dB6K^wRGxc9B(t|aYDGS=m$&S!NmCtrMMaUg(c zc2qC=2Z`EEFMW-me5B)24AqF*bV5Dr-M5ig(l-WPS%CgaPzs6p_gnCIvTJ=Y<6!gT zVt@AfYCzjjsMEGi=rDQHo0yc;HqoRNnNFeWZgcm?f;cp(6CNylj36DoL(?TS7eU#+ z7&mfr#y))+CJOXQKUMZ7QIdS9@#-}7y2K1{8)cCt0~-X0O!O?Qx#E4Og+;A2SjalQ zs7r?qn0H044=sDN$SRG$arw~n=+T_DNdSrarmu)V6@|?1-ZB#hRn`uilTGPJ@fqEy zGt(f0B+^JDP&f=r{#Y_wi#AVDf-y!RIXU^0jXsFpf>=Ji*TeqSY!H~AMbJdCGLhC) zn7Rx+sXw6uYj;WRYrLd^5IZq@6JI1C^YkgnedZEYy<&4(z%Q$5yv#Boo{AH8n$a zhb4Y3PWdr269&?V%uI$xMcUrMzl=;w<_nm*qr=c3Rl@i5wWB;e-`t7D&c-mcQl7x! zZWB`UGcw=Y2=}~wzrfLx=uet<;m3~=8I~ZRuzvMQUQdr+yTV|ATf1Uuomr__nDf=X zZ3WYJtHp_ri(}SQAPjv+Y+0=fH4krOP@S&=zZ-t1jW1o@}z;xk8 z(Nz1co&El^HK^NrhVHa-_;&88vTU>_J33=%{if;BEY*J#1n59=07jrGQ#IP>@u#3A z;!q+E1Rj3ZJ+!4bq9F8PXJ@yMgZL;>&gYA0%_Kbi8?S=XGM~dnQZQ!yBSgcZhY96H zrWnU;k)qy`rX&&xlDyA%(a1Hhi5CWkmg(`Gb%m(HKi-7Z!LKGRP_B8@`7&hdDy5n= z`OIxqxiVfX@OX1p(mQu>0Ai*v_cTMiw4qRt3~NBvr9oBy0)r>w3p~V0SCm=An6@3n)>@z!|o-$HvDK z|3D2ZMJkLE5loMKl6R^ez@Zz%S$&mbeoqH5`Bb){Ei21q&VP)hWS2tjShfFtGE+$z zzCR$P#uktu+#!w)cX!lWN1XU%K-r=s{|j?)Akf@q#3b#{6cZCuJ~gCxuMXRmI$nGtnH+-h z+GEi!*X=AP<|fG`1>MBdTb?28JYc=fGvAi2I<$B(rs$;eoJCyR6_bc~p!XR@O-+sD z=eH`-ye})I5ic1eL~TDmtfJ|8`0VJ*Yr=hNCd)G1p2MMz4C3^Mj?7;!w|Ly%JqmuW zlIEW^Ft%z?*|fpXda>Jr^1noFZEwFgVV%|*XhH@acv8rdGxeEX{M$(vG{Zw+x(ei@ zmfXb22}8-?Fi`vo-YVrTH*C?a8%M=Hv9MqVH7H^J$KsD?>!SFZ;ZsvnHr_gn=7acz z#W?0eCdVhVMWN12VV^$>WlQ?f;P^{(&pYTops|btm6aj>_Uz+hqpGwB)vWp0Cf5y< zft8-je~nn?W11plq}N)4A{l8I7$!ks_x$PXW-2XaRFswX_BnF{R#6YIwMhAgd5F9X zGmwdadS6(a^fjHtXg8=l?Rc0Sm%hk6E9!5cLVloEy4eh(=FwgP`)~I^5~pBEWo+F6 zSf2ncyMurJN91#cJTy_u8Y}@%!bq1RkGC~-bV@SXRd4F{R-*V`bS+6;W5vZ(&+I<9$;-V|eNfLa5n-6% z2(}&uGRF;p92eS*sE*oR$@pexaqr*meB)VhmIg@h{uzkk$9~qh#cHhw#>O%)b@+(| z^IQgqzuj~Sk(J;swEM-3TrJAPCq9k^^^`q{IItKBRXYe}e0Tdr=Huf7da3$l4PdpwWDop%^}n;dD#K4s#DYA8SHZ z&1!riV4W4R7R#C))JH1~axJ)RYnM$$lIR%6fIVA@zV{XVyx}C+a-Dt8Y9M)^KU0+H zR4IUb2CJ{Hg>CuaXtD50jB(_Tcx=Z$^WYu2u5kubqmwp%drJ6 z?Fo40g!Qd<-l=TQxqHEOuPX0;^z7iX?Ke^a%XT<13TA^5`4Xcw6D@Ur&VT&CUe0d} z1GjOVF1^L@>O)l@?bD~$wzgf(nxX1OGD8fEV?TdJcZc2KoUe|oP1#=$$7ee|xbY)A zDZq+cuTpc(fFdj^=!;{k03C69lMQ(|>uhRfRu%+!k&YOi-3|1QKB z z?n?eq1XP>p-IM$Z^C;2L3itnbJZAip*Zo0aw2bs8@(s^~*8T9go!%dHcAz2lM;`yp zD=7&xjFV$S&5uDaiScyD?B-i1ze`+CoRtz`Wn+Zl&#s4&}MO{@N!ufrzjG$B79)Y2d3tBk&)TxUTw@QS0TEL_?njX|@vq?Uz(nBFK5Pq7*xj#u*R&i|?7+6# z+|r_n#SW&LXhtheZdah{ZVoqwyT{D>MC3nkFF#N)xLi{p7J1jXlmVeb;cP5?e(=f# zuT7fvjSbjS781v?7{)-X3*?>tq?)Yd)~|1{BDS(pqC zC}~H#WXlkUW*H5CDOo<)#x7%RY)A;ShGhI5s*#cRDA8YgqG(HeKDx+#(ZQ?386dv! zlXCO)w91~Vw4AmOcATuV653fa9R$fyK8ul%rG z-wfS zihugoZyr38Im?Zuh6@RcF~t1anQu7>#lPpb#}4cOA!EM11`%f*07RqOVkmX{p~KJ9 z^zP;K#|)$`^Rb{rnHGH{~>1(fawV0*Z#)}M`m8-?ZJV<+e}s9wE# z)l&az?w^5{)`S(%MRzxdNqrs1n*-=jS^_jqE*5XDrA0+VE`5^*p3CuM<&dZEeCjoz zR;uu_H9ZPZV|fQq`Cyw4nscrVwi!fE6ciMmX$!_hN7uF;jjKG)d2@aC4ropY)8etW=xJvni)8eHi`H$%#zn^WJ5NLc-rqk|u&&4Z6fD_m&JfSI1Bvb?b<*n&sfl0^t z=HnmRl`XrFvMKB%9}>PaA`m-fK6a0(8=qPkWS5bb4=v?XcWi&hRY?O5HdulRi4?fN zlsJ*N-0Qw+Yic@s0(2uy%F@ib;GjXt01Fmx5XbRo6+n|pP(&nodMoap^z{~q ziEeaUT@Mxe3vJSfI6?uLND(CNr=#^W<1b}jzW58bIfyWTDle$mmS(|x-0|2UlX+9k zQ^EX7Nw}?EzVoBfT(-LT|=9N@^hcn-_p&sqG z&*oVs2JSU+N4ZD`FhCAWaS;>|wH2G*Id|?pa#@>tyxX`+4HyIArWDvVrX)2WAOQff z0qyHu&-S@i^MS-+j--!pr4fPBj~_8({~e1bfcl0wI1kaoN>mJL6KUPQm5N7lB(ui1 zE-o%kq)&djzWJ}ob<-GfDlkB;F31j-VHKvQUGQ3sp`CwyGJk_i!y^sD0fqC@$9|jO zOqN!r!8-p==F@ZVP=U$qSpY(gQ0)59P1&t@y?5rvg<}E+GB}26NYPp4f2YFQrQtot5mn3wu_qprZ=>Ig-$ zbW26Ws~IgY>}^5w`vTB(G`PTZaDiGBo5o(tp)qli|NeV( z@H_=R8V39rt5J5YB2Ky?4eJJ#b`_iBe2ot~6%7mLt5t8Vwi^Jy7|jWXqa3amOIoRb zOr}WVFP--DsS`1WpN%~)t3R!arKF^Q$e12KEqU36AWwnCBICpH4XCsfnyrHr>$I$4 z!DpKX$OKLWarN7nv@!uIA+~RNO)l$$w}p(;b>mx8pwYvu;dD_unryX_NhT8*Tj>BTrTTL&!?O+%Rv;b?B??gSzdp?6Uug9{ zd@V08Z$BdI?fpoCS$)t4mg4rT8Q_I}h`0d-vYZ^|dOB*Q^S|xqTV*vIg?@fVFSmMpaw0qtTRbx} z({Pg?#{2`sc9)M5N$*N|4;^t$+QP?#mov zGVC@I*lBVrOU-%2y!7%)fAKjpEFsgQc4{amtiHb95KQEwvf<(3T<9-Zm$xIew#P22 zc2Ix|App^>v6(3L_MCU0d3W##AB0M~3D00EWoKZqsJYT(#@w$Y_H7G22M~ApVFTRHMI_3be)Lkn#0F*V8Pq zc}`Cjy$bE;FJ6H7p=0y#R>`}-m4(0F>%@P|?7fx{=R^uFdISRnZ2W_xQhD{YuR3t< z{6yxu=4~JkeA;|(J6_nv#>Nvs&FuLA&PW^he@t(UwFFE8)|a!R{`E`K`i^ZnyE4$k z;(749Ix|oi$c3QbEJ3b~D_kQsPz~fIUKym($a_7dJ?o+40*OLl^{=&oq$<#Q(yyrp z{J-FAniyAw9tPbe&IhQ|a`DqFTVQGQ&Gq3!C2==4x{6EJwiPZ8zub-iXoUtkJiG{} zPaR&}_fn8_z~(=;5lD-aPWD3z8PZS@AaUiomF!G8I}Mf>e~0g#BelA-5#`cj;O5>N Xviia!U7SGha1wx#SCgwmn*{w2TRX*I literal 0 HcmV?d00001 diff --git a/stock_production_lot_warranty/static/description/index.html b/stock_production_lot_warranty/static/description/index.html new file mode 100644 index 000000000..9677c3048 --- /dev/null +++ b/stock_production_lot_warranty/static/description/index.html @@ -0,0 +1,466 @@ + + + + + +Warranty Date on Lot/Serial Numbers + + + +
+

Warranty Date on Lot/Serial Numbers

+ + +

Beta License: AGPL-3 OCA/rma Translate me on Weblate Try me on Runboat

+

Odoo does not provide the warranty information on the serial number of a +product.

+

This module allows you to compute the warranty expiration date of a +serialized product based on the warranty duration.

+

Table of contents

+ +
+

Configuration

+

To configure this module:

+
    +
  • Go to Inventory > Configuration > Settings
    • +
  • Activate the traceability
    • +
  • Go to Inventory > Products > Products
    • +
  • Create or select a product and set the warranty
    • +
  • Go to the Inventory tab in the Logistics section
    • +
  • Set the warranty duration
    • +
+
+
+

Usage

+

To use this module,

+
    +
  • Go to Inventory > Products > Lot/Serial Numbers
    • +
  • Create a new serial number and select a product
    • +
  • The Warranty Expiration Date is automatically computed based on today ++ the warranty duration from the select product
    • +
  • You can overwrite the computed date with your own value.
    • +
+
+
+

Bug Tracker

+

Bugs are tracked on GitHub Issues. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us to smash it by providing a detailed and welcomed +feedback.

+

Do not contact contributors directly about support or help with technical issues.

+
+
+

Credits

+
+

Authors

+
    +
  • Open Source Integrators
    • +
+
+
+

Contributors

+ +
+
+

Other credits

+

This module has been financially supported by:

+ +
+
+

Maintainers

+

This module is maintained by the OCA.

+ +Odoo Community Association + +

OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use.

+

Current maintainers:

+

osi-scampbell max3903

+

This module is part of the OCA/rma project on GitHub.

+

You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

+
+
+
+ + diff --git a/stock_production_lot_warranty/tests/__init__.py b/stock_production_lot_warranty/tests/__init__.py new file mode 100644 index 000000000..01c923daa --- /dev/null +++ b/stock_production_lot_warranty/tests/__init__.py @@ -0,0 +1,4 @@ +# Copyright (C) 2021 Open Source Integrators +# Copyright (C) 2021 Serpent Consulting Services +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). +from . import test_product_lot_warranty diff --git a/stock_production_lot_warranty/tests/test_product_lot_warranty.py b/stock_production_lot_warranty/tests/test_product_lot_warranty.py new file mode 100644 index 000000000..620c0b1dc --- /dev/null +++ b/stock_production_lot_warranty/tests/test_product_lot_warranty.py @@ -0,0 +1,82 @@ +# Copyright (C) 2021 Open Source Integrators +# Copyright (C) 2021 Serpent Consulting Services +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). +from datetime import datetime, timedelta + +import psycopg2 + +from odoo.tests import common + + +class TestProductLotWarranty(common.TransactionCase): + @classmethod + def setUpClass(cls): + super().setUpClass() + cls.company1 = cls.env["res.company"].create({"name": "Test company1"}) + cls.product1 = cls.env["product.product"].create( + { + "name": "TestProduct", + "warranty_type": "day", + "warranty": 5, + } + ) + + def test_productlot_warranty(self): + production_lot = self.env["stock.production.lot"].create( + {"product_id": self.product1.id, "company_id": self.company1.id} + ) + production_lot._onchange_product_id() + self.assertEqual( + production_lot.warranty_exp_date, + (datetime.now() + timedelta(days=5)).date(), + ) + + def test_productlot_no_product(self): + # s.p.lot "product_id" is required=True + with self.assertRaises(psycopg2.IntegrityError): + self.env["stock.production.lot"].create( + {"product_id": False, "company_id": self.company1.id} + ) + + def test_productlot_no_warranty_type(self): + # product.template "warranty_type" is required=True + with self.assertRaises(psycopg2.IntegrityError): + self.env["product.product"].create( + { + "name": "TestProduct", + "warranty_type": False, + "warranty": 5, + } + ) + + def test_productlot_no_warranty(self): + product2 = self.env["product.product"].create( + { + "name": "TestProduct", + "warranty_type": "week", + "warranty": 0, + } + ) + production_lot = self.env["stock.production.lot"].create( + {"product_id": product2.id, "company_id": self.company1.id} + ) + production_lot._onchange_product_id() + self.assertFalse(production_lot.warranty_exp_date) + + def test_get_warranty_exp_date(self): + production_lot = self.env["stock.production.lot"].create( + {"product_id": self.product1.id, "company_id": self.company1.id} + ) + timestamp = datetime.now() - timedelta(days=3) + self.assertEqual( + production_lot._get_warranty_exp_date(), + (datetime.now() + timedelta(days=5)).date(), + ) + self.assertEqual( + production_lot._get_warranty_exp_date(timestamp), + (datetime.now() + timedelta(days=2)).date(), + ) + self.assertEqual( + production_lot._get_warranty_exp_date(timestamp.date()), + (datetime.now() + timedelta(days=2)).date(), + ) diff --git a/stock_production_lot_warranty/views/stock_production_lot.xml b/stock_production_lot_warranty/views/stock_production_lot.xml new file mode 100644 index 000000000..856d195f3 --- /dev/null +++ b/stock_production_lot_warranty/views/stock_production_lot.xml @@ -0,0 +1,14 @@ + + + + stock.production.lot + + + + + + + + + + From 44d3413aad1bf9665dd92af175d324ce3c81f7ea Mon Sep 17 00:00:00 2001 From: georgiedekker Date: Mon, 11 Aug 2025 10:13:36 +0200 Subject: [PATCH 2/6] [FIX] stock_production_lot_warranty: Update model references for Odoo 18 In Odoo 18, the model 'stock.production.lot' has been renamed to 'stock.lot'. This commit updates all references to use the new model name: - Updated model inheritance in Python files - Updated view references from stock.view_production_lot_form to stock.view_lot_form - Updated test references to use stock.lot instead of stock.production.lot --- .../models/stock_production_lot.py | 2 +- .../tests/test_product_lot_warranty.py | 10 +++++----- .../views/stock_production_lot.xml | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/stock_production_lot_warranty/models/stock_production_lot.py b/stock_production_lot_warranty/models/stock_production_lot.py index 1e1262dfe..2a38eaeec 100644 --- a/stock_production_lot_warranty/models/stock_production_lot.py +++ b/stock_production_lot_warranty/models/stock_production_lot.py @@ -10,7 +10,7 @@ class StockProductionLot(models.Model): - _inherit = "stock.production.lot" + _inherit = "stock.lot" warranty_exp_date = fields.Date(string="Warranty Expiration Date") diff --git a/stock_production_lot_warranty/tests/test_product_lot_warranty.py b/stock_production_lot_warranty/tests/test_product_lot_warranty.py index 620c0b1dc..5cf125f6e 100644 --- a/stock_production_lot_warranty/tests/test_product_lot_warranty.py +++ b/stock_production_lot_warranty/tests/test_product_lot_warranty.py @@ -22,7 +22,7 @@ def setUpClass(cls): ) def test_productlot_warranty(self): - production_lot = self.env["stock.production.lot"].create( + production_lot = self.env["stock.lot"].create( {"product_id": self.product1.id, "company_id": self.company1.id} ) production_lot._onchange_product_id() @@ -32,9 +32,9 @@ def test_productlot_warranty(self): ) def test_productlot_no_product(self): - # s.p.lot "product_id" is required=True + # stock.lot "product_id" is required=True with self.assertRaises(psycopg2.IntegrityError): - self.env["stock.production.lot"].create( + self.env["stock.lot"].create( {"product_id": False, "company_id": self.company1.id} ) @@ -57,14 +57,14 @@ def test_productlot_no_warranty(self): "warranty": 0, } ) - production_lot = self.env["stock.production.lot"].create( + production_lot = self.env["stock.lot"].create( {"product_id": product2.id, "company_id": self.company1.id} ) production_lot._onchange_product_id() self.assertFalse(production_lot.warranty_exp_date) def test_get_warranty_exp_date(self): - production_lot = self.env["stock.production.lot"].create( + production_lot = self.env["stock.lot"].create( {"product_id": self.product1.id, "company_id": self.company1.id} ) timestamp = datetime.now() - timedelta(days=3) diff --git a/stock_production_lot_warranty/views/stock_production_lot.xml b/stock_production_lot_warranty/views/stock_production_lot.xml index 856d195f3..07fcbbfe2 100644 --- a/stock_production_lot_warranty/views/stock_production_lot.xml +++ b/stock_production_lot_warranty/views/stock_production_lot.xml @@ -1,8 +1,8 @@ - stock.production.lot - + stock.lot + From 37de5541b3a891c2034b54cc9755944216a0fa98 Mon Sep 17 00:00:00 2001 From: georgiedekker Date: Mon, 11 Aug 2025 10:49:20 +0200 Subject: [PATCH 3/6] [FIX] stock_production_lot_warranty: Correct view reference for Odoo 18 Fixed the inherited view reference from stock.view_lot_form to stock.view_production_lot_form which is the correct XML ID in Odoo 18. The module now successfully installs and works with Odoo 18. --- stock_production_lot_warranty/views/stock_production_lot.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stock_production_lot_warranty/views/stock_production_lot.xml b/stock_production_lot_warranty/views/stock_production_lot.xml index 07fcbbfe2..3aaa2fa3e 100644 --- a/stock_production_lot_warranty/views/stock_production_lot.xml +++ b/stock_production_lot_warranty/views/stock_production_lot.xml @@ -2,7 +2,7 @@ stock.lot - + From ea497df477dd61ec8d006c835f47a4ae5cc5257a Mon Sep 17 00:00:00 2001 From: georgiedekker Date: Mon, 11 Aug 2025 11:00:05 +0200 Subject: [PATCH 4/6] [FIX] stock_production_lot_warranty: Fix test compatibility with Odoo 18 - Replace psycopg2.IntegrityError with ValidationError/ValueError exceptions - Add mute_logger decorator to suppress SQL error logs in tests - Add flush_recordset() calls to ensure constraint checks are triggered - Update test expectations to match Odoo 18 behavior The tests were failing because Odoo 18 handles database constraints differently, requiring updates to exception handling in the test cases. --- .../tests/test_product_lot_warranty.py | 24 ++++++++++++------- 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/stock_production_lot_warranty/tests/test_product_lot_warranty.py b/stock_production_lot_warranty/tests/test_product_lot_warranty.py index 5cf125f6e..234dfb7b8 100644 --- a/stock_production_lot_warranty/tests/test_product_lot_warranty.py +++ b/stock_production_lot_warranty/tests/test_product_lot_warranty.py @@ -3,9 +3,9 @@ # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). from datetime import datetime, timedelta -import psycopg2 - +from odoo.exceptions import ValidationError from odoo.tests import common +from odoo.tools import mute_logger class TestProductLotWarranty(common.TransactionCase): @@ -31,23 +31,31 @@ def test_productlot_warranty(self): (datetime.now() + timedelta(days=5)).date(), ) + @mute_logger("odoo.sql_db") def test_productlot_no_product(self): # stock.lot "product_id" is required=True - with self.assertRaises(psycopg2.IntegrityError): - self.env["stock.lot"].create( - {"product_id": False, "company_id": self.company1.id} + # In Odoo 18, trying to create a lot without product should raise an error + with self.assertRaises((ValidationError, ValueError)): + lot = self.env["stock.lot"].create( + {"product_id": False, "company_id": self.company1.id, "name": "test_lot"} ) + # Force the constraint check if create doesn't raise immediately + lot.flush_recordset() + @mute_logger("odoo.sql_db") def test_productlot_no_warranty_type(self): - # product.template "warranty_type" is required=True - with self.assertRaises(psycopg2.IntegrityError): - self.env["product.product"].create( + # product.template "warranty_type" is required=True if warranty module is installed + # In Odoo 18, this should raise an error when warranty_type is False/None + with self.assertRaises((ValidationError, ValueError)): + product = self.env["product.product"].create( { "name": "TestProduct", "warranty_type": False, "warranty": 5, } ) + # Force the constraint check if create doesn't raise immediately + product.flush_recordset() def test_productlot_no_warranty(self): product2 = self.env["product.product"].create( From 819e9ff786842bd0a6bccfdf955cdb73bfde8361 Mon Sep 17 00:00:00 2001 From: georgiedekker Date: Mon, 11 Aug 2025 11:14:27 +0200 Subject: [PATCH 5/6] [FIX] stock_production_lot_warranty: Fix test exception handling for Odoo 18 - Replace tuple exception handling with try-except blocks - Odoo 18's assertRaises doesn't accept tuples of exceptions - Use try-except to handle both ValidationError and IntegrityError - Fix line length issues for pre-commit compliance The tests were failing with 'TypeError: issubclass() arg 1 must be a class' because Odoo 18's test framework doesn't support passing multiple exception types to assertRaises. --- .../tests/test_product_lot_warranty.py | 24 +++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/stock_production_lot_warranty/tests/test_product_lot_warranty.py b/stock_production_lot_warranty/tests/test_product_lot_warranty.py index 234dfb7b8..4d510eafa 100644 --- a/stock_production_lot_warranty/tests/test_product_lot_warranty.py +++ b/stock_production_lot_warranty/tests/test_product_lot_warranty.py @@ -3,6 +3,8 @@ # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). from datetime import datetime, timedelta +from psycopg2 import IntegrityError + from odoo.exceptions import ValidationError from odoo.tests import common from odoo.tools import mute_logger @@ -35,18 +37,26 @@ def test_productlot_warranty(self): def test_productlot_no_product(self): # stock.lot "product_id" is required=True # In Odoo 18, trying to create a lot without product should raise an error - with self.assertRaises((ValidationError, ValueError)): + try: lot = self.env["stock.lot"].create( - {"product_id": False, "company_id": self.company1.id, "name": "test_lot"} + { + "product_id": False, + "company_id": self.company1.id, + "name": "test_lot", + } ) # Force the constraint check if create doesn't raise immediately lot.flush_recordset() + self.fail("Creating a lot without product should raise an error") + except (ValidationError, IntegrityError): + # Expected behavior - constraint violation + pass @mute_logger("odoo.sql_db") def test_productlot_no_warranty_type(self): - # product.template "warranty_type" is required=True if warranty module is installed + # product.template "warranty_type" is required=True if warranty is installed # In Odoo 18, this should raise an error when warranty_type is False/None - with self.assertRaises((ValidationError, ValueError)): + try: product = self.env["product.product"].create( { "name": "TestProduct", @@ -56,6 +66,12 @@ def test_productlot_no_warranty_type(self): ) # Force the constraint check if create doesn't raise immediately product.flush_recordset() + self.fail( + "Creating a product without warranty_type should raise an error" + ) + except (ValidationError, IntegrityError): + # Expected behavior - constraint violation + pass def test_productlot_no_warranty(self): product2 = self.env["product.product"].create( From ca7edb6a9c0716ac1a4591a266094a5c81bf5c80 Mon Sep 17 00:00:00 2001 From: georgiedekker Date: Mon, 11 Aug 2025 11:22:09 +0200 Subject: [PATCH 6/6] [FIX] stock_production_lot_warranty: Fix pylint warnings and apply formatting - Replace 'pass' in except blocks with proper assertions - Use error_raised flag to avoid pylint W8138 warning - Apply ruff formatting to ensure consistent code style - All pre-commit checks now pass This ensures the code meets OCA quality standards and CI requirements. --- .../tests/test_product_lot_warranty.py | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/stock_production_lot_warranty/tests/test_product_lot_warranty.py b/stock_production_lot_warranty/tests/test_product_lot_warranty.py index 4d510eafa..e489cf62c 100644 --- a/stock_production_lot_warranty/tests/test_product_lot_warranty.py +++ b/stock_production_lot_warranty/tests/test_product_lot_warranty.py @@ -37,6 +37,7 @@ def test_productlot_warranty(self): def test_productlot_no_product(self): # stock.lot "product_id" is required=True # In Odoo 18, trying to create a lot without product should raise an error + error_raised = False try: lot = self.env["stock.lot"].create( { @@ -47,15 +48,19 @@ def test_productlot_no_product(self): ) # Force the constraint check if create doesn't raise immediately lot.flush_recordset() - self.fail("Creating a lot without product should raise an error") except (ValidationError, IntegrityError): # Expected behavior - constraint violation - pass + error_raised = True + + self.assertTrue( + error_raised, "Creating a lot without product should raise an error" + ) @mute_logger("odoo.sql_db") def test_productlot_no_warranty_type(self): # product.template "warranty_type" is required=True if warranty is installed # In Odoo 18, this should raise an error when warranty_type is False/None + error_raised = False try: product = self.env["product.product"].create( { @@ -66,12 +71,14 @@ def test_productlot_no_warranty_type(self): ) # Force the constraint check if create doesn't raise immediately product.flush_recordset() - self.fail( - "Creating a product without warranty_type should raise an error" - ) except (ValidationError, IntegrityError): # Expected behavior - constraint violation - pass + error_raised = True + + self.assertTrue( + error_raised, + "Creating a product without warranty_type should raise an error", + ) def test_productlot_no_warranty(self): product2 = self.env["product.product"].create(