Skip to content

Commit 665fdc9

Browse files
authored
fix linting error in skyrl-cpu CI (ignore agent and examples) and change CI scope (#1143)
Changes the scope of CI running for the previously TX related tests (`cpu_skyrl.yaml`, `gpu_skyrl.yaml`) to be: ``` - 'ci/**' - 'skyrl/**' - 'tests/**' - 'pyproject.toml' ``` and changes the scope of previously train related tests (`cpu_skyrl_train.yaml`, `gpu_skyrl_train.yaml`, ...) to be more inclusive. <!-- devin-review-badge-begin --> --- <a href="https://app.devin.ai/review/novasky-ai/skyrl/pull/1143" target="_blank"> <picture> <source media="(prefers-color-scheme: dark)" srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1"> <img src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1" alt="Open with Devin"> </picture> </a> <!-- devin-review-badge-end -->
1 parent 21a49d5 commit 665fdc9

File tree

6 files changed

+30
-4
lines changed

6 files changed

+30
-4
lines changed

.github/workflows/cpu_skyrl.yaml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,17 @@ on:
44
push:
55
branches: [ main ]
66
paths:
7-
- '**'
7+
- 'ci/**'
8+
- 'skyrl/**'
9+
- 'tests/**'
10+
- 'pyproject.toml'
811
- '.github/workflows/cpu_skyrl.yaml'
912
pull_request:
1013
paths:
11-
- '**'
14+
- 'ci/**'
15+
- 'skyrl/**'
16+
- 'tests/**'
17+
- 'pyproject.toml'
1218
- '.github/workflows/cpu_skyrl.yaml'
1319
workflow_dispatch:
1420

.github/workflows/cpu_skyrl_train.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,18 @@ on:
66
- main
77
- rc/**
88
paths:
9+
- 'ci/**'
910
- 'skyrl/**'
11+
- 'tests/**'
12+
- 'pyproject.toml'
1013
- 'skyrl-gym/**'
1114
- '.github/workflows/cpu_skyrl_train.yaml'
1215
pull_request:
1316
paths:
17+
- 'ci/**'
1418
- 'skyrl/**'
19+
- 'tests/**'
20+
- 'pyproject.toml'
1521
- 'skyrl-gym/**'
1622
- '.github/workflows/cpu_skyrl_train.yaml'
1723

.github/workflows/gpu_skyrl.yaml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,17 @@ on:
44
push:
55
branches: [ main ]
66
paths:
7-
- '**'
7+
- 'ci/**'
8+
- 'skyrl/**'
9+
- 'tests/**'
10+
- 'pyproject.toml'
811
- '.github/workflows/gpu_skyrl.yaml'
912
pull_request:
1013
paths:
11-
- '**'
14+
- 'ci/**'
15+
- 'skyrl/**'
16+
- 'tests/**'
17+
- 'pyproject.toml'
1218
- '.github/workflows/gpu_skyrl.yaml'
1319
workflow_dispatch:
1420

.github/workflows/gpu_skyrl_train.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ on:
55
branches:
66
- main
77
paths:
8+
- 'ci/**'
89
- 'skyrl/backends/skyrl_train/**'
910
- 'skyrl/train/**'
1011
- 'tests/backends/skyrl_train/**'

.github/workflows/gpu_skyrl_train_megatron.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ on:
55
branches:
66
- main
77
paths:
8+
- 'ci/**'
89
- 'skyrl/backends/skyrl_train/workers/**'
910
- 'skyrl/backends/skyrl_train/distributed/megatron/**'
1011
- 'skyrl/train/config/**'

pyproject.toml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -286,6 +286,12 @@ extend-ignore = [
286286
"W605",
287287
]
288288

289+
[tool.ruff]
290+
exclude = [
291+
"skyrl-agent/",
292+
"examples/",
293+
]
294+
289295
[tool.ruff.lint]
290296
ignore = [
291297
"F722" # Syntax error in annotation - ignored because this doesn't play well with jaxtyping

0 commit comments

Comments
 (0)