Skip to content

Commit 0f0a867

Browse files
rekhoffbfopsjdetterclockwork-labs-bot
authored
Removing1.5.0 DLLs (clockworklabs#4100)
# Description of Changes Removes 1.5.0 DLLs from repo # API and ABI breaking changes Unity will complain locally until you regenerate the DLLs # Expected complexity level and risk 1 - Trivial # Testing - [x] Confirm CI pass - [X] Local tests are passing --------- Signed-off-by: Ryan <[email protected]> Co-authored-by: Zeke Foppa <[email protected]> Co-authored-by: John Detter <[email protected]> Co-authored-by: clockwork-labs-bot <[email protected]>
1 parent e06d916 commit 0f0a867

File tree

13 files changed

+9
-164
lines changed

13 files changed

+9
-164
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -608,6 +608,9 @@ jobs:
608608
exit 1
609609
}
610610
611+
- name: Hydrate Unity SDK DLLs
612+
run: cargo ci dlls
613+
611614
- name: Check Unity meta files
612615
uses: DeNA/unity-meta-check@v3
613616
with:
@@ -630,10 +633,7 @@ jobs:
630633
- name: Patch com.clockworklabs.spacetimedbsdk dependency in manifest.json
631634
working-directory: demo/Blackholio/client-unity/Packages
632635
run: |
633-
# Replace the com.clockworklabs.spacetimedbsdk dependency with the current branch.
634-
# Note: Pointing to a local directory does not work, because our earlier steps nuke our meta files, which then causes Unity to not properly respect the DLLs (e.g.
635-
# codegen does not work properly).
636-
yq e -i '.dependencies["com.clockworklabs.spacetimedbsdk"] = "https://github.com/clockworklabs/SpacetimeDB.git?path=sdks/csharp#${{ github.head_ref }}"' manifest.json
636+
yq e -i '.dependencies["com.clockworklabs.spacetimedbsdk"] = "file:../../../../sdks/csharp"' manifest.json
637637
cat manifest.json
638638
639639
- uses: actions/cache@v3

sdks/csharp/.gitignore

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,3 +76,8 @@ obj~
7676
/nuget.config
7777
/nuget.config.meta
7878
.idea/
79+
80+
# Hydrated SDK DLLs (produced by `cargo ci dlls`)
81+
/packages/
82+
/packages.meta
83+
!/packages/.gitignore

sdks/csharp/packages/spacetimedb.bsatn.runtime.meta

Lines changed: 0 additions & 8 deletions
This file was deleted.

sdks/csharp/packages/spacetimedb.bsatn.runtime/1.5.0.meta

Lines changed: 0 additions & 8 deletions
This file was deleted.

sdks/csharp/packages/spacetimedb.bsatn.runtime/1.5.0/analyzers.meta

Lines changed: 0 additions & 8 deletions
This file was deleted.

sdks/csharp/packages/spacetimedb.bsatn.runtime/1.5.0/analyzers/dotnet.meta

Lines changed: 0 additions & 8 deletions
This file was deleted.

sdks/csharp/packages/spacetimedb.bsatn.runtime/1.5.0/analyzers/dotnet/cs.meta

Lines changed: 0 additions & 8 deletions
This file was deleted.

sdks/csharp/packages/spacetimedb.bsatn.runtime/1.5.0/analyzers/dotnet/cs/SpacetimeDB.BSATN.Codegen.dll.meta

Lines changed: 0 additions & 71 deletions
This file was deleted.

sdks/csharp/packages/spacetimedb.bsatn.runtime/1.5.0/lib.meta

Lines changed: 0 additions & 8 deletions
This file was deleted.

0 commit comments

Comments
 (0)