Skip to content

Commit 2ef05a4

Browse files
fix: use correct type for _current_global_parameter_metas (#33)
1 parent 8a60e65 commit 2ef05a4

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

checkpoint_engine/ps.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -741,7 +741,12 @@ def gather_metas(self, checkpoint_name: str):
741741
if not self._global_device_uuids:
742742
global_device_uuids.append(metas_buckets.device_uuid)
743743
if metas_buckets.memory_buffer_metas_list:
744-
self._current_global_parameter_metas[i] = metas_buckets
744+
# _current_global_parameter_metas value should be MemoryBufferMetaList, but metas_buckets is DataToGather
745+
# so we need to convert it to MemoryBufferMetaList
746+
self._current_global_parameter_metas[i] = MemoryBufferMetaList(
747+
memory_buffer_metas_list=metas_buckets.memory_buffer_metas_list,
748+
p2p_store_addr=metas_buckets.p2p_store_addr,
749+
)
745750
num_parameters += sum(len(x.metas) for x in metas_buckets.memory_buffer_metas_list)
746751
if not self._all_hosts:
747752
self._all_hosts = all_hosts

0 commit comments

Comments
 (0)