Skip to content

Commit 6642b4a

Browse files
Merge pull request #257 from MihaiCristianCondrea/codex/update-menu-item-colors-in-xml-files
Align menu icons with text color
2 parents 384276f + d77014e commit 6642b4a

File tree

3 files changed

+21
-4
lines changed

3 files changed

+21
-4
lines changed

app/src/main/res/menu/menu_feedback.xml

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,31 +4,43 @@
44
<item
55
android:id="@+id/view_in_google_play"
66
android:icon="@drawable/ic_play_store_tinted"
7+
android:iconTint="?attr/colorOnSurface"
78
android:title="@string/view_in_google_play"
9+
app:iconTint="?attr/colorOnSurface"
810
app:showAsAction="never" />
911
<item
1012
android:id="@+id/version_info"
1113
android:icon="@drawable/ic_perm_device_information"
14+
android:iconTint="?attr/colorOnSurface"
1215
android:title="@string/version_info"
16+
app:iconTint="?attr/colorOnSurface"
1317
app:showAsAction="never" />
1418
<item
1519
android:id="@+id/beta_program"
1620
android:icon="@drawable/ic_tips_and_updates"
21+
android:iconTint="?attr/colorOnSurface"
1722
android:title="@string/beta_program"
23+
app:iconTint="?attr/colorOnSurface"
1824
app:showAsAction="never" />
1925
<item
2026
android:id="@+id/terms_of_service"
2127
android:icon="@drawable/ic_terms_of_service"
28+
android:iconTint="?attr/colorOnSurface"
2229
android:title="@string/terms_of_service"
30+
app:iconTint="?attr/colorOnSurface"
2331
app:showAsAction="never" />
2432
<item
2533
android:id="@+id/privacy_policy"
2634
android:icon="@drawable/ic_privacy_policy"
35+
android:iconTint="?attr/colorOnSurface"
2736
android:title="@string/privacy_policy"
37+
app:iconTint="?attr/colorOnSurface"
2838
app:showAsAction="never" />
2939
<item
3040
android:id="@+id/oss"
3141
android:icon="@drawable/ic_license"
42+
android:iconTint="?attr/colorOnSurface"
3243
android:title="@string/open_source_licenses"
44+
app:iconTint="?attr/colorOnSurface"
3345
app:showAsAction="never" />
34-
</menu>
46+
</menu>
Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
<?xml version="1.0" encoding="utf-8"?>
2-
<menu xmlns:android="http://schemas.android.com/apk/res/android">
2+
<menu xmlns:android="http://schemas.android.com/apk/res/android"
3+
xmlns:app="http://schemas.android.com/apk/res-auto">
34
<item
45
android:id="@+id/support"
56
android:icon="@drawable/ic_support"
6-
android:title="@string/support_us" />
7-
</menu>
7+
android:iconTint="?attr/colorOnSurface"
8+
android:title="@string/support_us"
9+
app:iconTint="?attr/colorOnSurface" />
10+
</menu>

app/src/main/res/menu/menu_share.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
<item
55
android:id="@+id/action_share"
66
android:icon="@drawable/ic_share"
7+
android:iconTint="?attr/colorOnSurface"
78
android:title="@string/share"
9+
app:iconTint="?attr/colorOnSurface"
810
app:showAsAction="ifRoom" />
911
</menu>

0 commit comments

Comments
 (0)