Skip to content

Commit f08954b

Browse files
authored
Merge pull request #1290 from MetadataConsulting/remove-d3-ui-messages-pane
Remove d3 ui messages pane
2 parents 6f49f3a + 3009a2c commit f08954b

File tree

4 files changed

+30
-20
lines changed

4 files changed

+30
-20
lines changed

ModelCatalogueCorePluginTestApp/build.gradle

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ task npmCacheConfig(type: NpmTask, dependsOn: nodeSetup) {
3939
task npmPackages(type: NpmTask, dependsOn: npmCacheConfig) {
4040
description = "Install Node.js packages"
4141
args = [ 'install' ]
42-
// inputs.files file('package.json')
42+
inputs.files file('package.json')
4343
outputs.files file('node_modules')
4444
}
4545

@@ -50,7 +50,7 @@ task bowerInstall(type: NodeTask) {
5050
"--config.storage.packages=${gradle.getGradleUserHomeDir()}/caches/bower/packages",
5151
"--config.storage.registry=${gradle.getGradleUserHomeDir()}/caches/bower/registry",
5252
'install']
53-
// inputs.files file('bower.json')
53+
inputs.files file('bower.json')
5454
outputs.files file('grails-app/assets/bower_components')
5555
dependsOn npmPackages
5656
}
@@ -483,8 +483,10 @@ task stop(type: Exec) {
483483
bowerInstall.finalizedBy cleanUpBowerDependencies
484484
stop.finalizedBy stopContainers
485485

486-
487-
task war(type: Exec, dependsOn: bowerInstall) {
486+
task deleteUnnecessaryJavascript(type: Delete) {
487+
delete 'grails-app/assets/bower_components/d3/test', 'grails-app/assets/bower_components/validator-js/src', 'grails-app/assets/bower_components/validator-js/lib'
488+
}
489+
task war(type: Exec, dependsOn: [bowerInstall, deleteUnnecessaryJavascript]) {
488490
description = "Build production war of MX application"
489491
commandLine grailsw, 'war', '--non-interactive', '--stacktrace'
490492
}

ModelCatalogueCorePluginTestApp/grails-app/assets/other/d3_data_model_view/init.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@
33
//= require underscore/underscore-min.js
44
//= require_self
55
// @flow
6+
/**
7+
* D3 basicView/basic data model view
8+
*/
69

710
// exposed variable
811
var serverUrl = ""
@@ -123,7 +126,9 @@ var initD3 = (function() {
123126
}
124127

125128
function writeMessage(text) {
126-
$('#d3-info-messages').append("<li>" + (new Date().toLocaleString()) + ":<br/>" + text + "</li>")
129+
console.log((new Date().toLocaleString()))
130+
console.log(text)
131+
127132
}
128133

129134

ModelCatalogueCorePluginTestApp/grails-app/assets/other/d3_data_model_view/style.css

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -44,20 +44,21 @@
4444
}
4545

4646
.column-left {
47-
width: 60%;
47+
width: 75%;
4848
}
4949

5050
.column-right {
51-
width: 20%;
52-
overflow: scroll;
53-
border: solid 3px;
54-
}
55-
.column-right-2 {
56-
width: 20%;
51+
width: 25%;
5752
overflow: scroll;
5853
border: solid 3px;
5954
}
6055

56+
/*.column-right-2 {*/
57+
/*width: 20%;*/
58+
/*overflow: scroll;*/
59+
/*border: solid 3px;*/
60+
/*}*/
61+
6162
.info-box {
6263
padding: 0.8em;
6364

ModelCatalogueCorePluginTestApp/grails-app/views/dataModel/d3_data_model_view.gsp

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
// @flow
22
<%--
3+
Basic Data Model View, using D3.js (basicView)
34
Created by IntelliJ IDEA.
45
User: james
56
Date: 16/05/2018
@@ -70,17 +71,18 @@
7071
</div>
7172

7273

73-
7474
</div>
7575

76-
<div id="d3-messages" class="column column-right-2">
77-
<div class="info-box">
78-
<h2><u>Messages:</u></h2>
79-
<ul id="d3-info-messages">
76+
%{--<div id="d3-messages" class="column column-right-2">--}%
77+
%{--<div class="info-box">--}%
78+
%{--<h2><u>Messages:</u></h2>--}%
79+
%{--<ul id="d3-info-messages">--}%
80+
81+
%{--</ul>--}%
82+
%{--</div>--}%
83+
%{--</div>--}%
84+
8085

81-
</ul>
82-
</div>
83-
</div>
8486
</div>
8587

8688

0 commit comments

Comments
 (0)