builds and all tests pass

Author: MaximilianToe

src/communication/NotificationSink.cpp

@@ -78,6 +78,6 @@ NotificationSink::SinkOrStatus NotificationSink::create(
 NotificationSink::NotificationSink(
     std::shared_ptr<transport::UTransport> transport,
     NotificationSink::ListenHandle&& listener)
-    : transport_(std::move(transport)), listener_(listener) {}
+    : transport_(std::move(transport)), listener_(std::move(listener)) {}
 
 }  // namespace uprotocol::communication

src/communication/RpcClient.cpp

@@ -71,7 +71,7 @@ struct RpcClient::ExpireService {
 	             std::function<void(v1::UStatus)> expire) const {
 		detail::PendingRequest pending;
 		pending.when_expire = when_expire;
-		pending.response_listener = response_listener;
+		pending.response_listener = std::move(response_listener);
 		pending.expire = std::move(expire);
 		pending.instance_id = instance_id_;
 
@@ -128,7 +128,7 @@ RpcClient::InvokeHandle RpcClient::invokeMethod(v1::UMessage&& request,
 
 	auto connected_pair =
 	    Connection::establish(std::move(callback));
-	auto callback_handle = std::get<0>(connected_pair);
+	auto callback_handle = std::move(std::get<0>(connected_pair));
 	auto callable = std::get<1>(connected_pair);
 
 	///////////////////////////////////////////////////////////////////////////
@@ -240,7 +240,7 @@ RpcClient::InvokeFuture& RpcClient::InvokeFuture::operator=(
 
 RpcClient::InvokeFuture::InvokeFuture(std::future<MessageOrStatus>&& future,
                                       InvokeHandle&& handle) noexcept
-    : callback_handle_(handle), future_(std::move(future)) {}
+    : callback_handle_(std::move(handle)), future_(std::move(future)) {}
 
 }  // namespace uprotocol::communication
 
@@ -355,7 +355,7 @@ void ExpireWorker::doWork() {
 				if (when_expire <= now) {
 					maybe_expire = std::move(pending_.top().expire);
 					expired_handle =
-					    pending_.top().response_listener;
+					    std::move(pending_.top().response_listener);
 					pending_.pop();
 				}
 			}

src/communication/Subscriber.cpp

@@ -47,7 +47,7 @@ namespace uri_validator = uprotocol::datamodel::validator::uri;
 
 Subscriber::Subscriber(std::shared_ptr<transport::UTransport> transport,
                        ListenHandle&& subscription)
-    : transport_(std::move(transport)), subscription_(subscription) {
+    : transport_(std::move(transport)), subscription_(std::move(subscription)) {
 	// Constructor body. Any additional setup can go here.
 	if (!transport_) {
 		throw transport::NullTransport("transport cannot be null");

src/transport/UTransport.cpp

@@ -89,7 +89,7 @@ UTransport::HandleOrStatus UTransport::registerListener(
 	    std::move(callable), source_filter, std::move(sink_filter));
 
 	if (status.code() == v1::UCode::OK) {
-		return HandleOrStatus(handle);
+		return HandleOrStatus(std::move(handle));
 	}
 	return HandleOrStatus(utils::Unexpected<v1::UStatus>(status));
 }