linting fixes and pinned clang-tidy 13 in ci.yml

Author: MaximilianToe

.github/workflows/ci.yml

@@ -430,6 +430,7 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
           repo-root: up-cpp
+          version: 13
           ignore: 'test'
           style: 'file' # read .clang-format for configuration
           tidy-checks: '' # Read .clang-tidy for configuration

include/up-cpp/datamodel/builder/Payload.h

@@ -79,7 +79,7 @@ struct Payload {
 	///          will compile out.
 	/// @param data Data to be serialized and stored.
 	template <typename Serializer, typename ValueT>
-	Payload(Serializer s, const ValueT& data) {
+	Payload(Serializer s [[maybe_unused]], const ValueT& data) {
 		auto serialized_data = Serializer::serialize(data);
 		if (!UPayloadFormat_IsValid(
 		        std::get<PayloadType::Format>(serialized_data))) {

src/communication/NotificationSource.cpp

@@ -13,7 +13,8 @@
 
 namespace uprotocol::communication {
 
-using namespace uprotocol::datamodel::builder;
+using  uprotocol::datamodel::builder::UMessageBuilder;
+
 NotificationSource::NotificationSource(
     std::shared_ptr<transport::UTransport> transport, v1::UUri&& source,
     v1::UUri&& sink, std::optional<v1::UPayloadFormat> payload_format,

src/communication/Publisher.cpp

@@ -14,7 +14,7 @@
 #include <up-cpp/datamodel/builder/UMessage.h>
 
 namespace uprotocol::communication {
-using namespace uprotocol::datamodel::builder;
+using uprotocol::datamodel::builder::UMessageBuilder;
 
 Publisher::Publisher(std::shared_ptr<transport::UTransport> transport,
                      v1::UUri&& topic, v1::UPayloadFormat format,

src/communication/RpcClient.cpp

@@ -20,13 +20,15 @@
 namespace {
 namespace detail {
 
-using namespace uprotocol;
+using uprotocol::v1::UStatus;
+using ListenHandle = uprotocol::transport::UTransport::ListenHandle;
 
 struct PendingRequest {
+private:
 	std::chrono::steady_clock::time_point when_expire;
-	transport::UTransport::ListenHandle response_listener;
-	std::function<void(v1::UStatus)> expire;
-	size_t instance_id;
+	ListenHandle response_listener;
+	std::function<void(UStatus)> expire;
+	size_t instance_id{};
 
 	auto operator>(const PendingRequest& other) const;
 };

test/coverage/communication/NotificationSinkTest.cpp

@@ -45,6 +45,7 @@ class NotificationSinkTest : public testing::Test {
 	static void SetUpTestSuite() {}
 	static void TearDownTestSuite() {}
 
+private:
 	uprotocol::v1::UUri testTopicUUri_;
 	uprotocol::v1::UUri testInvalidTopicUUri_;
 	uprotocol::v1::UUri testDefaultSourceUUri_;