feat: default to github-dark for codemirror theme in dark mode (see #108)

Author: MathiasVDA

packages/yasgui/src/TabSettingsModal.ts

@@ -452,7 +452,7 @@ export default class TabSettingsModal {
     });
 
     const storedDarkTheme = this.tab.yasgui.persistentConfig.getCodeMirrorTheme("dark");
-    themeDarkSelect.value = storedDarkTheme || "material-palenight";
+    themeDarkSelect.value = storedDarkTheme || "github-dark";
 
     themeDarkSection.appendChild(themeDarkLabel);
     themeDarkSection.appendChild(themeDarkHelp);
@@ -1491,7 +1491,7 @@ export default class TabSettingsModal {
       const currentMode = this.tab.yasgui.getTheme();
       const themeToApply =
         currentMode === "dark"
-          ? codeMirrorThemeDarkSelect?.value || "material-palenight"
+          ? codeMirrorThemeDarkSelect?.value || "github-dark"
           : codeMirrorThemeLightSelect?.value || "default";
 
       // Apply theme to all CodeMirror instances

packages/yasgui/src/ThemeManager.ts

@@ -74,10 +74,10 @@ export class ThemeManager {
     let cmTheme: string;
     if (this.persistentConfig) {
       const storedTheme = this.persistentConfig.getCodeMirrorTheme(theme);
-      cmTheme = storedTheme || (theme === "dark" ? "material-palenight" : "default");
+      cmTheme = storedTheme || (theme === "dark" ? "github-dark" : "default");
     } else {
       // Fallback if persistentConfig not yet available
-      cmTheme = theme === "dark" ? "material-palenight" : "default";
+      cmTheme = theme === "dark" ? "github-dark" : "default";
     }
 
     // Find all CodeMirror instances within the root element