perf: 优化 JSON 校验失败的返回值

Author: AlisaAkiron

src/MaaCopilotServer.Infrastructure/Services/OperationProcessService.cs

@@ -3,6 +3,7 @@
 // Licensed under the AGPL-3.0 license.
 
 using System.Text.Json;
+using System.Text.Json.Serialization;
 using MaaCopilotServer.Application.Common.Interfaces;
 using MaaCopilotServer.Application.Common.Models;
 using MaaCopilotServer.Application.Common.Operation.Model;
@@ -12,6 +13,7 @@
 using Microsoft.EntityFrameworkCore;
 using Microsoft.Extensions.Options;
 using NJsonSchema;
+using Action = MaaCopilotServer.Application.Common.Operation.Model.Action;
 
 namespace MaaCopilotServer.Infrastructure.Services;
 
@@ -21,6 +23,11 @@ public class OperationProcessService : IOperationProcessService
     private readonly ValidationErrorMessage _validationErrorMessage;
     private readonly JsonSchema _schema;
 
+    private static readonly JsonSerializerOptions s_failedSerializerOptions = new()
+    {
+        DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull
+    };
+    
     public OperationProcessService(
         IMaaCopilotDbContext dbContext,
         ValidationErrorMessage validationErrorMessage,
@@ -73,7 +80,7 @@ public async Task<OperationValidationResult> Validate(string? operation)
             };
         }
 
-        var levelId = operationObj!.StageName;
+        var levelId = operationObj.StageName;
         var level = await _dbContext.ArkLevelData.FirstOrDefaultAsync(x => x.LevelId == levelId);
         if (level is null)
         {
@@ -86,8 +93,6 @@ public async Task<OperationValidationResult> Validate(string? operation)
             };
         }
 
-        var failed = false;
-
         if (operationObj.Actions is null)
         {
             return new OperationValidationResult
@@ -99,46 +104,30 @@ public async Task<OperationValidationResult> Validate(string? operation)
             };
         }
 
-        foreach (var action in operationObj.Actions)
-        {
-            var type = GetTypeUnifiedString(action.Type);
+        var failedArea = operationObj.Actions
+            .Select(FailedCheck)
+            .ToList();
 
-            failed = type switch
-            {
-                // When type is "Deploy", operator name, deploy location and deploy direction could not be null.
-                "deploy" => action.Name is null || action.Location is null || DirectionIsValid(action.Direction) is false,
-                // When type is "Skill", operator name could not be null.
-                "skill" => action.Name is null,
-                // When type is "Retreat", operator name and deploy location could not be null at the same time.
-                "retreat" => action.Name is null && action.Location is null,
-                // When type is "Skill Usage", skill_usage could not be null.
-                "speedup" => failed,
-                "bullettime" => failed,
-                "skillusage" => action.SkillUsage is null,
-                "output" => action.Doc is null,
-                "skilldaemon" => failed,
-                _ => true
-            };
+        failedArea.RemoveAll(x => x is null);
 
-            if (failed)
+        if (failedArea.Count == 0)
+        {
+            return new OperationValidationResult
             {
-                return new OperationValidationResult
-                {
-                    IsValid = false,
-                    Operation = null,
-                    ErrorMessages = _validationErrorMessage.CopilotOperationJsonIsInvalid!,
-                    ArkLevel = null
-                };
-            }
+                IsValid = true, Operation = operationObj, ErrorMessages = string.Empty, ArkLevel = level
+            };
         }
 
+        var failedAreaMessage = $"{_validationErrorMessage.CopilotOperationJsonIsInvalid}\n{string.Join("\n", failedArea)}";
+            
         return new OperationValidationResult
         {
-            IsValid = true,
-            Operation = operationObj,
-            ErrorMessages = string.Empty,
-            ArkLevel = level
+            IsValid = false,
+            Operation = null,
+            ErrorMessages = failedAreaMessage,
+            ArkLevel = null
         };
+
     }
 
     private static string GetTypeUnifiedString(string? type) => type?.ToLower() switch
@@ -160,4 +149,31 @@ public async Task<OperationValidationResult> Validate(string? operation)
         "左" or "右" or "上" or "下" or "无" => true,
         _ => false
     };
+
+    private static string? FailedCheck(Action action)
+    {
+        var type = GetTypeUnifiedString(action.Type);
+        
+        // false => It's OK; true => Error;
+        var validationResult = type switch
+        {
+            // When type is "Deploy", operator name, deploy location and deploy direction could not be null.
+            "deploy" => action.Name is null || action.Location is null || DirectionIsValid(action.Direction) is false,
+            // When type is "Skill", operator name could not be null.
+            "skill" => action.Name is null,
+            // When type is "Retreat", operator name and deploy location could not be null at the same time.
+            "retreat" => action.Name is null && action.Location is null,
+            // When type is "Skill Usage", skill_usage could not be null.
+            "speedup" => false,
+            "bullettime" => false,
+            "skillusage" => action.SkillUsage is null,
+            "output" => action.Doc is null,
+            "skilldaemon" => false,
+            _ => true
+        };
+        
+        return validationResult is false
+            ? null
+            : JsonSerializer.Serialize(action, s_failedSerializerOptions);
+    }
 }