Merge pull request #169 from Longwater1234/dev

Build badge status on README

Author: Longwater1234

CMakeLists.txt

@@ -63,7 +63,7 @@ target_include_directories(SpaceCheckers PUBLIC ${SFML_HOME}/include)
 if(MSVC)
   target_compile_options(SpaceCheckers PRIVATE /W4 /sdl)
 else()
-  target_compile_options(SpaceCheckers PRIVATE -Wall -Werror=constant-conversion)
+  target_compile_options(SpaceCheckers PRIVATE -Wall -Werror=constant-conversion -Werror=fortify-source)
 endif()
 
 # COPY resources folder to destination

README.md

@@ -1,5 +1,7 @@
 # space - checkers
 
+[![CMake on Windows platform](https://github.com/Longwater1234/space-checkers/actions/workflows/cmake-single-platform.yml/badge.svg?branch=main)](https://github.com/Longwater1234/space-checkers/actions/workflows/cmake-single-platform.yml)
+
 Offline & Online Multiplayer Checkers game in C++ built with SFML 2.6, imGui, Protobuf and ixWebsockets. With very minimal dependencies
 and a simple build process. All dependencies are auto-downloaded (as `.tar.gz`) and configured for you using [CPM.cmake](https://github.com/cpm-cmake/CPM.cmake). The only dependency you need pre-installed on your OS is SFML 2.6.x (or newer).
 

src/GameManager.hpp

@@ -23,7 +23,9 @@
 
 namespace chk
 {
+// cell ptr
 using Block = std::unique_ptr<chk::Cell>;
+// player ptr
 using PlayerPtr = std::unique_ptr<chk::Player>;
 
 constexpr uint16_t NUM_ROWS{8};

src/WsClient.cpp

@@ -170,6 +170,9 @@ void WsClient::parseServerList(const cpr::Response &response)
     {
         this->deathNote = ex.what();
         this->isDead = true;
+#ifndef NDEBUG
+        spdlog::error(ex.what());
+#endif // DEBUG
     }
 }
 

src/managers/LocalGameManager.hpp

@@ -36,12 +36,12 @@ inline LocalGameManager::LocalGameManager(sf::RenderWindow *windowPtr)
 }
 
 /**
- * Create all pieces for both players and add them to pieceList, using std C++ random num generator
+ * Create all pieces for both players (using std C++ PRNG), then place them on the board.
  */
 inline void LocalGameManager::createAllPieces()
 {
     std::random_device randomDevice;
-    std::mt19937 randEngine(randomDevice());
+    std::mt19937 randEngine{randomDevice()};
     std::uniform_int_distribution<short> dist(1, std::numeric_limits<short>::max());
 
     // Reserve container for pieces on board

src/managers/OnlineGameManager.hpp

@@ -87,9 +87,9 @@ inline void chk::OnlineGameManager::createAllPieces()
         std::vector<chk::PiecePtr> pieceList;
         pieceList.reserve(chk::NUM_PIECES);
 
-        auto redItr = payload.pieces_red().begin();
-        auto blackItr = payload.pieces_black().begin();
-        // create pieces objects, and position them on Board
+        auto redItr = payload.pieces_red().begin();     // red iterator
+        auto blackItr = payload.pieces_black().begin(); // black iterator
+        // place them on board
         for (uint16_t row = 0; row < chk::NUM_ROWS; row++)
         {
             for (uint16_t col = 0; col < chk::NUM_COLS; col++)
@@ -132,7 +132,7 @@ inline void chk::OnlineGameManager::createAllPieces()
                 this->playerBlack->receivePiece(pp);
             }
         }
-        pieceList.clear(); // SAFE! no longer used.
+        pieceList.clear(); // SAFE! no longer needed.
         this->startMoveListener();
         this->startCaptureListener();
     });