🐛 Fixing issue with debug logs (#221)

* ✏️ Fixed Typo

* 👽 Adjusted CSDS to match latest state

* 🐛 Fixed debug logs

* 🔧 Removed outdated Node Version

* ♻️ adjusted csds for cli itself

---------

Co-authored-by: spelczer <[email protected]>

Author: Templum

.github/workflows/testBranch.yml

@@ -16,7 +16,7 @@ jobs:
     strategy:
       matrix:
         # run on all supported LTS versions and the latest/current version
-        node-version: [14, 16, 18, latest]
+        node-version: [18, latest]
 
     steps:
     - uses: actions/checkout@v3

bin/example/bin/rewire.js

@@ -71,13 +71,13 @@ function isLoggableError(error) {
 
 class Logger {
   constructor(debug) {
-    this.debug = debug;
+    this.isDebugMode = debug;
     this.history = [];
   }
 
   writeLogs(level, message, ...optionalParams) {
-    // if (!this.isDebugMode && level === LogLevels.Debug) return;
-    if (this.debug) {
+
+    if (this.isDebugMode) {
       if (Object.hasOwnProperty.call(message, 'errorMsg')) {
         stdout.log(`[${level}] - ${message.errorMsg}`, ...optionalParams);
       } else if (hasOptionals(optionalParams)) {

src/service/csds.service.ts

@@ -80,19 +80,18 @@ export class CsdsClient {
   }
 
   private getUrl(): string {
-    return `http://${this.getCsdsDomain()}/api/account/${
+    return `https://${this.getCsdsDomain()}/api/account/${
       this.accountId
     }/service/baseURI.json?version=1.0`;
   }
 
   private getCsdsDomain(): string {
-    if (this.accountId.startsWith('le') || this.accountId.startsWith('qa')) {
-      return 'hc1n.dev.lprnd.net';
+    if (this.accountId?.startsWith('le') || this.accountId?.startsWith('qa')) {
+      return 'lp-csds-qa.dev.lprnd.net';
     }
-    if (this.accountId.startsWith('fr')) {
+    if (this.accountId?.startsWith('fr')) {
       return 'adminlogin-z0-intg.liveperson.net';
     }
-    // alpha/production
-    return 'adminlogin.liveperson.net';
+    return 'api.liveperson.net';
   }
 }

src/shared/faas-debugger.ts

@@ -247,7 +247,7 @@ export class FaasDebugger {
       /* eslint-enable */
       this.port = await getPort({ port: getPort.makeRange(30500, 31000) });
     }
-    this.udpatePortForFiles();
+    this.updatePortForFiles();
     const args = [
       `--inspect-brk=${this.port}`,
       join(this.functionPath, 'index.js'),
@@ -392,7 +392,7 @@ ${originalCode}
     writeFileSync(filePath, content);
   }
 
-  private udpatePortForFiles() {
+  private updatePortForFiles() {
     /* istanbul ignore else */
     if (existsSync(join(this.cwd, '.vscode', 'launch.json'))) {
       this.updatePort(join(this.cwd, '.vscode', 'launch.json'));

src/shared/lp-faas-toolbelt/csds-client/csdsClient.ts

@@ -83,18 +83,12 @@ export class CsdsClient implements ICsdsClient {
   }
 
   private getUrl(): string {
-    return `http://${this.getCsdsDomain()}/api/account/${
+    return `https://${this.getCsdsDomain()}/api/account/${
       this.accountId
     }/service/baseURI.json?version=1.0`;
   }
 
   private getCsdsDomain(): string {
-    return process.env.CSDS_DOMAIN
-      ? process.env.CSDS_DOMAIN
-      : this.deriveCsdsDomainFromAccountId();
-  }
-
-  private deriveCsdsDomainFromAccountId(): string {
     if (this.accountId?.startsWith('le') || this.accountId?.startsWith('qa')) {
       return 'lp-csds-qa.dev.lprnd.net';
     }
@@ -103,6 +97,7 @@ export class CsdsClient implements ICsdsClient {
     }
     return 'api.liveperson.net';
   }
+
 }
 
 async function getAccountId() {
@@ -124,7 +119,7 @@ async function getAccountId() {
   }
 }
 
-async function getCrpytoConfig(): Promise<{
+async function getCryptoConfig(): Promise<{
   algorithm: string;
   key: Buffer;
   iv: string;
@@ -145,7 +140,7 @@ async function getCrpytoConfig(): Promise<{
 }
 
 async function decrypt(data: any) {
-  const { algorithm, key, iv } = await getCrpytoConfig();
+  const { algorithm, key, iv } = await getCryptoConfig();
   const decipher = crypto.createDecipheriv(algorithm, key, iv);
   let decrypted = decipher.update(data, 'hex', 'utf8');
   decrypted += decipher.final('utf8');