Fixed secret storing to settings.json (#248)

Co-authored-by: cbrutscher <cbrutscher@liveperson.com>

Author: chrbrt

package.json

@@ -1,7 +1,7 @@
 {
   "name": "liveperson-functions-cli",
   "description": "LivePerson Functions CLI",
-  "version": "2.0.3-beta",
+  "version": "2.0.4-beta",
   "author": {
     "name": "LivePersonInc",
     "email": "faas-lp@liveperson.com"

src/shared/core-functions-toolbelt/secret-storage/secretClient.ts

@@ -73,7 +73,7 @@ export class FunctionsSecretClient implements ISecretClient {
 
       this.secretCache.set(secret.key, secret as CachedSecret);
 
-      return { key: secret.key, value: JSON.parse(secret.value as any) };
+      return { key: secret.key, value: secret.value };
     } catch (error) {
       throw newSecretClientError(
         ErrorCodes.Secret.NotFound,
@@ -130,7 +130,7 @@ export class FunctionsSecretClient implements ISecretClient {
 
       settings.secrets[index] = {
         key: secretKey,
-        value: stringifiedSecret,
+        value: newSecretValue,
       };
       this.fs.writeFileSync(this.path, JSON.stringify(settings, null, 4));
 

test/shared/core-functions-toolbelt/secret-storage/secretClient.test.ts

@@ -80,7 +80,7 @@ describe('FunctionsSecretClient', () => {
 
       expect(result).toEqual({
         key: mockSecret.key,
-        value: JSON.parse(mockSecret.value),
+        value: mockSecret.value,
       });
       expect(mockFs.readFileSync).toHaveBeenCalledWith(
         expect.stringContaining('functions/settings.json'),
@@ -101,7 +101,7 @@ describe('FunctionsSecretClient', () => {
 
       expect(result).toEqual({
         key: mockSecret.key,
-        value: JSON.parse(mockSecret.value),
+        value: mockSecret.value,
       });
       expect(mockCache.has).not.toHaveBeenCalled();
       expect(mockFs.readFileSync).toHaveBeenCalled();
@@ -149,8 +149,8 @@ describe('FunctionsSecretClient', () => {
   describe('updateSecret', () => {
     const mockSettings = {
       secrets: [
-        { key: 'ExistingKey', value: '"ExistingValue"' },
-        { key: 'AnotherKey', value: '"AnotherValue"' },
+        { key: 'ExistingKey', value: 'ExistingValue' },
+        { key: 'AnotherKey', value: 'AnotherValue' },
       ],
     };
 
@@ -169,7 +169,7 @@ describe('FunctionsSecretClient', () => {
       expect(result).toEqual(updatedSecret);
       expect(mockFs.writeFileSync).toHaveBeenCalledWith(
         expect.stringContaining('functions/settings.json'),
-        expect.stringContaining('"\\"NewValue\\""'),
+        expect.stringContaining('NewValue'),
       );
       expect(mockCache.set).toHaveBeenCalledWith('ExistingKey', {
         key: 'ExistingKey',
@@ -279,11 +279,11 @@ describe('FunctionsSecretClient', () => {
       expect(writtenData.secrets).toHaveLength(2);
       expect(writtenData.secrets[0]).toEqual({
         key: 'ExistingKey',
-        value: '"UpdatedValue"',
+        value: 'UpdatedValue',
       });
       expect(writtenData.secrets[1]).toEqual({
         key: 'AnotherKey',
-        value: '"AnotherValue"',
+        value: 'AnotherValue',
       });
     });