Experimental CALL clause and batch api, looking for feedback #219
Replies: 8 comments 3 replies
-
|
There are 67 commits in that feature branch. I can't go through all of them to assess. Could you summarize it for normal humans? :) |
Beta Was this translation helpful? Give feedback.
-
|
New features in my fork master + help needed (CALL subquery bug)
Everything else (regular queries, batch API, other Node/Cypher features) works. The only known failure is when executing certain CALL subquery queries. Help needed: crash in CALL subquerySymptom: SIGSEGV (exit 139) when running a query like: CALL () { RETURN 1 AS x } RETURN x
How to reproduce:
What already tried: What would help:
If you can run a RelWithDebInfo build and reproduce the crash, a backtrace and any extra findings would be very helpful. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks. I can help with getting a stack trace. |
Beta Was this translation helpful? Give feedback.
-
|
Re: this commit I just landed something in master to fix windows build in CI. What version of MSVC are you using? Why is CI passing without this fix? |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
Also suggest you frequently rebase against origin/master instead of creating merge commits. I ran this prompt against an agent: Results are here: https://github.com/adsharma/ladybug/tree/rebased_call_subquery (19 fewer commits) Also, please regroup the commits and review the commit messages. Some of the commit messages are stale and do not reflect what's in the code. Suggested grouping:
Instead of carrying 54 commits in a branch, I'd spend time on sending small PRs (preferably one commit at a time) that pass CI. |
Beta Was this translation helpful? Give feedback.
-
|
Based on this overview, I think https://claude.ai/share/a8fb6e21-35f1-4219-8b14-f3123205c8e2 |
Beta Was this translation helpful? Give feedback.
-
|
I'm leaving my works here, have no more time and resources to push it further and fight bugs in core. Hope you find it useful and it will be good base for new cool features. pr/table-function-multiplicity Thank you for support and good luck. P.S. I've architected hypergraph DB engine and started implementing it here https://github.com/vkozio/afh so wish me luck:) |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
feature/call-subquery-clause
feature/query-batch-api
@adsharma
Beta Was this translation helpful? Give feedback.
All reactions