[dune-core] compilation errors on windows

[oysstu]

I've been distributing wheels for windows for imcpy, and I haven't been upgrading the dune version for a long time since it's pretty much only the deserialization/serialization that is being used. Upgraded to latest master now to resolve some cmake errors, and had the following build failures in the build pipeline. Can't comment on how many people actually use the Windows wheels.

I'm guessing most of the ENCManager errors are continuation errors from the "or" keyword usage.

D:\a\imcpy\imcpy\dune\src\DUNE\Control\FilterEstimator.cpp(72,18): error C2065: 'M_PI': undeclared identifier [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\Plans\TimeProfile.cpp(260,34): warning C4101: 'e': unreferenced local variable [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\Hardware\STM\FirmwareUpdate.cpp(35,10): error C1083: Cannot open include file: 'unistd.h': No such file or directory [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(47,37): warning C4101: 'e': unreferenced local variable [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(84,35): warning C4101: 'e': unreferenced local variable [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(133,35): warning C4101: 'e': unreferenced local variable [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(181,35): warning C4101: 'e': unreferenced local variable [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(226,45): error C2146: syntax error: missing ')' before identifier 'or' [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(226,45): error C2065: 'or': undeclared identifier [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(226,48): error C2146: syntax error: missing ';' before identifier 'closest_distance' [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(226,70): error C2059: syntax error: ')' [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(227,40): error C2059: syntax error: ';' [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(231,34): error C2065: 'closest': undeclared identifier [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(234,7): error C2059: syntax error: 'return' [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(237,5): error C2653: 'ENCManager': is not a class or namespace name [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(237,37): error C2653: 'ENCManager': is not a class or namespace name [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(237,17): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(237,49): error C2146: syntax error: missing ';' before identifier 'getCorridor' [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(237,188): error C2143: syntax error: missing ';' before '{' [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(237,188): error C2447: '{': missing function header (old-style formal list?) [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(281,17): error C2653: 'ENCManager': is not a class or namespace name [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(297,17): error C2653: 'ENCManager': is not a class or namespace name [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(313,10): error C2653: 'ENCManager': is not a class or namespace name [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(313,41): error C2653: 'ENCManager': is not a class or namespace name [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(313,35): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(313,73): error C2143: syntax error: missing ',' before '&' [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(314,27): error C2065: 'outputFile': undeclared identifier [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(316,12): error C2653: 'ENCManager': is not a class or namespace name [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(316,45): error C2065: 'const_iterator': undeclared identifier [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(316,60): error C2146: syntax error: missing ';' before identifier 'itr' [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(316,64): error C2143: syntax error: missing ';' before '=' [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(316,64): error C2143: syntax error: missing ')' before '=' [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(316,64): error C2059: syntax error: '=' [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(316,79): error C2065: 'itr': undeclared identifier [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(316,86): error C2065: 'vec': undeclared identifier [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(316,99): error C2065: 'itr': undeclared identifier [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(316,102): error C2059: syntax error: ')' [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(318,46): error C2065: 'itr': undeclared identifier [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(318,94): error C2065: 'itr': undeclared identifier [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(318,114): error C2065: 'itr': undeclared identifier [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(318,134): error C2059: syntax error: ';' [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(320,7): error C2059: syntax error: 'return' [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(323,3): error C2059: syntax error: '}' [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(323,3): error C2143: syntax error: missing ';' before '}' [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(324,1): error C2143: syntax error: missing ';' before '}' [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]
D:\a\imcpy\imcpy\dune\src\DUNE\SituationalAwareness\ENCManager.cpp(324,1): error C2059: syntax error: '}' [D:\a\imcpy\imcpy\build\temp.win-amd64-cpython-313\Release\dune\dune-core.vcxproj]

[paulosousadias]

Thanks for the warning. We will look at it