Merge pull request #17 from KsWare/features/kux

Features/kux

Author: SchreinerK

ChangeLog.md

@@ -1,9 +1,18 @@
+# 0.20
+- BREAKING CHANGE ValueChangedEventArgs swap arguments and rename PreviousValue to OldValue, so that you get a compiler error on event handlers. If you create ValueChangedEventArgs you have to swap the arguments manually. No Warning in this case!
+- add SimpleCommand.RaiseCanExecuteChanged
+- ValueChangedEventArgs no longer returns DependencyProperty.UnsetValue, so this is consistent to ValueChangedEventArgs<T>
+- ActionVM supports async methods  Task DoAnything(), Task DoAnything(object)
+
 # 0.19
 - convert to SDK format
 - TargetFrameworks: net5.0-windows, netcoreapp3.1, net45
 - add WindowVM.Owner
 - add MenuItemVM.Command
 - add MenuItemVM.CommandParameter
+- add WindowVM.ClosingEvent
+- DataTypeConverter.Convert: fix System.InvalidCastException
+- DebugType=embedded and DebugSymbols=true for each configuration 
 
 # 0.18
 - split KsWare.Presentation.Behavior

src/KsWare.Presentation.Behavior.Common/KsWare.Presentation.Behavior.Common.csproj

@@ -34,12 +34,12 @@
     <PackageIcon>PackageIcon.png</PackageIcon>
     <PackageIconUrl />
   </PropertyGroup>
+  <PropertyGroup>
+    <DebugType>embedded</DebugType>
+    <DebugSymbols>true</DebugSymbols>
+  </PropertyGroup>
   <ItemGroup>
     <PackageReference Include="JetBrains.Annotations" Version="2021.2.0" />
-    <PackageReference Include="Microsoft.DotNet.UpgradeAssistant.Extensions.Default.Analyzers" Version="0.3.242703">
-      <PrivateAssets>all</PrivateAssets>
-    </PackageReference>
-    <PackageReference Include="Microsoft.Windows.Compatibility" Version="5.0.2" />
   </ItemGroup>
   <ItemGroup>
     <None Include="Properties\PackageIcon.png">

src/KsWare.Presentation.Behavior/KsWare.Presentation.Behavior.csproj

@@ -34,11 +34,13 @@
     <PackageIcon>PackageIcon.png</PackageIcon>
     <PackageIconUrl />
   </PropertyGroup>
+  <PropertyGroup>
+    <DebugType>embedded</DebugType>
+    <DebugSymbols>true</DebugSymbols>
+  </PropertyGroup>
   <ItemGroup>
     <PackageReference Include="JetBrains.Annotations" Version="2021.2.0" />
     <PackageReference Include="Microsoft.Xaml.Behaviors.Wpf" Version="1.1.31" />
-    <PackageReference Include="Microsoft.DotNet.UpgradeAssistant.Extensions.Default.Analyzers" Version="0.3.242703" />
-    <PackageReference Include="Microsoft.Windows.Compatibility" Version="5.0.2" />
   </ItemGroup>
   <ItemGroup>
     <None Include="Properties\PackageIcon.png">

src/KsWare.Presentation.BusinessFramework/(ObjectModel)/ObjectBM~Hierarchy.cs

@@ -36,7 +36,7 @@ public virtual IObjectBM Parent {
 				if (Equals(_parent,value)) return;
 				var prev = _parent;
 				SetParentPattern.Execute(ref _parent, value, "Parent");
-				OnParentChanged(new ValueChangedEventArgs(prev,value));
+				OnParentChanged(new ValueChangedEventArgs(value, prev));
 			}
 		}
 

src/KsWare.Presentation.BusinessFramework/(ObjectModel)/RefBM.cs

@@ -80,7 +80,7 @@ public TRef Target {
 //				}
 				if(Metadata.DataProvider.Data!=null) throw new NotImplementedException("Metadata.DataProvider.Data is not null!");
 
-				var e=new ValueChangedEventArgs<TRef>(old,_target);
+				var e=new ValueChangedEventArgs<TRef>(_target, old);
 				EventUtil.Raise(TargetChanged,this,e,"{0524E629-61C7-4517-BB1F-3B46BE3FD5C8}");
 				EventManager.Raise<EventHandler<ValueChangedEventArgs<TRef>>,ValueChangedEventArgs<TRef>>(LazyWeakEventStore,"TargetChangedEvent",e);
 				OnBusinessPropertyChanged(new BusinessPropertyChangedEventArgs("Target"));

src/KsWare.Presentation.BusinessFramework/(ObjectModel)/ValueBM.cs

@@ -149,7 +149,7 @@ protected override void OnMetadataChanged() {
 		}
 
 		private void AtDataProviderDataChanged(object sender, DataChangedEventArgs e) { 
-			OnValueChanged(new ValueChangedEventArgs(e.PreviousData,e.NewData));
+			OnValueChanged(new ValueChangedEventArgs(e.NewData, e.PreviousData));
 		}
 
 		/// <summary> Gets the value settings.

src/KsWare.Presentation.BusinessFramework/KsWare.Presentation.BusinessFramework.csproj

@@ -38,14 +38,13 @@
     <AssemblyOriginatorKeyFile>Properties\KsWare.Presentation.snk</AssemblyOriginatorKeyFile>
     <DelaySign>false</DelaySign>
   </PropertyGroup>
+  <PropertyGroup>
+    <DebugType>embedded</DebugType>
+    <DebugSymbols>true</DebugSymbols>
+  </PropertyGroup>
   <ItemGroup>
     <ProjectReference Include="..\KsWare.Presentation.Core\KsWare.Presentation.Core.csproj" />
   </ItemGroup>
-  <ItemGroup>
-    <PackageReference Include="Microsoft.DotNet.UpgradeAssistant.Extensions.Default.Analyzers" Version="0.3.242703">
-      <PrivateAssets>all</PrivateAssets>
-    </PackageReference>
-  </ItemGroup>
   <ItemGroup>
     <None Include="Properties\PackageIcon.png">
       <Pack>True</Pack>

src/KsWare.Presentation.BusyManager.Tests/KsWare.Presentation.BusyManager.TestApp.csproj

@@ -22,9 +22,4 @@
     <ProjectReference Include="..\KsWare.Presentation.ViewFramework\KsWare.Presentation.ViewFramework.csproj" />
     <ProjectReference Include="..\KsWare.Presentation.ViewModelFramework\KsWare.Presentation.ViewModelFramework.csproj" />
   </ItemGroup>
-  <ItemGroup>
-    <PackageReference Include="Microsoft.DotNet.UpgradeAssistant.Extensions.Default.Analyzers" Version="0.3.242703">
-      <PrivateAssets>all</PrivateAssets>
-    </PackageReference>
-  </ItemGroup>
 </Project>

src/KsWare.Presentation.Core/(BackingFieldsStore)/(FieldBindings)/FieldBindingOperations.cs

@@ -30,7 +30,7 @@ public static void SetBinding(BackingFieldsStore.IBackingFieldInfo target, Field
 
 			if (binding.Converter == null) binding.Converter = DataTypeConverter.Default;
 			var existingBinding = GetBindings(binding.Source, target);
-			if (existingBinding != null) throw new InvalidOperationException("Allready binding configured!"); // TODO concept: silent overwrite synchronization?
+			if (existingBinding != null) throw new InvalidOperationException("Binding already configured!"); // TODO concept: silent overwrite synchronization?
 
 			binding.Target = target;
 			switch (binding.Mode) {

src/KsWare.Presentation.Core/(BackingFieldsStore)/BackingFieldsStore.cs

@@ -224,7 +224,7 @@ private void OnPropertyChanged(string propertyName, object oldValue, object newV
 
 			var fieldInfo = _fields[propertyName];
 			var eventHandlerInfos = fieldInfo.EventHandlers;
-			var ea=new ValueChangedEventArgs(oldValue,newValue);
+			var ea=new ValueChangedEventArgs(newValue, oldValue);
 			foreach (var eventHandlerInfo in eventHandlerInfos) { eventHandlerInfo.PropertyChangedEventHandler(_owner, ea); }
 			EventManager.Raise<EventHandler<ValueChangedEventArgs>,ValueChangedEventArgs>(fieldInfo.LazyWeakEventProperties,"ValueChangedEvent",ea);
 		}